fix(mattermost): fail closed on missing channel type [AI] by pgondhi987 · Pull Request #84091 · openclaw/openclaw

pgondhi987 · 2026-05-19T10:45:57Z

Summary

Problem: Mattermost inbound post and interaction routing treated an unavailable channel type as a regular channel.
Solution: Drop posts and interaction dispatch when channel type cannot be resolved, and default the shared mapper to the most restrictive chat kind for missing values.
What changed: Added guards in post handling, interaction session routing, interaction dispatch, and command authorization; updated focused regression tests.
What did NOT change (scope boundary): No config, manifest, docs, network, or credential behavior changed.

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

Related: N/A
This PR addresses a bug or regression

Motivation

Mattermost handlers need to know whether an inbound event belongs to a direct, group, or channel conversation before applying the correct routing and authorization behavior. When that lookup is unavailable, processing should stop instead of continuing under a less restrictive classification.

Real behavior proof (required for external PRs)

Behavior or issue addressed: Mattermost events with unresolved channel type are not routed as regular channel traffic.
Real environment tested: Not performed; local focused regression coverage only.
Exact steps or command run after this patch: node scripts/run-vitest.mjs extensions/mattermost/src/mattermost/monitor-gating.test.ts extensions/mattermost/src/mattermost/monitor.channel-kind.test.ts extensions/mattermost/src/mattermost/monitor.authz.test.ts extensions/mattermost/src/mattermost/monitor.inbound-system-event.test.ts
Evidence after fix (screenshot, recording, terminal capture, console output, redacted runtime log, linked artifact, or copied live output): Test Files 4 passed (4); Tests 21 passed (21)
Observed result after fix: Missing channel type maps to direct in the shared helper, command authorization denies unavailable channel type, and inbound post handling drops the event before dispatch/session recording.
What was not tested: Live Mattermost server interaction callback flow.
Before evidence (optional but encouraged): N/A

Root Cause (if applicable)

Root cause: Missing channel type fell back to channel in Mattermost chat-kind resolution.
Missing detection / guardrail: Message and interaction dispatch paths did not require a resolved channel type before routing.
Contributing context (if known): Reaction handling already had an explicit missing-type guard, but the same pattern was not applied to the other Mattermost inbound paths.

Regression Test Plan (if applicable)

Coverage level that should have caught this:
- Unit test
- Seam / integration test
- End-to-end test
- Existing coverage already sufficient
Target test or file: extensions/mattermost/src/mattermost/monitor-gating.test.ts, extensions/mattermost/src/mattermost/monitor.channel-kind.test.ts, extensions/mattermost/src/mattermost/monitor.authz.test.ts, extensions/mattermost/src/mattermost/monitor.inbound-system-event.test.ts
Scenario the test should lock in: Missing Mattermost channel type does not become regular channel traffic and does not dispatch inbound posts.
Why this is the smallest reliable guardrail: It covers the shared mapper, command authorization, and inbound monitor behavior without requiring a live Mattermost deployment.
Existing test that already covers this (if any): N/A
If no new test is added, why not: N/A

User-visible / Behavior Changes

Mattermost events are ignored when OpenClaw cannot resolve the channel type for the event.

Diagram (if applicable)

Before:
[Mattermost event] -> [channel type unavailable] -> [classified as channel] -> [continues]

After:
[Mattermost event] -> [channel type unavailable] -> [drop before routing]

Security Impact (required)

New permissions/capabilities? (Yes/No) No
Secrets/tokens handling changed? (Yes/No) No
New/changed network calls? (Yes/No) No
Command/tool execution surface changed? (Yes/No) No
Data access scope changed? (Yes/No) No
If any Yes, explain risk + mitigation: N/A

Repro + Verification

Environment

OS: Linux worktree environment
Runtime/container: Node test wrapper
Model/provider: N/A
Integration/channel (if any): Mattermost
Relevant config (redacted): Mattermost channel config using restrictive DM policy and open group policy in regression coverage

Steps

Run the focused Mattermost regression tests listed above.
Confirm missing channel type helper behavior.
Confirm unavailable channel type does not dispatch an inbound post.

Expected

Focused tests pass.
Missing channel type fails closed.
Inbound post handling stops before dispatch/session recording.

Actual

Focused tests passed: Test Files 4 passed (4); Tests 21 passed (21).

Evidence

Failing test/log before + passing after
Trace/log snippets
Screenshot/recording
Perf numbers (if relevant)

Human Verification (required)

What you personally verified (not just CI), and how:

Verified scenarios: Shared channel type mapping, command authorization with unavailable type, inbound post drop path.
Edge cases checked: undefined, null, and empty string channel type.
What you did not verify: Live Mattermost callback behavior.

Review Conversations

I replied to or resolved every bot review conversation I addressed in this PR.
I left unresolved only the conversations that still need reviewer or maintainer judgment.

Compatibility / Migration

Backward compatible? (Yes/No) Yes
Config/env changes? (Yes/No) No
Migration needed? (Yes/No) No
If yes, exact upgrade steps: N/A

Risks and Mitigations

Risk: Mattermost events may be dropped during transient channel lookup failures.
- Mitigation: This is intentional fail-closed behavior; existing cache retry behavior can recover after the lookup failure window.

AI-assisted: yes

clawsweeper · 2026-05-19T10:47:10Z

Codex review: needs real behavior proof before merge.

Workflow note: Future ClawSweeper reviews update this same comment in place.

How this review workflow works

ClawSweeper keeps one durable marker-backed review comment per issue or PR.
Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
Maintainers can also comment @clawsweeper review to request a fresh review only.
Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

Summary
The branch changes Mattermost auth, post, and interaction handling plus focused tests so missing channel type metadata denies or drops instead of flowing through the channel fallback.

Reproducibility: yes. by source inspection: current main maps missing Mattermost channel type values to channel, and post/interaction call sites pass channelInfo?.type into that fallback. I did not run tests or a live Mattermost repro because this review is read-only.

PR rating
Overall: 🦪 silver shellfish
Proof: 🦪 silver shellfish
Patch quality: 🐚 platinum hermit
Summary: The patch is focused and source-supported, but mock-only proof keeps the PR below merge-ready confidence.

Rank-up moves:

Add redacted live Mattermost proof, terminal output, or runtime logs showing unresolved channel type events are dropped after the patch.
Update the PR body with that proof so a fresh ClawSweeper review can run automatically; if it does not, ask a maintainer to comment @clawsweeper re-review.

What the crustacean ranks mean

🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

PR egg
🎁 Pass real behavior proof to wake the egg and unlock a hatchable treat.

Where did the egg go?

The egg game starts only after the PR passes the real-behavior proof check.
Before that, no creature, rarity, or ASCII portrait is rolled. The treat waits for real proof.
This is still just collectible flavor: proof affects review readiness, not creature quality.

Real behavior proof
Needs real behavior proof before merge: Needs real behavior proof before merge: the PR body reports only focused regression tests and says no live Mattermost environment was tested; redacted logs, terminal output, or a recording would count after private details are removed. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.

Risk before merge
Why this matters: - Mattermost channel lookup failures are cached as null, so transient lookup failures can now suppress posts or interactions until cache expiry.

The PR body provides focused test output only and explicitly says the live Mattermost interaction callback flow was not tested.
The protected maintainer label means this needs explicit maintainer handling even with no blocking code finding.

Maintainer options:

Require live drop-path proof (recommended)
Ask for redacted live Mattermost logs, terminal output, or callback-flow evidence showing unresolved channel type events are denied or dropped and later recovery behaves as expected.
Accept fail-closed delivery loss
Maintainers can intentionally accept that lookup-failed Mattermost posts and interactions will be suppressed instead of routed as channel traffic.
Pause for compatibility design
If preserving delivery during transient lookup failures matters more than fail-closed hardening, pause this PR and design a retry or strict-mode path first.

Next step before merge
Maintainer review is needed for the protected label, missing real behavior proof, and intentional fail-closed delivery tradeoff; there is no narrow automated repair to request.

Security
Cleared: No concrete supply-chain, credential, permission, or execution-path regression is visible; the diff is limited to Mattermost routing/auth logic and tests.

Review details

Best possible solution:

Land the Mattermost plugin-owned fail-closed fix only after maintainers accept the malformed-metadata delivery tradeoff and the contributor supplies redacted live Mattermost output or runtime logs for the drop path.

Do we have a high-confidence way to reproduce the issue?

Yes by source inspection: current main maps missing Mattermost channel type values to channel, and post/interaction call sites pass channelInfo?.type into that fallback. I did not run tests or a live Mattermost repro because this review is read-only.

Is this the best way to solve the issue?

Mostly yes: the fix stays inside the Mattermost plugin boundary and follows the existing reaction fail-closed precedent. The remaining question is maintainer acceptance of the delivery tradeoff, not a concrete code defect in this diff.

Label justifications:

P2: This is a focused Mattermost routing/auth hardening fix with limited channel-specific blast radius.
merge-risk: 🚨 compatibility: Existing lookup-failed Mattermost events that previously flowed through the channel fallback will be denied or dropped after merge.
merge-risk: 🚨 message-delivery: The changed post and interaction paths can suppress delivery when Mattermost channel type metadata cannot be resolved.

Acceptance criteria:

node scripts/run-vitest.mjs extensions/mattermost/src/mattermost/monitor-gating.test.ts extensions/mattermost/src/mattermost/monitor.channel-kind.test.ts extensions/mattermost/src/mattermost/monitor.authz.test.ts extensions/mattermost/src/mattermost/monitor.inbound-system-event.test.ts
Redacted live Mattermost post or interaction proof showing unresolved channel type denial/drop behavior

What I checked:

Current main fallback: Current main maps a falsy Mattermost channel type to channel, and tests still assert undefined maps to channel. (extensions/mattermost/src/mattermost/monitor-gating.ts:3, 5e0850fc548c)
Affected interaction routing: Current main resolves interaction session keys and button dispatch kind from channelInfo?.type, so a missing lookup result reaches the fallback mapper. (extensions/mattermost/src/mattermost/monitor.ts:669, 5e0850fc548c)
Affected post routing: Current main post handling calls resolveMattermostTrustedChatKind with channelInfo?.type and no fallback, so a missing lookup becomes regular channel traffic. (extensions/mattermost/src/mattermost/monitor.ts:1287, 5e0850fc548c)
Fail-closed precedent: The existing reaction path already drops when it cannot resolve channelInfo.type, supporting the PR's direction for analogous Mattermost inbound routing. (extensions/mattermost/src/mattermost/monitor.ts:1984, 5e0850fc548c)
Negative lookup cache risk: Channel lookup failures are cached as null for the Mattermost channel cache TTL, so fail-closed behavior can suppress events during transient lookup failure windows. (extensions/mattermost/src/mattermost/monitor-resources.ts:90, 5e0850fc548c)
PR diff shape: The PR adds missing-type guards in auth, interaction session routing, interaction dispatch, and post handling, and updates focused Mattermost tests. (extensions/mattermost/src/mattermost/monitor.ts:668, 2853ed7b2f17)

Likely related people:

steipete: GitHub path history shows repeated recent Mattermost monitor/auth refactors and current checkout blame points at recent Mattermost monitor lines through the shallow graft. (role: recent area contributor; confidence: medium; commits: a0fb7fb04547, 9e1b524a0019, 643dea2455ec; files: extensions/mattermost/src/mattermost/monitor.ts, extensions/mattermost/src/mattermost/monitor-auth.ts)
vincentkoc: Recent Mattermost and channel-routing history includes DM/thread behavior and plugin SDK boundary work touching the same plugin area. (role: recent adjacent contributor; confidence: medium; commits: d1cd74b2431d, 59fb5fd3a7a4, d3fc6c0cc79f; files: extensions/mattermost/src/mattermost/monitor.ts, extensions/mattermost/src/mattermost/monitor-gating.ts)
dave: Authored related missing-channel-type/threading commits referenced by the prior Mattermost unknown-channel work, giving useful context even though that branch is not merged on current main. (role: adjacent bug-fix proposer; confidence: medium; commits: 3779f1536027, 02de7789bcfb; files: extensions/mattermost/src/mattermost/monitor.ts)
mukhtharcm: Introduced the Mattermost interactive model picker path whose interaction routing is part of the affected surface. (role: feature introducer; confidence: medium; commits: 4f08dcccfd71; files: extensions/mattermost/src/mattermost/monitor.ts, extensions/mattermost/src/mattermost/model-picker.ts)

Codex review notes: model gpt-5.5, reasoning high; reviewed against 5e0850fc548c.

pgondhi987 · 2026-05-19T11:35:32Z

Not applicable to this automation stage; changelog/release-note and external real behavior proof requirements are handled outside auto-pr stages.

Quoted comment from @clawsweeper:

Codex review: needs real behavior proof before merge.

Workflow note: Future ClawSweeper reviews update this same comment in place.

How this review workflow works

ClawSweeper keeps one durable marker-backed review comment per issue or PR.

Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.

A fresh review can be triggered by eligible ``@clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.

PR/issue authors and users with repository write access can comment @clawsweeper` re-review` or @clawsweeper re-run on an open PR or issue to request a fresh review only.

Maintainers can also comment ``@clawsweeper review to request a fresh review only.

Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.

Maintainer-only repair and merge flows require explicit commands such as @clawsweeper` autofix`, @clawsweeper automerge, @clawsweeper` fix ci`, or @clawsweeper address review.

Maintainers can comment @clawsweeper` explain` to ask for more context, or @clawsweeper stop to stop active automation.

Summary
The branch changes Mattermost auth, post, and interaction handling plus focused tests so missing channel type metadata denies or drops instead of flowing through the channel fallback.

Reproducibility: yes. by source inspection: current main maps missing Mattermost channel type values to channel, and post/interaction call sites pass channelInfo?.type into that fallback. I did not run tests or a live Mattermost repro because this review is read-only.

PR rating
Overall: 🦪 silver shellfish
Proof: 🦪 silver shellfish
Patch quality: 🐚 platinum hermit
Summary: The patch is focused and source-supported, but mock-only proof keeps the PR below merge-ready confidence.

Rank-up moves:

Add redacted live Mattermost proof, terminal output, or runtime logs showing unresolved channel type events are dropped after the patch.

Update the PR body with that proof so a fresh ClawSweeper review can run automatically; if it does not, ask a maintainer to comment ``@clawsweeper re-review.

What the crustacean ranks mean

🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.

🦞 diamond lobster: very strong readiness with only minor maintainer review expected.

🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.

🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.

🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.

🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.

🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

PR egg
🎁 Pass real behavior proof to wake the egg and unlock a hatchable treat.

Where did the egg go?

The egg game starts only after the PR passes the real-behavior proof check.

Before that, no creature, rarity, or ASCII portrait is rolled. The treat waits for real proof.

This is still just collectible flavor: proof affects review readiness, not creature quality.

Real behavior proof
Needs real behavior proof before merge: Needs real behavior proof before merge: the PR body reports only focused regression tests and says no live Mattermost environment was tested; redacted logs, terminal output, or a recording would count after private details are removed. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment ``@clawsweeper re-review.

Risk before merge
Why this matters: - Mattermost channel lookup failures are cached as null, so transient lookup failures can now suppress posts or interactions until cache expiry.

The PR body provides focused test output only and explicitly says the live Mattermost interaction callback flow was not tested.

The protected maintainer label means this needs explicit maintainer handling even with no blocking code finding.

Maintainer options:

Require live drop-path proof (recommended)
Ask for redacted live Mattermost logs, terminal output, or callback-flow evidence showing unresolved channel type events are denied or dropped and later recovery behaves as expected.

Accept fail-closed delivery loss
Maintainers can intentionally accept that lookup-failed Mattermost posts and interactions will be suppressed instead of routed as channel traffic.

Pause for compatibility design
If preserving delivery during transient lookup failures matters more than fail-closed hardening, pause this PR and design a retry or strict-mode path first.

Next step before merge
Maintainer review is needed for the protected label, missing real behavior proof, and intentional fail-closed delivery tradeoff; there is no narrow automated repair to request.

Security
Cleared: No concrete supply-chain, credential, permission, or execution-path regression is visible; the diff is limited to Mattermost routing/auth logic and tests.

Review details

Best possible solution:

Land the Mattermost plugin-owned fail-closed fix only after maintainers accept the malformed-metadata delivery tradeoff and the contributor supplies redacted live Mattermost output or runtime logs for the drop path.

Do we have a high-confidence way to reproduce the issue?

Yes by source inspection: current main maps missing Mattermost channel type values to channel, and post/interaction call sites pass channelInfo?.type into that fallback. I did not run tests or a live Mattermost repro because this review is read-only.

Is this the best way to solve the issue?

Mostly yes: the fix stays inside the Mattermost plugin boundary and follows the existing reaction fail-closed precedent. The remaining question is maintainer acceptance of the delivery tradeoff, not a concrete code defect in this diff.

Label justifications:

P2: This is a focused Mattermost routing/auth hardening fix with limited channel-specific blast radius.

merge-risk: 🚨 compatibility: Existing lookup-failed Mattermost events that previously flowed through the channel fallback will be denied or dropped after merge.

merge-risk: 🚨 message-delivery: The changed post and interaction paths can suppress delivery when Mattermost channel type metadata cannot be resolved.

Acceptance criteria:

node scripts/run-vitest.mjs extensions/mattermost/src/mattermost/monitor-gating.test.ts extensions/mattermost/src/mattermost/monitor.channel-kind.test.ts extensions/mattermost/src/mattermost/monitor.authz.test.ts extensions/mattermost/src/mattermost/monitor.inbound-system-event.test.ts

Redacted live Mattermost post or interaction proof showing unresolved channel type denial/drop behavior

What I checked:

Current main fallback: Current main maps a falsy Mattermost channel type to channel, and tests still assert undefined maps to channel. (extensions/mattermost/src/mattermost/monitor-gating.ts:3, 5e0850fc548c)

Affected interaction routing: Current main resolves interaction session keys and button dispatch kind from channelInfo?.type, so a missing lookup result reaches the fallback mapper. (extensions/mattermost/src/mattermost/monitor.ts:669, 5e0850fc548c)

Affected post routing: Current main post handling calls resolveMattermostTrustedChatKind with channelInfo?.type and no fallback, so a missing lookup becomes regular channel traffic. (extensions/mattermost/src/mattermost/monitor.ts:1287, 5e0850fc548c)

Fail-closed precedent: The existing reaction path already drops when it cannot resolve channelInfo.type, supporting the PR's direction for analogous Mattermost inbound routing. (extensions/mattermost/src/mattermost/monitor.ts:1984, 5e0850fc548c)

Negative lookup cache risk: Channel lookup failures are cached as null for the Mattermost channel cache TTL, so fail-closed behavior can suppress events during transient lookup failure windows. (extensions/mattermost/src/mattermost/monitor-resources.ts:90, 5e0850fc548c)

PR diff shape: The PR adds missing-type guards in auth, interaction session routing, interaction dispatch, and post handling, and updates focused Mattermost tests. (extensions/mattermost/src/mattermost/monitor.ts:668, 2853ed7b2f17)

Likely related people:

steipete: GitHub path history shows repeated recent Mattermost monitor/auth refactors and current checkout blame points at recent Mattermost monitor lines through the shallow graft. (role: recent area contributor; confidence: medium; commits: a0fb7fb04547, 9e1b524a0019, 643dea2455ec; files: extensions/mattermost/src/mattermost/monitor.ts, extensions/mattermost/src/mattermost/monitor-auth.ts)

vincentkoc: Recent Mattermost and channel-routing history includes DM/thread behavior and plugin SDK boundary work touching the same plugin area. (role: recent adjacent contributor; confidence: medium; commits: d1cd74b2431d, 59fb5fd3a7a4, d3fc6c0cc79f; files: extensions/mattermost/src/mattermost/monitor.ts, extensions/mattermost/src/mattermost/monitor-gating.ts)

dave: Authored related missing-channel-type/threading commits referenced by the prior Mattermost unknown-channel work, giving useful context even though that branch is not merged on current main. (role: adjacent bug-fix proposer; confidence: medium; commits: 3779f1536027, 02de7789bcfb; files: extensions/mattermost/src/mattermost/monitor.ts)

mukhtharcm: Introduced the Mattermost interactive model picker path whose interaction routing is part of the affected surface. (role: feature introducer; confidence: medium; commits: 4f08dcccfd71; files: extensions/mattermost/src/mattermost/monitor.ts, extensions/mattermost/src/mattermost/model-picker.ts)

Codex review notes: model gpt-5.5, reasoning high; reviewed against 5e0850fc548c.

…026.5.20) (#615) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/openclaw/openclaw](https://openclaw.ai) ([source](https://github.com/openclaw/openclaw)) | patch | `2026.5.19` → `2026.5.20` | --- > ⚠️ **Warning** > > Some dependencies could not be looked up. Check the [Dependency Dashboard](issues/567) for more information. --- ### Release Notes <details> <summary>openclaw/openclaw (ghcr.io/openclaw/openclaw)</summary> ### [`v2026.5.20`](https://github.com/openclaw/openclaw/blob/HEAD/CHANGELOG.md#2026520) [Compare Source](openclaw/openclaw@v2026.5.19...v2026.5.20) ##### Changes - Exec approvals: remove the old `cat SKILL.md && printf ... && <skill-wrapper>` allowlist compatibility path so skill files must be loaded with the read tool and only the real skill executable is auto-allowed. - Discord: let voice sessions follow configured Discord users into voice channels, with allowed-channel checks, multi-user handoff, bounded reconciliation, and DAVE recovery preservation. ([#84264](openclaw/openclaw#84264)) Thanks [@fuller-stack-dev](https://github.com/fuller-stack-dev). - Discord/voice: include bounded `IDENTITY.md`, `USER.md`, and `SOUL.md` profile context in realtime voice session instructions by default, with `voice.realtime.bootstrapContextFiles: []` available to disable it. ([#84499](openclaw/openclaw#84499)) Thanks [@fuller-stack-dev](https://github.com/fuller-stack-dev). - Dependencies: bump the bundled Codex harness to `@openai/codex` `0.132.0` and refresh the app-server model-list docs for the new catalog. - CLI/policy: add the bundled Policy plugin for policy-backed channel conformance checks, doctor lint findings, and opt-in workspace repair. ([#80407](openclaw/openclaw#80407)) Thanks [@giodl73-repo](https://github.com/giodl73-repo). - Agents/config: allow `agents.list[].experimental.localModelLean` so lean local-model mode can be enabled for one configured agent instead of globally. - Providers/xAI: add device-code OAuth login so remote and headless setups can authorize xAI without a localhost browser callback. ([#84005](openclaw/openclaw#84005)) Thanks [@fuller-stack-dev](https://github.com/fuller-stack-dev). - Providers/OpenRouter: honor provider-level `params.provider` routing policy for OpenRouter requests, with model and agent params overriding the defaults. Thanks [@amknight](https://github.com/amknight). ##### Fixes - CLI/tasks: include stale-running task maintenance decisions in `openclaw tasks maintenance --json` so retained and reconcile candidates explain backing-session, cron, CLI, and wedged-subagent state. ([#84691](openclaw/openclaw#84691)) Thanks [@efpiva](https://github.com/efpiva). - Codex app-server: keep system-prompt reports working when bootstrap hooks provide workspace files with only a path and content, so hook-supplied SOUL/IDENTITY/TOOLS/USER context still reports injected characters correctly. ([#84736](openclaw/openclaw#84736)) Thanks [@JARVIS-Glasses](https://github.com/JARVIS-Glasses). - Providers/MiniMax music: stop advertising `durationSeconds` control and remove prompt-injected duration hints, so `music_generate` reports MiniMax duration as an unsupported override instead of suggesting MiniMax can enforce track length. Fixes [#84508](openclaw/openclaw#84508). Thanks [@neeravmakwana](https://github.com/neeravmakwana). - Doctor: warn when sandbox tool policy hides configured MCP server tools before provider requests. ([#84699](openclaw/openclaw#84699)) Thanks [@nxmxbbd](https://github.com/nxmxbbd). - WhatsApp: update Baileys to `7.0.0-rc12`. - Build: suppress per-locale `rolldown-plugin-dts:fake-js` CommonJS dts warnings emitted while bundling the intentionally-inlined `zod/v4/locales/*.d.cts` files, so `pnpm build` output stays readable after the 0.25.1 plugin bump. Thanks [@romneyda](https://github.com/romneyda). - CLI/nodes: route lazy plugin-registration logs to stderr for JSON-mode `openclaw nodes` commands so stdout stays parseable. ([#84684](openclaw/openclaw#84684)) Thanks [@TurboTheTurtle](https://github.com/TurboTheTurtle). - Approvals: route manual `/approve` decisions through the trusted approval runtime so active exec and plugin approvals no longer look unknown or expired. - Mac app: update the About settings copyright year to 2026. ([#84385](openclaw/openclaw#84385)) Thanks [@pejmanjohn](https://github.com/pejmanjohn). - Dependencies: update `@openclaw/fs-safe` to `0.2.7` so OpenClaw's default Python-helper-off policy keeps best-effort Node write fallbacks for private stores, secret writes, run logs, and media attachments on Linux/macOS. - Infra/secrets: restore the fail-closed contract for `tryReadSecretFileSync` so credential loaders that pass `rejectSymlink: true` (Telegram, LINE, Zalo, IRC, Nextcloud Talk tokens) refuse symlinked credential files instead of silently accepting them, and the infra-state CI shard's secret-file symlink test passes again. Thanks [@romneyda](https://github.com/romneyda). - Browser: honor the configured image sanitization limit for screenshots and labeled snapshots so browser-captured images follow the same resize policy as other image results. ([#84595](openclaw/openclaw#84595)) - Doctor: remove unrecognized `models.providers.*.models[*].compat.thinkingFormat` values during `doctor --fix` so stale provider model config can validate after upgrade. Fixes [#77803](openclaw/openclaw#77803). - Doctor: warn when `openclaw.json` stores plaintext secret-bearing config fields, including model provider API keys and sensitive provider headers. ([#84718](openclaw/openclaw#84718)) Thanks [@lukaIvanic](https://github.com/lukaIvanic). - Status: show the configured default, session-selected model, reason, clear hint, and docs link when a session remains pinned to a model that differs from `agents.defaults.model.primary`. - WebChat: clear stale typing indicators when session change events mark the active chat run complete. - Mac app: keep local packaging signed with a stable app identity for permission testing and fix Control UI production builds under current Vite/Highlight.js exports. - macOS app: update the embedded Peekaboo bridge to 3.2.1 so OpenClaw-hosted UI automation works with current Peekaboo CLI capture flows. - Cron: deliver preferred final assistant output for successful scheduled runs when trailing plain tool warnings remain in diagnostics instead of marking the run failed. - fix(mattermost): fail closed on missing channel type \[AI]. ([#84091](openclaw/openclaw#84091)) Thanks [@pgondhi987](https://github.com/pgondhi987). - Recheck rebuilt system.run argv \[AI]. ([#84090](openclaw/openclaw#84090)) Thanks [@pgondhi987](https://github.com/pgondhi987). - CLI: keep the private QA subcommand out of exported command descriptors unless `OPENCLAW_ENABLE_PRIVATE_QA_CLI=1`, so root help and subcommand markers match runtime registration. ([#84519](openclaw/openclaw#84519)) - CLI/cron: bound `openclaw cron show` job lookup pagination so non-advancing or unbounded `cron.list` responses fail instead of hanging the command. Fixes [#83856](openclaw/openclaw#83856). ([#83989](openclaw/openclaw#83989)) - Agents/messages: stop message-tool-only turns after a successful source-channel `message` send while keeping transcript mirrors under the session write lock. ([#84289](openclaw/openclaw#84289)) - Agents: filter silent heartbeat response-tool transcript artifacts out of embedded context snapshots so later user turns are not polluted by heartbeat no-op messages. ([#83477](openclaw/openclaw#83477)) Thanks [@fuller-stack-dev](https://github.com/fuller-stack-dev). - Agents/OpenAI: log repeated strict tool-schema downgrade diagnostics once per provider/model/tool signature, reducing duplicate debug noise while preserving `strict=false` fallback behavior. Fixes [#82930](openclaw/openclaw#82930). ([#82933](openclaw/openclaw#82933)) Thanks [@galiniliev](https://github.com/galiniliev). - Agents/code mode: spell out the `exec` tool's JavaScript/TypeScript, no Node module, and catalog-bridge constraints in model-visible schema text so agents can use enabled tools without trial-and-error. ([#84269](openclaw/openclaw#84269)) Thanks [@Kaspre](https://github.com/Kaspre). - Codex: give `image_generate` dynamic-tool calls a 120s default watchdog when no per-call or configured image timeout is set, so image generation no longer falls back to the generic 30s bridge timeout. ([#84254](openclaw/openclaw#84254)) Thanks [@moritzmmayerhofer](https://github.com/moritzmmayerhofer). - Codex: avoid duplicate dynamic tool terminal diagnostics while large diagnostic backlogs drain without blocking tool responses. ([#82937](openclaw/openclaw#82937)) Thanks [@galiniliev](https://github.com/galiniliev). - CLI/message: include a stable top-level `messageId` in `openclaw message --json` output when channel sends return one. ([#84191](openclaw/openclaw#84191)) Thanks [@100menotu001](https://github.com/100menotu001). - Cron: preserve legacy top-level array `jobs.json` stores when loading or adding scheduled jobs so old cron jobs are no longer treated as an empty store during upgrade. Fixes [#60799](openclaw/openclaw#60799). ([#84433](openclaw/openclaw#84433)) Thanks [@IWhatsskill](https://github.com/IWhatsskill). - Gateway/agents: use an agent's `identity.name` in Gateway agent summaries when `agents.list[].name` is unset, so configured agent labels remain visible in clients. ([#84355](openclaw/openclaw#84355); refs [#57835](openclaw/openclaw#57835)) Thanks [@luoyanglang](https://github.com/luoyanglang). - Channels/replies: keep normal `/verbose` failed-tool progress compact in message-tool replies and prevent late text-only tool output from appearing after the final answer. ([#84303](openclaw/openclaw#84303)) Thanks [@VACInc](https://github.com/VACInc). - Plugins/hooks: apply a default 30-second timeout to `before_compaction` and `after_compaction` hooks so a hung plugin handler no longer blocks compaction completion. ([#84153](openclaw/openclaw#84153)) - Discord: preserve disabled presentation buttons when adapting and rendering Discord message controls. ([#84188](openclaw/openclaw#84188)) Thanks [@100menotu001](https://github.com/100menotu001). - Twitch: add a test-only client-manager registry reset helper so non-isolated Twitch tests can clear cached managers between cases. Fixes [#83887](openclaw/openclaw#83887). ([#84244](openclaw/openclaw#84244)) Thanks [@hclsys](https://github.com/hclsys). - Cron: run main-session scheduled work on a cron-owned wake lane while preserving reply delivery context, so background cron turns no longer block human main-session chat. Fixes [#82766](openclaw/openclaw#82766). ([#82767](openclaw/openclaw#82767)) Thanks [@galiniliev](https://github.com/galiniliev). - Cron: use structured embedded-run denial metadata for isolated scheduled tasks so blocked exec requests fail the job without treating ordinary assistant prose as a denial. ([#84067](openclaw/openclaw#84067)) Thanks [@abnershang](https://github.com/abnershang). - Cron: keep recovered tool warnings diagnostic for successful scheduled runs so final cron output is delivered instead of being replaced by a post-processing warning. ([#84045](openclaw/openclaw#84045)) Thanks [@abnershang](https://github.com/abnershang). - Plugins/perf: thread explicit plugin discovery results through `loadBundledCapabilityRuntimeRegistry`, `resolveBundledPluginSources`, and `listChannelCatalogEntries` so callers that already hold a discovery result skip redundant filesystem walks. Thanks [@SebTardif](https://github.com/SebTardif). - harden update restart script creation \[AI]. ([#84088](openclaw/openclaw#84088)) Thanks [@pgondhi987](https://github.com/pgondhi987). - Docker: keep the bundled Codex plugin in official release image keep lists so the default OpenAI agent harness remains available after Docker pruning. Fixes [#83613](openclaw/openclaw#83613). ([#83626](openclaw/openclaw#83626)) Thanks [@YuanHanzhong](https://github.com/YuanHanzhong). - CLI/channels: preserve the first line of `openclaw channels logs` output when the rolling tail window starts exactly on a line boundary, mirroring the already-fixed `readLogSlice` behavior in `src/logging/log-tail.ts`. - Control UI: treat terminal session status as authoritative over stale active-run flags so completed terminal runs stop showing abort/live UI. ([#84057](openclaw/openclaw#84057)) - CLI: preserve embedded equals signs in inline root option values instead of truncating after the second separator. ([#83995](openclaw/openclaw#83995)) Thanks [@ThiagoCAltoe](https://github.com/ThiagoCAltoe). - Matrix/config: accept `messages.queue.byChannel.matrix` queue overrides and keep queue provider schema/type keys aligned for Matrix, Google Chat, and Mattermost. Thanks [@bdjben](https://github.com/bdjben). - CLI: format `openclaw acp client` failures through the shared error formatter so object-shaped errors stay readable instead of printing `[object Object]`. Fixes [#83904](openclaw/openclaw#83904). ([#84080](openclaw/openclaw#84080)) - Providers/Ollama: default unknown-capabilities models to tool-capable so discovered native Ollama models can use tools when `/api/show` omits capabilities. ([#84055](openclaw/openclaw#84055)) Thanks [@dutifulbob](https://github.com/dutifulbob). - Installer/Windows: launch `install.ps1` onboarding as an attached child process so fresh native Windows installs do not freeze visibly at `Starting setup...` or corrupt the wizard's terminal rendering. - CLI/update: keep restart health checks working across one-version CLI/Gateway protocol skew and use the managed Gateway service Node for all follow-up commands even when the package root is unchanged, so `openclaw update` no longer silently switches the gateway to a different Node binary when multiple Node installations are present. Thanks [@amknight](https://github.com/amknight). - CLI/gateway: include the running Gateway version in `gateway status` JSON output, preserving existing server metadata while falling back to status RPC data for read probes. Fixes [#56222](openclaw/openclaw#56222). Thanks [@galiniliev](https://github.com/galiniliev). - Memory/search: close local embedding providers when active-memory searches time out so pending local model loads and embedding contexts are aborted and released. ([#83858](openclaw/openclaw#83858)) Thanks [@brokemac79](https://github.com/brokemac79). - CLI/nodes: request pending node surface approval scopes before `openclaw nodes approve` so exec-capable node approval can use admin-scoped Gateway credentials instead of failing with `missing scope: operator.admin`. ([#84392](openclaw/openclaw#84392)) Thanks [@joshavant](https://github.com/joshavant). - Gateway: reject slow node event sends before outbound buffers grow unbounded and log the rejected payload diagnostic. ([#84387](openclaw/openclaw#84387)) Thanks [@samzong](https://github.com/samzong). - Agents: include bounded trajectory queued-writer diagnostics in `pi-trajectory-flush` timeout warnings so flush stalls show pending writes, queued bytes, and append state. Fixes [#82961](openclaw/openclaw#82961). ([#82962](openclaw/openclaw#82962)) Thanks [@galiniliev](https://github.com/galiniliev). - Agents/subagents: recover stale completion announces by retrying unsupported transcript-wait wakes without transcript waiting and forcing a message-tool handoff when the requester run is already stale. Fixes [#83699](openclaw/openclaw#83699). ([#83700](openclaw/openclaw#83700)) Thanks [@galiniliev](https://github.com/galiniliev). - Agents/subagents: constrain wildcard subagent target allowlists to configured agents while preserving explicitly listed compatibility targets. Fixes [#84040](openclaw/openclaw#84040). ([#84357](openclaw/openclaw#84357)) Thanks [@joshavant](https://github.com/joshavant). - Providers/Anthropic: route Anthropic model refs selected with Claude CLI auth through the Claude CLI runtime so shorthand refs such as `anthropic/opus-4.7` no longer fall back to embedded Anthropic billing. Fixes [#84222](openclaw/openclaw#84222). ([#84374](openclaw/openclaw#84374)) Thanks [@joshavant](https://github.com/joshavant). - Agents: honor explicit `models.providers.<id>.timeoutSeconds` values above the default idle watchdog for cloud and self-hosted providers, so long first-token waits no longer fall back at \~120s when the provider timeout is higher. ([#83979](openclaw/openclaw#83979)) Thanks [@yujiawei](https://github.com/yujiawei). - Agents/Codex: keep encrypted Responses reasoning replay provenance-bound so stale mirrored Codex transcripts drop invalid encrypted content before request assembly while preserving matching same-session replay. Fixes [#83836](openclaw/openclaw#83836). ([#84367](openclaw/openclaw#84367)) Thanks [@joshavant](https://github.com/joshavant). - Agents/subagents: skip stale embedded-run wake probes for dormant completion requesters, so late subagent completions go straight to requester-agent/direct handoff instead of producing `reason=no_active_run` queue noise. ([#82964](openclaw/openclaw#82964)) Thanks [@galiniliev](https://github.com/galiniliev). - CLI: retry config snapshot reads after a transient failure so one rejected read no longer poisons later commands in the same process. ([#83931](openclaw/openclaw#83931)) Thanks [@honor2030](https://github.com/honor2030). - Media: decode URL path basenames before using them as remote media fallback filenames, so files like `My%20Report.pdf` are surfaced as `My Report.pdf`. Fixes [#84050](openclaw/openclaw#84050). ([#84052](openclaw/openclaw#84052)) Thanks [@jbetala7](https://github.com/jbetala7). - WhatsApp: clarify inbound group diagnostics so observed but unregistered groups point to `channels.whatsapp.groups` without changing routing or sender authorization. ([#83846](openclaw/openclaw#83846)) Thanks [@neeravmakwana](https://github.com/neeravmakwana). - WhatsApp: drain pending outbound deliveries on a 30s periodic timer in addition to the reconnect handler, so messages enqueued while the provider is already connected no longer wait for the next reconnect to send. ([#79083](openclaw/openclaw#79083)) Thanks [@Oviemudiaga](https://github.com/Oviemudiaga). - CLI/TUI: include gateway plugin slash commands in TUI autocomplete, so connected sessions can suggest plugin-owned commands exposed by the running Gateway. ([#83640](openclaw/openclaw#83640)) Thanks [@se7en-agent](https://github.com/se7en-agent). - Gateway/mobile: restore QR setup-code handoff of bounded operator tokens for iOS and Android onboarding while keeping admin and pairing scopes out of bootstrap. ([#83684](openclaw/openclaw#83684)) Thanks [@ngutman](https://github.com/ngutman). - iOS: repair Release archive compilation for the TestFlight build. ([#84255](openclaw/openclaw#84255)) Thanks [@ngutman](https://github.com/ngutman). - Agents/compaction: bound plugin-owned CLI transcript compaction with the host safety timeout so a hung context engine can no longer stall post-turn cleanup. ([#84083](openclaw/openclaw#84083)) Thanks [@100yenadmin](https://github.com/100yenadmin). - Control UI/usage: truncate long context skill, tool, and file names in the usage panel while keeping the full name available on hover. ([#42197](openclaw/openclaw#42197)) Thanks [@Rain120](https://github.com/Rain120). - Codex: respect explicit `models auth order set` and `config.auth.order` precedence over stale `lastGood` in `/codex account`, and show `no working credential` when every explicit-order profile is ineligible instead of marking a lower-ranked profile as active. Fixes [#84386](openclaw/openclaw#84386). ([#84412](openclaw/openclaw#84412)) Thanks [@openperf](https://github.com/openperf). - Agents: honor `messages.suppressToolErrors` for mutating tool failures so configured chat surfaces do not receive separate warning payloads. ([#81561](openclaw/openclaw#81561)) Thanks [@moeedahmed](https://github.com/moeedahmed). - Agents/fallback: surface billing guidance for mixed rate-limit plus billing fallback exhaustion instead of generic failure copy. Fixes [#79396](openclaw/openclaw#79396). ([#79489](openclaw/openclaw#79489)) Thanks [@aayushprsingh](https://github.com/aayushprsingh). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/615

…4091) * fix: fail closed on missing Mattermost channel type * addressing codex review * docs: add changelog entry for PR merge

fix: fail closed on missing Mattermost channel type

e7bc597

openclaw-barnacle Bot added channel: mattermost Channel integration: mattermost size: S maintainer Maintainer-authored PR labels May 19, 2026

addressing codex review

2853ed7

openclaw-barnacle Bot added size: M and removed size: S labels May 19, 2026

pgondhi987 added 2 commits May 20, 2026 07:03

Merge remote-tracking branch 'origin/main' into fix/fix-571

69f11c8

docs: add changelog entry for PR merge

d100c37

pgondhi987 merged commit 0c67dc7 into openclaw:main May 20, 2026
17 checks passed

github-actions Bot mentioned this pull request May 20, 2026

📡 Upstream Digest — 2026-05-20 07:36 UTC curtismercier/openclaw-mods#902

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(mattermost): fail closed on missing channel type [AI]#84091

fix(mattermost): fail closed on missing channel type [AI]#84091
pgondhi987 merged 4 commits into
openclaw:mainfrom
pgondhi987:fix/fix-571

pgondhi987 commented May 19, 2026

Uh oh!

clawsweeper Bot commented May 19, 2026 •

edited

Loading

Uh oh!

pgondhi987 commented May 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

pgondhi987 commented May 19, 2026

Summary

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

Motivation

Real behavior proof (required for external PRs)

Root Cause (if applicable)

Regression Test Plan (if applicable)

User-visible / Behavior Changes

Diagram (if applicable)

Security Impact (required)

Repro + Verification

Environment

Steps

Expected

Actual

Evidence

Human Verification (required)

Review Conversations

Compatibility / Migration

Risks and Mitigations

Uh oh!

clawsweeper Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pgondhi987 commented May 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

clawsweeper Bot commented May 19, 2026 •

edited

Loading