addressing codex review

pgondhi987 · pgondhi987 · commit 2853ed7b2f17 · 2026-05-19T10:55:27.000Z
diff --git a/extensions/mattermost/src/mattermost/monitor.inbound-system-event.test.ts b/extensions/mattermost/src/mattermost/monitor.inbound-system-event.test.ts
@@ -432,7 +432,59 @@ describe("mattermost inbound user posts", () => {
     expect(ctx?.Provider).toBe("mattermost");
   });
 
-  it("drops posts when channel type cannot be resolved", async () => {
+  it("uses websocket channel type when REST channel lookup fails", async () => {
+    const socket = new FakeWebSocket();
+    const abortController = new AbortController();
+    mockState.abortController = abortController;
+    const runtimeCore = createRuntimeCore(testConfig);
+    mockState.runtimeCore = runtimeCore;
+    mockState.resolveChannelInfo.mockResolvedValue(null);
+
+    const monitor = monitorMattermostProvider({
+      config: testConfig,
+      runtime: testRuntime(),
+      abortSignal: abortController.signal,
+      webSocketFactory: () => socket,
+    });
+
+    await vi.waitFor(() => {
+      expect(socket.openListenerCount).toBeGreaterThan(0);
+    });
+    socket.emitOpen();
+
+    await socket.emitMessage({
+      event: "posted",
+      data: {
+        channel_id: "chan-1",
+        channel_name: "town-square",
+        channel_display_name: "Town Square",
+        channel_type: "O",
+        sender_name: "alice",
+        post: JSON.stringify({
+          id: "post-ws-kind",
+          channel_id: "chan-1",
+          user_id: "user-1",
+          message: "hello with websocket kind",
+          create_at: 1_714_000_000_000,
+        }),
+      },
+      broadcast: {
+        channel_id: "chan-1",
+        user_id: "user-1",
+      },
+    });
+    socket.emitClose(1000);
+    await monitor;
+
+    expect(mockState.dispatchReplyFromConfig).toHaveBeenCalledTimes(1);
+    const ctx = mockState.dispatchReplyFromConfig.mock.calls.at(0)?.[0].ctx;
+    expect(ctx?.BodyForAgent).toBe("hello with websocket kind");
+    expect(ctx?.ChatType).toBe("channel");
+    expect(ctx?.ConversationLabel).toBe("Town Square id:chan-1");
+    expect(runtimeCore.channel.session.recordInboundSession).toHaveBeenCalledTimes(1);
+  });
+
+  it("drops posts when neither REST nor websocket channel type can be resolved", async () => {
     const socket = new FakeWebSocket();
     const abortController = new AbortController();
     mockState.abortController = abortController;
diff --git a/extensions/mattermost/src/mattermost/monitor.ts b/extensions/mattermost/src/mattermost/monitor.ts
@@ -1297,12 +1297,15 @@ export async function monitorMattermostProvider(opts: MonitorMattermostOpts = {}
         }
 
         const channelInfo = await resolveChannelInfo(channelId);
-        if (!channelInfo?.type) {
+        const channelType =
+          normalizeOptionalString(channelInfo?.type) ??
+          normalizeOptionalString(payload.data?.channel_type);
+        if (!channelType) {
           logVerboseMessage(`mattermost: drop post (cannot resolve channel type for ${channelId})`);
           return;
         }
         const kind = resolveMattermostTrustedChatKind({
-          channelType: channelInfo.type,
+          channelType,
         });
         const chatType = channelChatType(kind);
 
