[AI-assisted] fix(cron): preserve legacy array stores by IWhatsskill · Pull Request #84433 · openclaw/openclaw

IWhatsskill · 2026-05-20T04:18:55Z

Summary

Problem: legacy cron jobs.json files stored as a top-level array are loaded as empty after upgrade, so the first cron add can rewrite the file with only the new job.
Solution: normalize both supported persisted shapes in one cron store loader path: { version, jobs } and legacy [...].
What changed: async load, sync load, doctor repair, service add, and gateway cron.add now preserve legacy array jobs through load/add/save.
What did NOT change: no cron timeout defaults, auth cooldowns, delivery behavior, storage schema migration, or broad concurrency changes.

Motivation

This is a P0 data-loss guard for users upgrading from a legacy plain-array cron store. A valid existing cron file should never be interpreted as empty and clobbered by the next write.

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

Closes cron: v2026.4.2 silently drops jobs.json (plain-array format) and first add clobbers all data #60799
This PR fixes a bug or regression

Real behavior proof (required for external PRs)

Behavior or issue addressed: legacy top-level array cron stores are preserved when a new cron job is added.
Real environment tested: isolated Linux testserver checkout on current origin/main plus this patch; no real secrets or user cron store used.
Exact steps or command run after this patch: seeded a temp cron jobs.json with two legacy array jobs, called the real cron store load path and cron service add(), then read the persisted file.
Evidence after fix:

{
  "commit": "a54c73687f+6e2ab35417",
  "phase": "after",
  "legacyInputIds": ["legacy-alpha", "legacy-beta"],
  "loadCronStoreJobCount": 2,
  "loadedIds": ["legacy-alpha", "legacy-beta"],
  "persistedShape": "versioned-object",
  "persistedJobCount": 3,
  "persistedIds": ["legacy-alpha", "legacy-beta", "f4c00803-9730-4de8-8f09-674604ac6d7f"],
  "legacyPreservedAfterAdd": true
}

Observed result after fix: both legacy jobs load, the new job is added, and all three jobs persist in the versioned store.
What was not tested: a real user home cron store and live scheduled job execution were not used; this intentionally used isolated temp state.
Before evidence:

{
  "commit": "a54c73687f",
  "phase": "before",
  "legacyInputIds": ["legacy-alpha", "legacy-beta"],
  "loadCronStoreJobCount": 0,
  "loadedIds": [],
  "persistedShape": "versioned-object",
  "persistedJobCount": 1,
  "legacyPreservedAfterAdd": false
}

Root Cause (if applicable)

Root cause: loadCronStore() and loadCronStoreSync() only read parsed.jobs from an object envelope. If jobs.json was the older top-level array shape, the loader fell back to an empty job list.
Missing detection / guardrail: there was no regression coverage for loading a top-level array through async/sync store reads or through the add/save paths.
Contributing context: doctor repair uses the store loader, so the same normalization gap could make a repair pass treat valid legacy jobs as absent.

Regression Test Plan (if applicable)

Coverage level that should have caught this:
- Unit test
- Seam / integration test
- End-to-end test
- Existing coverage already sufficient
Target test or file:
- src/cron/store.test.ts
- src/cron/service/ops.test.ts
- src/commands/doctor-cron.test.ts
- src/gateway/server.cron.test.ts
Scenario the test should lock in: legacy top-level array jobs load through async/sync store reads and survive service/gateway cron.add plus doctor repair.
Why this is the smallest reliable guardrail: the bug is in cron store normalization, with service/gateway tests proving the user-facing add path does not clobber data.
Existing test that already covers this (if any): none for top-level array stores.
If no new test is added, why not: N/A.

User-visible / Behavior Changes

OpenClaw now preserves cron jobs from legacy top-level array jobs.json files instead of treating them as empty on load.

Diagram (if applicable)

Before:
legacy jobs.json array -> load as [] -> cron add -> persisted file contains only new job

After:
legacy jobs.json array -> load legacy jobs -> cron add -> persisted file contains legacy jobs plus new job

Security Impact (required)

New permissions/capabilities? No
Secrets/tokens handling changed? No
New/changed network calls? No
Command/tool execution surface changed? No
Data access scope changed? No
If any Yes, explain risk + mitigation: N/A

Repro + Verification

Environment

OS: Linux testserver
Runtime/container: Node.js v22.22.2, pnpm v11.1.2, isolated temp checkout/state
Model/provider: N/A
Integration/channel (if any): N/A
Relevant config (redacted): temp cron store path only

Steps

Write a temp cron/jobs.json as a top-level array with two valid legacy jobs.
Load the store and call the real cron service add() path.
Read cron/jobs.json after save.

Expected

Both legacy job IDs and the new job ID are present after add/save.

Actual

Before patch: only the new job was present.
After patch: both legacy jobs plus the new job were present.

Evidence

Failing test/log before + passing after
Trace/log snippets
Screenshot/recording
Perf numbers (if relevant)

Human Verification (required)

Verified scenarios:
- Before/after runtime proof on current origin/main and this patch.
- Focused vitest: src/cron/store.test.ts, src/cron/service/ops.test.ts, src/commands/doctor-cron.test.ts, src/gateway/server.cron.test.ts = 4 files / 71 tests passed.
- Core typecheck passed.
- Core test typecheck passed.
- oxfmt --check passed for all touched files.
- Targeted run-oxlint passed for all touched files with 0 warnings / 0 errors.
- git diff --check passed.
Edge cases checked:
- non-object array rows are ignored
- sync and async store load both accept the legacy array
- runtime state still splits into the state sidecar after save
- doctor repair normalizes a legacy array instead of treating it as empty
- gateway cron.add preserves legacy jobs through the RPC handler path
What you did not verify:
- full pnpm check:changed completion; the testserver OOM-killed tsgolint during full core lint, so the touched-file lint/typecheck/test lanes were run directly and passed.

Review Conversations

I replied to or resolved every bot review conversation I addressed in this PR.
I left unresolved only the conversations that still need reviewer or maintainer judgment.

Compatibility / Migration

Backward compatible? Yes
Config/env changes? No
Migration needed? No
If yes, exact upgrade steps: N/A

Risks and Mitigations

Risk: accepting the legacy array shape could preserve malformed scalar rows.
- Mitigation: the normalizer keeps the existing object-row filter, so non-object rows are ignored before hydration.
Risk: async/sync/doctor paths could diverge again later.
- Mitigation: both loaders now share the same normalizer and have focused regression coverage.

clawsweeper · 2026-05-20T04:20:26Z

Codex review: passed.

Workflow note: Future ClawSweeper reviews update this same comment in place.

How this review workflow works

ClawSweeper keeps one durable marker-backed review comment per issue or PR.
Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
Maintainers can also comment @clawsweeper review to request a fresh review only.
Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

Summary
The PR changes cron store loading to normalize legacy top-level array jobs.json files into the versioned store shape and adds store, service, doctor, gateway tests plus a changelog entry.

Reproducibility: yes. Current main clearly maps a top-level parsed array to {} before reading .jobs, and the PR body supplies before/after runtime output for the load/add/save path.

PR rating
Overall: 🐚 platinum hermit
Proof: 🐚 platinum hermit
Patch quality: 🐚 platinum hermit
Summary: Focused data-loss fix with sufficient real-behavior proof, relevant regression tests, and no blocking findings from this review.

Rank-up moves:

Let the exact-head CI/automerge gate complete before merge.

What the crustacean ranks mean

🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Real behavior proof
Sufficient (live_output): The PR body includes copied before/after runtime output from an isolated Linux setup showing legacy array jobs preserved after a real store load and cron service add/save path.

Risk before merge

This read-only review did not execute the focused tests locally; final merge should still honor exact-head required checks/automerge gating.

Maintainer options:

Decide the mitigation before merge
Land the shared cron store normalizer with the focused regression coverage, while leaving broader cron write-merge and diagnostics follow-ups to separately scoped work if maintainers want them.
Pause or close
Do not merge this PR until maintainers decide whether the risk is worth taking.

Next step before merge
No repair lane is needed; the remaining action is normal exact-head CI/automerge gating or maintainer landing.

Security
Cleared: The diff only changes cron store normalization, tests, and changelog text; it adds no dependency, CI, permission, secret, command execution, or network surface.

Review details

Best possible solution:

Land the shared cron store normalizer with the focused regression coverage, while leaving broader cron write-merge and diagnostics follow-ups to separately scoped work if maintainers want them.

Do we have a high-confidence way to reproduce the issue?

Yes. Current main clearly maps a top-level parsed array to {} before reading .jobs, and the PR body supplies before/after runtime output for the load/add/save path.

Is this the best way to solve the issue?

Yes. A shared cron store-file normalizer is the narrow maintainable fix because it keeps async load, sync load, doctor, service, and gateway paths on one persisted-shape contract.

Label justifications:

P0: The PR fixes an upgrade path where valid persisted cron jobs can be silently loaded as empty and overwritten on the first write.
rating: 🐚 platinum hermit: Current PR rating is 🐚 platinum hermit because proof is 🐚 platinum hermit, patch quality is 🐚 platinum hermit, and Focused data-loss fix with sufficient real-behavior proof, relevant regression tests, and no blocking findings from this review.
status: 🚀 automerge armed: This PR is in ClawSweeper's automerge lane. Sufficient (live_output): The PR body includes copied before/after runtime output from an isolated Linux setup showing legacy array jobs preserved after a real store load and cron service add/save path.
proof: sufficient: Contributor real behavior proof is sufficient. The PR body includes copied before/after runtime output from an isolated Linux setup showing legacy array jobs preserved after a real store load and cron service add/save path.

What I checked:

Current-main bug path: Current main parses the cron store, rejects top-level arrays by replacing them with {}, and then reads only parsedRecord.jobs, so a valid legacy array loads as zero jobs before add/save. (src/cron/store.ts:218, 5c39e0019d2f)
Add path can clobber after empty load: cron.add calls ensureLoaded(state), appends the new job to the in-memory store, and persists that store, so an empty load from a legacy array can rewrite the file with only the new job. (src/cron/service/ops.ts:365, 5c39e0019d2f)
Patch normalizes both persisted shapes: The PR adds a shared normalizer that uses the parsed value directly when it is an array, otherwise uses parsed.jobs, and routes both async and sync loaders through it. (src/cron/store.ts:54, 446014b4c1f2)
Regression coverage added: The patch adds coverage for async/sync legacy array loads, load-add-save preservation, service add, doctor repair, and gateway cron.add preserving legacy jobs. (src/cron/store.test.ts:136, 446014b4c1f2)
Contributor real-behavior proof: The PR body includes before/after copied runtime output from an isolated Linux checkout showing loadCronStoreJobCount changing from 0 to 2 and legacyPreservedAfterAdd changing from false to true after the patch. (446014b4c1f2)
History provenance: Blame ties the current loader behavior that ignores top-level arrays to the current imported/reverted store implementation, and broader cron history shows active recent maintenance around the same persistence and gateway surfaces. (src/cron/store.ts:207, 3d96111a5afe)

Likely related people:

steipete: Peter Steinberger introduced the original cron scheduler/store surface and is the dominant recent contributor across cron, doctor, and gateway cron history sampled for this review. (role: feature owner and heavy area contributor; confidence: high; commits: f9409cbe43d2, 50a2481652b6; files: src/cron/store.ts, src/commands/doctor-cron.ts, src/gateway/server.cron.test.ts)
Dallin Romney: Current loadCronStore and loadCronStoreSync lines in this checkout blame to the imported/reverted store implementation commit that carries the envelope-only read behavior. (role: current store-line provenance; confidence: medium; commits: 3d96111a5afe; files: src/cron/store.ts)
galiniliev: Galin Iliev recently changed cron service and gateway cron behavior in the same runtime area touched by this PR. (role: recent adjacent contributor; confidence: medium; commits: 9eee202a694b; files: src/cron/service/timer.ts, src/gateway/server-cron.ts, src/gateway/server.cron.test.ts)
neeravmakwana: Neerav Makwana recently worked on legacy cron job identity loading and service/store regression coverage, which is adjacent to this legacy store-shape fix. (role: legacy persistence compatibility contributor; confidence: medium; commits: 242b2e66f29b; files: src/cron/service/store.ts, src/commands/doctor-cron-store-migration.ts)

Codex review notes: model gpt-5.5, reasoning high; reviewed against 5c39e0019d2f.

clawsweeper · 2026-05-20T04:27:31Z

ClawSweeper PR egg

✨ Hatched: 🥚 common Brave Lint Imp

Hatch command

Comment @clawsweeper hatch when this PR is hatchable.

Hatchability rules:

Merged PRs are hatchable.
Open PRs are hatchable when they are status: 👀 ready for maintainer look, status: 🚀 automerge armed, or labeled clawsweeper:automerge.
Closed unmerged PRs are hatchable only when one of those hatchable labels is still present in the durable record.

Rarity: 🥚 common.
Trait: stacks clean commits.
Image traits: location status garden; accessory miniature diff map; palette amber, ink, and glacier blue; mood sleepy but ready; pose waving from a small platform; shell matte ceramic shell; lighting cool dashboard glow; background tiny shells and proof notes.
Share on X: post this hatch
Copy: My PR egg hatched a 🥚 common Brave Lint Imp in ClawSweeper.

What is this egg doing here?

Eggs appear after the PR passes real-behavior proof. It is here for vibes, not verdicts: it does not change labels, ratings, merge decisions, or automation.
The shell reacts to review momentum: open follow-up work warms it up, re-review makes it wobble, and a clean final review lets it hatch.
Hatchability usually comes from sufficient real-behavior proof, no blocking P0/P1/P2 findings, no security attention needed, and clean correctness. A merged PR is already final, so merge makes the egg hatchable independently.
The hatch is seeded from this repository and PR number, so the same PR keeps the same creature; the reviewed head SHA can only change safe visual details.
Rarity is just collectible sparkle: 🥚 common, 🌱 uncommon, 💎 rare, ✨ glimmer, and 🌈 legendary.

Takhoffman · 2026-05-20T04:29:18Z

@clawsweeper automerge

IWhatsskill · 2026-05-20T04:29:48Z

sry for the Comment @Takhoffman my clanke was too motivated xD

clawsweeper · 2026-05-20T04:31:21Z

🦞✅
ClawSweeper merged this PR after the passing review.

Source: clawsweeper[bot]
Feedback: structured ClawSweeper verdict: pass (sha=446014b4c1f2832e3162e3969db4060648e9533f)
Merge status: merged by ClawSweeper automerge
Merged at: 2026-05-20T05:01:25Z
Merge commit: 29f8715f05c8

What merged:

The PR changes cron store loading to normalize legacy top-level array jobs.json files into the versioned store shape and adds store, service, doctor, gateway tests plus a changelog entry.
Reproducibility: yes. Current main clearly maps a top-level parsed array to {} before reading .jobs, and the PR body supplies before/after runtime output for the load/add/save path.

Automerge notes:

PR branch already contained follow-up commit before automerge: [AI-assisted] fix(cron): preserve legacy array stores

The automerge loop is complete.

Automerge progress:

2026-05-20 04:29:18 UTC review queued 6e2ab35417e5 (queued)

2026-05-20 04:31:20 UTC repair queued 6e2ab35417e5 (autonomous) Run: https://github.com/openclaw/clawsweeper/actions/runs/26141412348

2026-05-20 04:36:12 UTC repair started (running) in 0s Run: https://github.com/openclaw/clawsweeper/actions/runs/26141412348 automerge-openclaw-openclaw-84433

2026-05-20 04:36:28 UTC validation plan (passed) in 16s Run: https://github.com/openclaw/clawsweeper/actions/runs/26141412348 pnpm check:changed; pnpm lint; pnpm check:test-types

2026-05-20 04:36:41 UTC Codex write preflight (passed) in 29s Run: https://github.com/openclaw/clawsweeper/actions/runs/26141412348 danger-full-access

2026-05-20 04:42:48 UTC Codex edit 1 72f564434a1b (complete) in 6m 36s Run: https://github.com/openclaw/clawsweeper/actions/runs/26141412348 exit 0

2026-05-20 04:45:24 UTC validation and review 1 446014b4c1f2 (complete) in 9m 12s Run: https://github.com/openclaw/clawsweeper/actions/runs/26141412348 already-current

2026-05-20 04:45:29 UTC repair completed 446014b4c1f2 (branch updated) in 9m 17s Run: https://github.com/openclaw/clawsweeper/actions/runs/26141412348 initial automerge rebase is delegated to Codex repair

2026-05-20 04:45:29 UTC review queued 446014b4c1f2 (after repair)

2026-05-20 04:52:27 UTC automerge wait 446014b4c1f2 (ready) in 16m 15s Run: https://github.com/openclaw/clawsweeper/actions/runs/26141412348 checks and exact-head review are ready

2026-05-20 05:01:12 UTC review passed 446014b4c1f2 (structured ClawSweeper verdict: pass (sha=446014b4c1f2832e3162e3969db4060648e95...)

2026-05-20 04:52:28 UTC repair finished 446014b4c1f2 (pushed) in 16m 16s Run: https://github.com/openclaw/clawsweeper/actions/runs/26141412348 repair_contributor_branch

2026-05-20 04:54:04 UTC review queued 446014b4c1f2 (queued)

2026-05-20 05:01:27 UTC merged 446014b4c1f2 (merged by ClawSweeper automerge)

Summary: - The PR changes cron store loading to normalize legacy top-level array `jobs.json` files into the versioned store shape and adds store, service, doctor, gateway tests plus a changelog entry. - Reproducibility: yes. Current `main` clearly maps a top-level parsed array to `{}` before reading `.jobs`, and the PR body supplies before/after runtime output for the load/add/save path. Automerge notes: - PR branch already contained follow-up commit before automerge: [AI-assisted] fix(cron): preserve legacy array stores Validation: - ClawSweeper review passed for head 446014b4c1f2832e3162e3969db4060648e9533f. - Required merge gates passed before the squash merge. Prepared head SHA: 446014b4c1f2832e3162e3969db4060648e9533f Review: openclaw/openclaw#84433 (comment) Co-authored-by: JARVIS-Glasses <284122573+JARVIS-Glasses@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>

…026.5.20) (#615) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/openclaw/openclaw](https://openclaw.ai) ([source](https://github.com/openclaw/openclaw)) | patch | `2026.5.19` → `2026.5.20` | --- > ⚠️ **Warning** > > Some dependencies could not be looked up. Check the [Dependency Dashboard](issues/567) for more information. --- ### Release Notes <details> <summary>openclaw/openclaw (ghcr.io/openclaw/openclaw)</summary> ### [`v2026.5.20`](https://github.com/openclaw/openclaw/blob/HEAD/CHANGELOG.md#2026520) [Compare Source](openclaw/openclaw@v2026.5.19...v2026.5.20) ##### Changes - Exec approvals: remove the old `cat SKILL.md && printf ... && <skill-wrapper>` allowlist compatibility path so skill files must be loaded with the read tool and only the real skill executable is auto-allowed. - Discord: let voice sessions follow configured Discord users into voice channels, with allowed-channel checks, multi-user handoff, bounded reconciliation, and DAVE recovery preservation. ([#84264](openclaw/openclaw#84264)) Thanks [@fuller-stack-dev](https://github.com/fuller-stack-dev). - Discord/voice: include bounded `IDENTITY.md`, `USER.md`, and `SOUL.md` profile context in realtime voice session instructions by default, with `voice.realtime.bootstrapContextFiles: []` available to disable it. ([#84499](openclaw/openclaw#84499)) Thanks [@fuller-stack-dev](https://github.com/fuller-stack-dev). - Dependencies: bump the bundled Codex harness to `@openai/codex` `0.132.0` and refresh the app-server model-list docs for the new catalog. - CLI/policy: add the bundled Policy plugin for policy-backed channel conformance checks, doctor lint findings, and opt-in workspace repair. ([#80407](openclaw/openclaw#80407)) Thanks [@giodl73-repo](https://github.com/giodl73-repo). - Agents/config: allow `agents.list[].experimental.localModelLean` so lean local-model mode can be enabled for one configured agent instead of globally. - Providers/xAI: add device-code OAuth login so remote and headless setups can authorize xAI without a localhost browser callback. ([#84005](openclaw/openclaw#84005)) Thanks [@fuller-stack-dev](https://github.com/fuller-stack-dev). - Providers/OpenRouter: honor provider-level `params.provider` routing policy for OpenRouter requests, with model and agent params overriding the defaults. Thanks [@amknight](https://github.com/amknight). ##### Fixes - CLI/tasks: include stale-running task maintenance decisions in `openclaw tasks maintenance --json` so retained and reconcile candidates explain backing-session, cron, CLI, and wedged-subagent state. ([#84691](openclaw/openclaw#84691)) Thanks [@efpiva](https://github.com/efpiva). - Codex app-server: keep system-prompt reports working when bootstrap hooks provide workspace files with only a path and content, so hook-supplied SOUL/IDENTITY/TOOLS/USER context still reports injected characters correctly. ([#84736](openclaw/openclaw#84736)) Thanks [@JARVIS-Glasses](https://github.com/JARVIS-Glasses). - Providers/MiniMax music: stop advertising `durationSeconds` control and remove prompt-injected duration hints, so `music_generate` reports MiniMax duration as an unsupported override instead of suggesting MiniMax can enforce track length. Fixes [#84508](openclaw/openclaw#84508). Thanks [@neeravmakwana](https://github.com/neeravmakwana). - Doctor: warn when sandbox tool policy hides configured MCP server tools before provider requests. ([#84699](openclaw/openclaw#84699)) Thanks [@nxmxbbd](https://github.com/nxmxbbd). - WhatsApp: update Baileys to `7.0.0-rc12`. - Build: suppress per-locale `rolldown-plugin-dts:fake-js` CommonJS dts warnings emitted while bundling the intentionally-inlined `zod/v4/locales/*.d.cts` files, so `pnpm build` output stays readable after the 0.25.1 plugin bump. Thanks [@romneyda](https://github.com/romneyda). - CLI/nodes: route lazy plugin-registration logs to stderr for JSON-mode `openclaw nodes` commands so stdout stays parseable. ([#84684](openclaw/openclaw#84684)) Thanks [@TurboTheTurtle](https://github.com/TurboTheTurtle). - Approvals: route manual `/approve` decisions through the trusted approval runtime so active exec and plugin approvals no longer look unknown or expired. - Mac app: update the About settings copyright year to 2026. ([#84385](openclaw/openclaw#84385)) Thanks [@pejmanjohn](https://github.com/pejmanjohn). - Dependencies: update `@openclaw/fs-safe` to `0.2.7` so OpenClaw's default Python-helper-off policy keeps best-effort Node write fallbacks for private stores, secret writes, run logs, and media attachments on Linux/macOS. - Infra/secrets: restore the fail-closed contract for `tryReadSecretFileSync` so credential loaders that pass `rejectSymlink: true` (Telegram, LINE, Zalo, IRC, Nextcloud Talk tokens) refuse symlinked credential files instead of silently accepting them, and the infra-state CI shard's secret-file symlink test passes again. Thanks [@romneyda](https://github.com/romneyda). - Browser: honor the configured image sanitization limit for screenshots and labeled snapshots so browser-captured images follow the same resize policy as other image results. ([#84595](openclaw/openclaw#84595)) - Doctor: remove unrecognized `models.providers.*.models[*].compat.thinkingFormat` values during `doctor --fix` so stale provider model config can validate after upgrade. Fixes [#77803](openclaw/openclaw#77803). - Doctor: warn when `openclaw.json` stores plaintext secret-bearing config fields, including model provider API keys and sensitive provider headers. ([#84718](openclaw/openclaw#84718)) Thanks [@lukaIvanic](https://github.com/lukaIvanic). - Status: show the configured default, session-selected model, reason, clear hint, and docs link when a session remains pinned to a model that differs from `agents.defaults.model.primary`. - WebChat: clear stale typing indicators when session change events mark the active chat run complete. - Mac app: keep local packaging signed with a stable app identity for permission testing and fix Control UI production builds under current Vite/Highlight.js exports. - macOS app: update the embedded Peekaboo bridge to 3.2.1 so OpenClaw-hosted UI automation works with current Peekaboo CLI capture flows. - Cron: deliver preferred final assistant output for successful scheduled runs when trailing plain tool warnings remain in diagnostics instead of marking the run failed. - fix(mattermost): fail closed on missing channel type \[AI]. ([#84091](openclaw/openclaw#84091)) Thanks [@pgondhi987](https://github.com/pgondhi987). - Recheck rebuilt system.run argv \[AI]. ([#84090](openclaw/openclaw#84090)) Thanks [@pgondhi987](https://github.com/pgondhi987). - CLI: keep the private QA subcommand out of exported command descriptors unless `OPENCLAW_ENABLE_PRIVATE_QA_CLI=1`, so root help and subcommand markers match runtime registration. ([#84519](openclaw/openclaw#84519)) - CLI/cron: bound `openclaw cron show` job lookup pagination so non-advancing or unbounded `cron.list` responses fail instead of hanging the command. Fixes [#83856](openclaw/openclaw#83856). ([#83989](openclaw/openclaw#83989)) - Agents/messages: stop message-tool-only turns after a successful source-channel `message` send while keeping transcript mirrors under the session write lock. ([#84289](openclaw/openclaw#84289)) - Agents: filter silent heartbeat response-tool transcript artifacts out of embedded context snapshots so later user turns are not polluted by heartbeat no-op messages. ([#83477](openclaw/openclaw#83477)) Thanks [@fuller-stack-dev](https://github.com/fuller-stack-dev). - Agents/OpenAI: log repeated strict tool-schema downgrade diagnostics once per provider/model/tool signature, reducing duplicate debug noise while preserving `strict=false` fallback behavior. Fixes [#82930](openclaw/openclaw#82930). ([#82933](openclaw/openclaw#82933)) Thanks [@galiniliev](https://github.com/galiniliev). - Agents/code mode: spell out the `exec` tool's JavaScript/TypeScript, no Node module, and catalog-bridge constraints in model-visible schema text so agents can use enabled tools without trial-and-error. ([#84269](openclaw/openclaw#84269)) Thanks [@Kaspre](https://github.com/Kaspre). - Codex: give `image_generate` dynamic-tool calls a 120s default watchdog when no per-call or configured image timeout is set, so image generation no longer falls back to the generic 30s bridge timeout. ([#84254](openclaw/openclaw#84254)) Thanks [@moritzmmayerhofer](https://github.com/moritzmmayerhofer). - Codex: avoid duplicate dynamic tool terminal diagnostics while large diagnostic backlogs drain without blocking tool responses. ([#82937](openclaw/openclaw#82937)) Thanks [@galiniliev](https://github.com/galiniliev). - CLI/message: include a stable top-level `messageId` in `openclaw message --json` output when channel sends return one. ([#84191](openclaw/openclaw#84191)) Thanks [@100menotu001](https://github.com/100menotu001). - Cron: preserve legacy top-level array `jobs.json` stores when loading or adding scheduled jobs so old cron jobs are no longer treated as an empty store during upgrade. Fixes [#60799](openclaw/openclaw#60799). ([#84433](openclaw/openclaw#84433)) Thanks [@IWhatsskill](https://github.com/IWhatsskill). - Gateway/agents: use an agent's `identity.name` in Gateway agent summaries when `agents.list[].name` is unset, so configured agent labels remain visible in clients. ([#84355](openclaw/openclaw#84355); refs [#57835](openclaw/openclaw#57835)) Thanks [@luoyanglang](https://github.com/luoyanglang). - Channels/replies: keep normal `/verbose` failed-tool progress compact in message-tool replies and prevent late text-only tool output from appearing after the final answer. ([#84303](openclaw/openclaw#84303)) Thanks [@VACInc](https://github.com/VACInc). - Plugins/hooks: apply a default 30-second timeout to `before_compaction` and `after_compaction` hooks so a hung plugin handler no longer blocks compaction completion. ([#84153](openclaw/openclaw#84153)) - Discord: preserve disabled presentation buttons when adapting and rendering Discord message controls. ([#84188](openclaw/openclaw#84188)) Thanks [@100menotu001](https://github.com/100menotu001). - Twitch: add a test-only client-manager registry reset helper so non-isolated Twitch tests can clear cached managers between cases. Fixes [#83887](openclaw/openclaw#83887). ([#84244](openclaw/openclaw#84244)) Thanks [@hclsys](https://github.com/hclsys). - Cron: run main-session scheduled work on a cron-owned wake lane while preserving reply delivery context, so background cron turns no longer block human main-session chat. Fixes [#82766](openclaw/openclaw#82766). ([#82767](openclaw/openclaw#82767)) Thanks [@galiniliev](https://github.com/galiniliev). - Cron: use structured embedded-run denial metadata for isolated scheduled tasks so blocked exec requests fail the job without treating ordinary assistant prose as a denial. ([#84067](openclaw/openclaw#84067)) Thanks [@abnershang](https://github.com/abnershang). - Cron: keep recovered tool warnings diagnostic for successful scheduled runs so final cron output is delivered instead of being replaced by a post-processing warning. ([#84045](openclaw/openclaw#84045)) Thanks [@abnershang](https://github.com/abnershang). - Plugins/perf: thread explicit plugin discovery results through `loadBundledCapabilityRuntimeRegistry`, `resolveBundledPluginSources`, and `listChannelCatalogEntries` so callers that already hold a discovery result skip redundant filesystem walks. Thanks [@SebTardif](https://github.com/SebTardif). - harden update restart script creation \[AI]. ([#84088](openclaw/openclaw#84088)) Thanks [@pgondhi987](https://github.com/pgondhi987). - Docker: keep the bundled Codex plugin in official release image keep lists so the default OpenAI agent harness remains available after Docker pruning. Fixes [#83613](openclaw/openclaw#83613). ([#83626](openclaw/openclaw#83626)) Thanks [@YuanHanzhong](https://github.com/YuanHanzhong). - CLI/channels: preserve the first line of `openclaw channels logs` output when the rolling tail window starts exactly on a line boundary, mirroring the already-fixed `readLogSlice` behavior in `src/logging/log-tail.ts`. - Control UI: treat terminal session status as authoritative over stale active-run flags so completed terminal runs stop showing abort/live UI. ([#84057](openclaw/openclaw#84057)) - CLI: preserve embedded equals signs in inline root option values instead of truncating after the second separator. ([#83995](openclaw/openclaw#83995)) Thanks [@ThiagoCAltoe](https://github.com/ThiagoCAltoe). - Matrix/config: accept `messages.queue.byChannel.matrix` queue overrides and keep queue provider schema/type keys aligned for Matrix, Google Chat, and Mattermost. Thanks [@bdjben](https://github.com/bdjben). - CLI: format `openclaw acp client` failures through the shared error formatter so object-shaped errors stay readable instead of printing `[object Object]`. Fixes [#83904](openclaw/openclaw#83904). ([#84080](openclaw/openclaw#84080)) - Providers/Ollama: default unknown-capabilities models to tool-capable so discovered native Ollama models can use tools when `/api/show` omits capabilities. ([#84055](openclaw/openclaw#84055)) Thanks [@dutifulbob](https://github.com/dutifulbob). - Installer/Windows: launch `install.ps1` onboarding as an attached child process so fresh native Windows installs do not freeze visibly at `Starting setup...` or corrupt the wizard's terminal rendering. - CLI/update: keep restart health checks working across one-version CLI/Gateway protocol skew and use the managed Gateway service Node for all follow-up commands even when the package root is unchanged, so `openclaw update` no longer silently switches the gateway to a different Node binary when multiple Node installations are present. Thanks [@amknight](https://github.com/amknight). - CLI/gateway: include the running Gateway version in `gateway status` JSON output, preserving existing server metadata while falling back to status RPC data for read probes. Fixes [#56222](openclaw/openclaw#56222). Thanks [@galiniliev](https://github.com/galiniliev). - Memory/search: close local embedding providers when active-memory searches time out so pending local model loads and embedding contexts are aborted and released. ([#83858](openclaw/openclaw#83858)) Thanks [@brokemac79](https://github.com/brokemac79). - CLI/nodes: request pending node surface approval scopes before `openclaw nodes approve` so exec-capable node approval can use admin-scoped Gateway credentials instead of failing with `missing scope: operator.admin`. ([#84392](openclaw/openclaw#84392)) Thanks [@joshavant](https://github.com/joshavant). - Gateway: reject slow node event sends before outbound buffers grow unbounded and log the rejected payload diagnostic. ([#84387](openclaw/openclaw#84387)) Thanks [@samzong](https://github.com/samzong). - Agents: include bounded trajectory queued-writer diagnostics in `pi-trajectory-flush` timeout warnings so flush stalls show pending writes, queued bytes, and append state. Fixes [#82961](openclaw/openclaw#82961). ([#82962](openclaw/openclaw#82962)) Thanks [@galiniliev](https://github.com/galiniliev). - Agents/subagents: recover stale completion announces by retrying unsupported transcript-wait wakes without transcript waiting and forcing a message-tool handoff when the requester run is already stale. Fixes [#83699](openclaw/openclaw#83699). ([#83700](openclaw/openclaw#83700)) Thanks [@galiniliev](https://github.com/galiniliev). - Agents/subagents: constrain wildcard subagent target allowlists to configured agents while preserving explicitly listed compatibility targets. Fixes [#84040](openclaw/openclaw#84040). ([#84357](openclaw/openclaw#84357)) Thanks [@joshavant](https://github.com/joshavant). - Providers/Anthropic: route Anthropic model refs selected with Claude CLI auth through the Claude CLI runtime so shorthand refs such as `anthropic/opus-4.7` no longer fall back to embedded Anthropic billing. Fixes [#84222](openclaw/openclaw#84222). ([#84374](openclaw/openclaw#84374)) Thanks [@joshavant](https://github.com/joshavant). - Agents: honor explicit `models.providers.<id>.timeoutSeconds` values above the default idle watchdog for cloud and self-hosted providers, so long first-token waits no longer fall back at \~120s when the provider timeout is higher. ([#83979](openclaw/openclaw#83979)) Thanks [@yujiawei](https://github.com/yujiawei). - Agents/Codex: keep encrypted Responses reasoning replay provenance-bound so stale mirrored Codex transcripts drop invalid encrypted content before request assembly while preserving matching same-session replay. Fixes [#83836](openclaw/openclaw#83836). ([#84367](openclaw/openclaw#84367)) Thanks [@joshavant](https://github.com/joshavant). - Agents/subagents: skip stale embedded-run wake probes for dormant completion requesters, so late subagent completions go straight to requester-agent/direct handoff instead of producing `reason=no_active_run` queue noise. ([#82964](openclaw/openclaw#82964)) Thanks [@galiniliev](https://github.com/galiniliev). - CLI: retry config snapshot reads after a transient failure so one rejected read no longer poisons later commands in the same process. ([#83931](openclaw/openclaw#83931)) Thanks [@honor2030](https://github.com/honor2030). - Media: decode URL path basenames before using them as remote media fallback filenames, so files like `My%20Report.pdf` are surfaced as `My Report.pdf`. Fixes [#84050](openclaw/openclaw#84050). ([#84052](openclaw/openclaw#84052)) Thanks [@jbetala7](https://github.com/jbetala7). - WhatsApp: clarify inbound group diagnostics so observed but unregistered groups point to `channels.whatsapp.groups` without changing routing or sender authorization. ([#83846](openclaw/openclaw#83846)) Thanks [@neeravmakwana](https://github.com/neeravmakwana). - WhatsApp: drain pending outbound deliveries on a 30s periodic timer in addition to the reconnect handler, so messages enqueued while the provider is already connected no longer wait for the next reconnect to send. ([#79083](openclaw/openclaw#79083)) Thanks [@Oviemudiaga](https://github.com/Oviemudiaga). - CLI/TUI: include gateway plugin slash commands in TUI autocomplete, so connected sessions can suggest plugin-owned commands exposed by the running Gateway. ([#83640](openclaw/openclaw#83640)) Thanks [@se7en-agent](https://github.com/se7en-agent). - Gateway/mobile: restore QR setup-code handoff of bounded operator tokens for iOS and Android onboarding while keeping admin and pairing scopes out of bootstrap. ([#83684](openclaw/openclaw#83684)) Thanks [@ngutman](https://github.com/ngutman). - iOS: repair Release archive compilation for the TestFlight build. ([#84255](openclaw/openclaw#84255)) Thanks [@ngutman](https://github.com/ngutman). - Agents/compaction: bound plugin-owned CLI transcript compaction with the host safety timeout so a hung context engine can no longer stall post-turn cleanup. ([#84083](openclaw/openclaw#84083)) Thanks [@100yenadmin](https://github.com/100yenadmin). - Control UI/usage: truncate long context skill, tool, and file names in the usage panel while keeping the full name available on hover. ([#42197](openclaw/openclaw#42197)) Thanks [@Rain120](https://github.com/Rain120). - Codex: respect explicit `models auth order set` and `config.auth.order` precedence over stale `lastGood` in `/codex account`, and show `no working credential` when every explicit-order profile is ineligible instead of marking a lower-ranked profile as active. Fixes [#84386](openclaw/openclaw#84386). ([#84412](openclaw/openclaw#84412)) Thanks [@openperf](https://github.com/openperf). - Agents: honor `messages.suppressToolErrors` for mutating tool failures so configured chat surfaces do not receive separate warning payloads. ([#81561](openclaw/openclaw#81561)) Thanks [@moeedahmed](https://github.com/moeedahmed). - Agents/fallback: surface billing guidance for mixed rate-limit plus billing fallback exhaustion instead of generic failure copy. Fixes [#79396](openclaw/openclaw#79396). ([#79489](openclaw/openclaw#79489)) Thanks [@aayushprsingh](https://github.com/aayushprsingh). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/615

Summary: - The PR changes cron store loading to normalize legacy top-level array `jobs.json` files into the versioned store shape and adds store, service, doctor, gateway tests plus a changelog entry. - Reproducibility: yes. Current `main` clearly maps a top-level parsed array to `{}` before reading `.jobs`, and the PR body supplies before/after runtime output for the load/add/save path. Automerge notes: - PR branch already contained follow-up commit before automerge: [AI-assisted] fix(cron): preserve legacy array stores Validation: - ClawSweeper review passed for head 446014b. - Required merge gates passed before the squash merge. Prepared head SHA: 446014b Review: openclaw#84433 (comment) Co-authored-by: JARVIS-Glasses <284122573+JARVIS-Glasses@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>

openclaw-barnacle Bot added gateway Gateway runtime commands Command implementations size: M proof: supplied External PR includes structured after-fix real behavior proof. labels May 20, 2026

clawsweeper Bot added the clawsweeper:automerge Maintainer opted this PR into bounded ClawSweeper-reviewed automerge label May 20, 2026

IWhatsskill and others added 2 commits May 20, 2026 04:37

fix(cron): preserve legacy array stores

72f5644

[AI-assisted] fix(cron): preserve legacy array stores

446014b

clawsweeper Bot force-pushed the fix/cron-legacy-array-store-60799 branch from 6e2ab35 to 446014b Compare May 20, 2026 04:45

clawsweeper Bot added status: 🚀 automerge armed This PR is in ClawSweeper's automerge lane. and removed status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels May 20, 2026

clawsweeper Bot merged commit 29f8715 into openclaw:main May 20, 2026
107 of 109 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[AI-assisted] fix(cron): preserve legacy array stores#84433

[AI-assisted] fix(cron): preserve legacy array stores#84433
clawsweeper[bot] merged 2 commits into
openclaw:mainfrom
IWhatsskill:fix/cron-legacy-array-store-60799

IWhatsskill commented May 20, 2026

Uh oh!

clawsweeper Bot commented May 20, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented May 20, 2026

Uh oh!

Takhoffman commented May 20, 2026

Uh oh!

IWhatsskill commented May 20, 2026

Uh oh!

clawsweeper Bot commented May 20, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

IWhatsskill commented May 20, 2026

Summary

Motivation

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

Real behavior proof (required for external PRs)

Root Cause (if applicable)

Regression Test Plan (if applicable)

User-visible / Behavior Changes

Diagram (if applicable)

Security Impact (required)

Repro + Verification

Environment

Steps

Expected

Actual

Evidence

Human Verification (required)

Review Conversations

Compatibility / Migration

Risks and Mitigations

Uh oh!

clawsweeper Bot commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clawsweeper Bot commented May 20, 2026

Hatch command

Uh oh!

Takhoffman commented May 20, 2026

Uh oh!

IWhatsskill commented May 20, 2026

Uh oh!

clawsweeper Bot commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

clawsweeper Bot commented May 20, 2026 •

edited

Loading

clawsweeper Bot commented May 20, 2026 •

edited

Loading