Warn on plaintext secret config in doctor by lukaIvanic · Pull Request #84718 · openclaw/openclaw

lukaIvanic · 2026-05-20T22:36:27Z

Summary

Add a doctor security warning when openclaw.json contains plaintext secret-bearing fields such as models.providers.<id>.apiKey and sensitive provider headers like Authorization.
Skip the warning for SecretRef-backed values so migrated configs stay quiet.
Point users to openclaw secrets configure / openclaw secrets apply and openclaw secrets audit --check.

Why

Issue #11829 tracks API key exposure to agents. The current secrets tooling can already audit and migrate plaintext values, but a normal openclaw doctor run can still look healthy while openclaw.json stores agent-readable API keys/tokens. This change makes that risk visible in the security warning surface users already run.

This does not claim to replace the broader secret-isolation architecture. It closes a practical visibility gap and helps users migrate away from plaintext config secrets before agents or workspace tools read them directly.

Test

node scripts/run-vitest.mjs run --config test/vitest/vitest.commands.config.ts src/commands/doctor-security.test.ts
node scripts/run-vitest.mjs run src/secrets/audit.test.ts
git diff --check
pnpm check:test-types

Result: doctor security test passed 1 file / 32 tests; secrets audit test passed 1 file / 24 tests; git diff --check passed; pnpm check:test-types passed.

Real behavior proof

Behavior or issue addressed: openclaw doctor --non-interactive now surfaces plaintext secret-bearing model provider config in openclaw.json, including models.providers.openai.apiKey and models.providers.openai.headers.Authorization.

Real environment tested: Local OpenClaw checkout after this patch, running node openclaw.mjs doctor --non-interactive against a real temporary config file at /Users/lukaivanic/projects/organization/llm_money_making_experiment/folder_2/proof/openclaw-doctor-plaintext/openclaw.json. The config contained redacted plaintext values in models.providers.openai.apiKey and models.providers.openai.headers.Authorization.

Exact steps or command run after this patch:

OPENCLAW_CONFIG_PATH=/Users/lukaivanic/projects/organization/llm_money_making_experiment/folder_2/proof/openclaw-doctor-plaintext/openclaw.json \
OPENCLAW_HOME=/Users/lukaivanic/projects/organization/llm_money_making_experiment/folder_2/proof/openclaw-doctor-plaintext/home \
node openclaw.mjs doctor --non-interactive

Evidence after fix: Terminal output from the real CLI command above included this live output excerpt:

◇  Security

  - WARNING: openclaw.json contains plaintext secret-bearing config
    fields.
    Paths: models.providers.openai.apiKey,
    models.providers.openai.headers.Authorization
    Agents or workspace tools that can read config files may see these
    API keys/tokens.
    Migrate them to SecretRefs with openclaw secrets configure or
    openclaw secrets apply, then verify with openclaw secrets audit
    --check.

Observed result after fix: The live doctor run printed a Security warning for both plaintext config paths: models.providers.openai.apiKey and models.providers.openai.headers.Authorization, and it pointed the user to SecretRefs plus openclaw secrets audit --check.

What was not tested: No additional gaps.

Refs #11829

clawsweeper · 2026-05-20T22:37:50Z

Codex review: passed.

Workflow note: Future ClawSweeper reviews update this same comment in place.

How this review workflow works

ClawSweeper keeps one durable marker-backed review comment per issue or PR.
Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
Maintainers can also comment @clawsweeper review to request a fresh review only.
Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

Summary
Adds a doctor security warning for plaintext secret-bearing openclaw.json fields by reusing the secrets target registry and shared model-provider header sensitivity policy.

Reproducibility: yes. for source-level behavior: current main has plaintext secret audit coverage but no doctor collector for those config targets, and the PR body includes live patched CLI output showing the new warning.

PR rating
Overall: 🐚 platinum hermit
Proof: 🦞 diamond lobster
Patch quality: 🐚 platinum hermit
Summary: Strong live CLI proof plus a focused shared-policy patch make this a normal good PR ready for exact-head gates.

Rank-up moves:

none

What the crustacean ranks mean

🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Real behavior proof
Sufficient (live_output): The PR body includes copied live CLI output from a patched doctor --non-interactive run showing the new plaintext config warning and affected paths.

Next step before merge
No repair lane is needed; the PR has no actionable review findings and should proceed through the existing automerge/check gates.

Security
Cleared: The diff adds a security warning without printing secret values, adding dependencies, changing workflows, or changing secret resolution behavior.

Review details

Best possible solution:

Land the shared-policy doctor warning after exact-head checks and automerge gates complete, while leaving the broader secret-isolation roadmap tracked separately.

Do we have a high-confidence way to reproduce the issue?

Yes for source-level behavior: current main has plaintext secret audit coverage but no doctor collector for those config targets, and the PR body includes live patched CLI output showing the new warning.

Is this the best way to solve the issue?

Yes: the PR keeps doctor aligned with the existing secrets registry, SecretRef detection, plaintext-value helper, and model-provider header policy instead of inventing a second target list.

Label changes:

add status: 🚀 automerge armed: This PR is in ClawSweeper's automerge lane. Sufficient (live_output): The PR body includes copied live CLI output from a patched doctor --non-interactive run showing the new plaintext config warning and affected paths.
remove status: 👀 ready for maintainer look: Current PR status label is status: 🚀 automerge armed.

Label justifications:

P2: This is a focused security-diagnostic improvement with limited blast radius, targeted tests, and real CLI proof.
rating: 🐚 platinum hermit: Current PR rating is 🐚 platinum hermit because proof is 🦞 diamond lobster, patch quality is 🐚 platinum hermit, and Strong live CLI proof plus a focused shared-policy patch make this a normal good PR ready for exact-head gates.
status: 🚀 automerge armed: This PR is in ClawSweeper's automerge lane. Sufficient (live_output): The PR body includes copied live CLI output from a patched doctor --non-interactive run showing the new plaintext config warning and affected paths.
proof: sufficient: Contributor real behavior proof is sufficient. The PR body includes copied live CLI output from a patched doctor --non-interactive run showing the new plaintext config warning and affected paths.

What I checked:

Current main lacks the doctor warning: On current main, collectSecurityWarnings collects existing approval, exec-filesystem, and durable approval warnings, but has no plaintext config-secret collector before gateway/channel checks. (src/commands/doctor-security.ts:197, 5c4c6a42071c)
Existing secrets audit already owns the target semantics: Current main collectConfigSecrets scans discovered config secret targets, skips SecretRefs, reports plaintext, and already special-cases non-sensitive models.providers.*.headers.* names. (src/secrets/audit.ts:216, 5c4c6a42071c)
Registry includes the affected model-provider paths: The current registry marks models.providers.*.apiKey, models.providers.*.headers.*, and models.providers.*.request.headers.* as auditable openclaw.json secret-input targets. (src/secrets/target-registry-data.ts:236, 5c4c6a42071c)
PR implements the warning through shared policy: The PR adds collectPlaintextConfigSecretWarnings, reuses discoverConfigSecretTargets, skips SecretRefs via resolveSecretInputRef, keeps the audit header sensitivity split, and prints only paths plus migration commands. (src/commands/doctor-security.ts:186, 31f83aae194f)
PR shares the sensitive header classifier: The PR moves model-provider header-name sensitivity into src/secrets/model-provider-header-policy.ts, preserving the existing exact names and fragments used by audit. (src/secrets/model-provider-header-policy.ts:1, 31f83aae194f)
PR adds focused regression coverage: The PR adds doctor tests for plaintext provider API keys, sensitive headers, non-sensitive header suppression, request-header alignment, and SecretRef suppression. (src/commands/doctor-security.test.ts:335, 31f83aae194f)

Likely related people:

joshavant: GitHub file history shows major SecretRef/audit work, including broad credential target coverage and read-only SecretRef audit hardening, across the same secrets audit and registry surfaces. (role: feature-history owner; confidence: high; commits: 806803b7efe2, a2cb81199e22, 36d2ae2a2235; files: src/secrets/audit.ts, src/secrets/target-registry-data.ts, docs/cli/secrets.md)
steipete: Recent history on target-registry and doctor-adjacent files shows repeated secrets/doctor maintenance and cleanup around the same code paths. (role: recent area contributor; confidence: medium; commits: e3a248585e66, fe680e47cece, bd8e986bb2eb; files: src/secrets/target-registry-data.ts, src/commands/doctor-security.test.ts, src/commands/doctor-security.ts)
giodl73-repo: GitHub file history shows recent read-only doctor health-check conversion touching src/commands/doctor-security.ts, the main file this PR extends. (role: recent doctor contributor; confidence: medium; commits: 94abfa76e21f; files: src/commands/doctor-security.ts)

Codex review notes: model gpt-5.5, reasoning high; reviewed against 5c4c6a42071c.

clawsweeper · 2026-05-20T22:42:24Z

ClawSweeper PR egg

✨ Hatched: 🥚 common Pearl Test Hopper

Hatch command

Comment @clawsweeper hatch when this PR is hatchable.

Hatchability rules:

Merged PRs are hatchable.
Open PRs are hatchable when they are status: 👀 ready for maintainer look, status: 🚀 automerge armed, or labeled clawsweeper:automerge.
Closed unmerged PRs are hatchable only when one of those hatchable labels is still present in the durable record.

Rarity: 🥚 common.
Trait: watches the merge queue.
Image traits: location green-check meadow; accessory review stamp; palette sunrise gold and clean white; mood focused; pose nestled inside a glowing shell; shell brushed metal shell; lighting clean product lighting; background delicate sparkle particles.
Share on X: post this hatch
Copy: My PR egg hatched a 🥚 common Pearl Test Hopper in ClawSweeper.

What is this egg doing here?

Eggs appear after the PR passes real-behavior proof. It is here for vibes, not verdicts: it does not change labels, ratings, merge decisions, or automation.
The shell reacts to review momentum: open follow-up work warms it up, re-review makes it wobble, and a clean final review lets it hatch.
Hatchability usually comes from sufficient real-behavior proof, no blocking P0/P1/P2 findings, no security attention needed, and clean correctness. A merged PR is already final, so merge makes the egg hatchable independently.
The hatch is seeded from this repository and PR number, so the same PR keeps the same creature; the reviewed head SHA can only change safe visual details.
Rarity is just collectible sparkle: 🥚 common, 🌱 uncommon, 💎 rare, ✨ glimmer, and 🌈 legendary.

lukaIvanic · 2026-05-20T23:08:43Z

@clawsweeper re-review

Real behavior proof fields have been updated in the PR body, and the latest Real behavior proof check is green on head 03c8d7c8.

clawsweeper · 2026-05-20T23:09:20Z

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

Re-review progress:

State: Complete
Detail: The targeted re-review finished, the durable review comment was updated, and the synced verdict was routed.
Run: https://github.com/openclaw/clawsweeper/actions/runs/26195245177
Updated: 2026-05-20T23:16:30.753Z

lukaIvanic · 2026-05-20T23:23:42Z

@clawsweeper re-review

Addressed the author-wait finding by moving the model-provider header sensitivity policy into shared secrets code and using it from both src/secrets/audit.ts and src/commands/doctor-security.ts. Doctor now preserves the audit split between models.providers.*.headers.* and models.providers.*.request.headers.*.

Verification passed after the update:

node scripts/run-vitest.mjs run --config test/vitest/vitest.commands.config.ts src/commands/doctor-security.test.ts (32 tests)
node scripts/run-vitest.mjs run src/secrets/audit.test.ts (24 tests)
git diff --check
pnpm check:test-types

Takhoffman · 2026-05-21T00:04:39Z

@clawsweeper automerge

clawsweeper · 2026-05-21T00:06:49Z

🦞✅
ClawSweeper merged this PR after the passing review.

Source: clawsweeper[bot]
Feedback: structured ClawSweeper verdict: pass (sha=31f83aae194fdb43a636d8056c3713216648fdd7)
Merge status: merged by ClawSweeper automerge
Merged at: 2026-05-21T01:27:35Z
Merge commit: 9cdf8a1e2f9f

What merged:

Adds a doctor security warning for plaintext secret-bearing openclaw.json fields by reusing the secrets target registry and shared model-provider header sensitivity policy.
Reproducibility: yes. for source-level behavior: current main has plaintext secret audit coverage but no doc ... llector for those config targets, and the PR body includes live patched CLI output showing the new warning.

Automerge notes:

PR branch already contained follow-up commit before automerge: Warn on plaintext secret config in doctor

The automerge loop is complete.

Automerge progress:

2026-05-21 00:04:39 UTC review queued 720fb5ad9bf1 (queued)

2026-05-21 00:06:48 UTC repair queued 720fb5ad9bf1 (autonomous) Run: https://github.com/openclaw/clawsweeper/actions/runs/26197290696

2026-05-21 00:09:29 UTC repair started (running) in 0s Run: https://github.com/openclaw/clawsweeper/actions/runs/26197290696 automerge-openclaw-openclaw-84718

2026-05-21 00:09:41 UTC validation plan (passed) in 13s Run: https://github.com/openclaw/clawsweeper/actions/runs/26197290696 pnpm check:changed; pnpm lint; pnpm check:test-types

2026-05-21 00:09:59 UTC Codex write preflight (passed) in 31s Run: https://github.com/openclaw/clawsweeper/actions/runs/26197290696 danger-full-access

2026-05-21 00:15:07 UTC Codex edit 1 8c2e534e5ce0 (complete) in 5m 38s Run: https://github.com/openclaw/clawsweeper/actions/runs/26197290696 exit 0

2026-05-21 00:18:08 UTC validation and review 1 31f83aae194f (complete) in 8m 40s Run: https://github.com/openclaw/clawsweeper/actions/runs/26197290696 already-current

2026-05-21 00:18:14 UTC repair completed 31f83aae194f (branch updated) in 8m 45s Run: https://github.com/openclaw/clawsweeper/actions/runs/26197290696 initial automerge rebase is delegated to Codex repair

2026-05-21 00:18:13 UTC review queued 31f83aae194f (after repair)

2026-05-21 00:28:17 UTC automerge wait 31f83aae194f (waiting) in 18m 49s Run: https://github.com/openclaw/clawsweeper/actions/runs/26197290696 waiting for GitHub checks: auto-response:IN_PROGRESS

2026-05-21 00:24:50 UTC review passed 31f83aae194f (structured ClawSweeper verdict: pass (sha=31f83aae194fdb43a636d8056c3713216648f...)

2026-05-21 00:28:19 UTC repair finished 31f83aae194f (pushed) in 18m 50s Run: https://github.com/openclaw/clawsweeper/actions/runs/26197290696 repair_contributor_branch

2026-05-21 01:26:12 UTC review queued 31f83aae194f (queued)

2026-05-21 01:27:37 UTC merged 31f83aae194f (merged by ClawSweeper automerge)

lukaIvanic · 2026-05-21T05:00:52Z

Thanks for merging this. One administrative follow-up: this PR was also submitted against TaskBounty task 623bb359-6405-4142-a1c5-f06ce4b9779c as submission 4e72a63a-44f7-40bd-8c57-03449e4272ec.

I am not treating it as paid/accepted unless TaskBounty or a maintainer explicitly marks or confirms an award, but leaving the merged upstream evidence here in case it helps the bounty review.

…026.5.20) (#615) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/openclaw/openclaw](https://openclaw.ai) ([source](https://github.com/openclaw/openclaw)) | patch | `2026.5.19` → `2026.5.20` | --- > ⚠️ **Warning** > > Some dependencies could not be looked up. Check the [Dependency Dashboard](issues/567) for more information. --- ### Release Notes <details> <summary>openclaw/openclaw (ghcr.io/openclaw/openclaw)</summary> ### [`v2026.5.20`](https://github.com/openclaw/openclaw/blob/HEAD/CHANGELOG.md#2026520) [Compare Source](openclaw/openclaw@v2026.5.19...v2026.5.20) ##### Changes - Exec approvals: remove the old `cat SKILL.md && printf ... && <skill-wrapper>` allowlist compatibility path so skill files must be loaded with the read tool and only the real skill executable is auto-allowed. - Discord: let voice sessions follow configured Discord users into voice channels, with allowed-channel checks, multi-user handoff, bounded reconciliation, and DAVE recovery preservation. ([#84264](openclaw/openclaw#84264)) Thanks [@fuller-stack-dev](https://github.com/fuller-stack-dev). - Discord/voice: include bounded `IDENTITY.md`, `USER.md`, and `SOUL.md` profile context in realtime voice session instructions by default, with `voice.realtime.bootstrapContextFiles: []` available to disable it. ([#84499](openclaw/openclaw#84499)) Thanks [@fuller-stack-dev](https://github.com/fuller-stack-dev). - Dependencies: bump the bundled Codex harness to `@openai/codex` `0.132.0` and refresh the app-server model-list docs for the new catalog. - CLI/policy: add the bundled Policy plugin for policy-backed channel conformance checks, doctor lint findings, and opt-in workspace repair. ([#80407](openclaw/openclaw#80407)) Thanks [@giodl73-repo](https://github.com/giodl73-repo). - Agents/config: allow `agents.list[].experimental.localModelLean` so lean local-model mode can be enabled for one configured agent instead of globally. - Providers/xAI: add device-code OAuth login so remote and headless setups can authorize xAI without a localhost browser callback. ([#84005](openclaw/openclaw#84005)) Thanks [@fuller-stack-dev](https://github.com/fuller-stack-dev). - Providers/OpenRouter: honor provider-level `params.provider` routing policy for OpenRouter requests, with model and agent params overriding the defaults. Thanks [@amknight](https://github.com/amknight). ##### Fixes - CLI/tasks: include stale-running task maintenance decisions in `openclaw tasks maintenance --json` so retained and reconcile candidates explain backing-session, cron, CLI, and wedged-subagent state. ([#84691](openclaw/openclaw#84691)) Thanks [@efpiva](https://github.com/efpiva). - Codex app-server: keep system-prompt reports working when bootstrap hooks provide workspace files with only a path and content, so hook-supplied SOUL/IDENTITY/TOOLS/USER context still reports injected characters correctly. ([#84736](openclaw/openclaw#84736)) Thanks [@JARVIS-Glasses](https://github.com/JARVIS-Glasses). - Providers/MiniMax music: stop advertising `durationSeconds` control and remove prompt-injected duration hints, so `music_generate` reports MiniMax duration as an unsupported override instead of suggesting MiniMax can enforce track length. Fixes [#84508](openclaw/openclaw#84508). Thanks [@neeravmakwana](https://github.com/neeravmakwana). - Doctor: warn when sandbox tool policy hides configured MCP server tools before provider requests. ([#84699](openclaw/openclaw#84699)) Thanks [@nxmxbbd](https://github.com/nxmxbbd). - WhatsApp: update Baileys to `7.0.0-rc12`. - Build: suppress per-locale `rolldown-plugin-dts:fake-js` CommonJS dts warnings emitted while bundling the intentionally-inlined `zod/v4/locales/*.d.cts` files, so `pnpm build` output stays readable after the 0.25.1 plugin bump. Thanks [@romneyda](https://github.com/romneyda). - CLI/nodes: route lazy plugin-registration logs to stderr for JSON-mode `openclaw nodes` commands so stdout stays parseable. ([#84684](openclaw/openclaw#84684)) Thanks [@TurboTheTurtle](https://github.com/TurboTheTurtle). - Approvals: route manual `/approve` decisions through the trusted approval runtime so active exec and plugin approvals no longer look unknown or expired. - Mac app: update the About settings copyright year to 2026. ([#84385](openclaw/openclaw#84385)) Thanks [@pejmanjohn](https://github.com/pejmanjohn). - Dependencies: update `@openclaw/fs-safe` to `0.2.7` so OpenClaw's default Python-helper-off policy keeps best-effort Node write fallbacks for private stores, secret writes, run logs, and media attachments on Linux/macOS. - Infra/secrets: restore the fail-closed contract for `tryReadSecretFileSync` so credential loaders that pass `rejectSymlink: true` (Telegram, LINE, Zalo, IRC, Nextcloud Talk tokens) refuse symlinked credential files instead of silently accepting them, and the infra-state CI shard's secret-file symlink test passes again. Thanks [@romneyda](https://github.com/romneyda). - Browser: honor the configured image sanitization limit for screenshots and labeled snapshots so browser-captured images follow the same resize policy as other image results. ([#84595](openclaw/openclaw#84595)) - Doctor: remove unrecognized `models.providers.*.models[*].compat.thinkingFormat` values during `doctor --fix` so stale provider model config can validate after upgrade. Fixes [#77803](openclaw/openclaw#77803). - Doctor: warn when `openclaw.json` stores plaintext secret-bearing config fields, including model provider API keys and sensitive provider headers. ([#84718](openclaw/openclaw#84718)) Thanks [@lukaIvanic](https://github.com/lukaIvanic). - Status: show the configured default, session-selected model, reason, clear hint, and docs link when a session remains pinned to a model that differs from `agents.defaults.model.primary`. - WebChat: clear stale typing indicators when session change events mark the active chat run complete. - Mac app: keep local packaging signed with a stable app identity for permission testing and fix Control UI production builds under current Vite/Highlight.js exports. - macOS app: update the embedded Peekaboo bridge to 3.2.1 so OpenClaw-hosted UI automation works with current Peekaboo CLI capture flows. - Cron: deliver preferred final assistant output for successful scheduled runs when trailing plain tool warnings remain in diagnostics instead of marking the run failed. - fix(mattermost): fail closed on missing channel type \[AI]. ([#84091](openclaw/openclaw#84091)) Thanks [@pgondhi987](https://github.com/pgondhi987). - Recheck rebuilt system.run argv \[AI]. ([#84090](openclaw/openclaw#84090)) Thanks [@pgondhi987](https://github.com/pgondhi987). - CLI: keep the private QA subcommand out of exported command descriptors unless `OPENCLAW_ENABLE_PRIVATE_QA_CLI=1`, so root help and subcommand markers match runtime registration. ([#84519](openclaw/openclaw#84519)) - CLI/cron: bound `openclaw cron show` job lookup pagination so non-advancing or unbounded `cron.list` responses fail instead of hanging the command. Fixes [#83856](openclaw/openclaw#83856). ([#83989](openclaw/openclaw#83989)) - Agents/messages: stop message-tool-only turns after a successful source-channel `message` send while keeping transcript mirrors under the session write lock. ([#84289](openclaw/openclaw#84289)) - Agents: filter silent heartbeat response-tool transcript artifacts out of embedded context snapshots so later user turns are not polluted by heartbeat no-op messages. ([#83477](openclaw/openclaw#83477)) Thanks [@fuller-stack-dev](https://github.com/fuller-stack-dev). - Agents/OpenAI: log repeated strict tool-schema downgrade diagnostics once per provider/model/tool signature, reducing duplicate debug noise while preserving `strict=false` fallback behavior. Fixes [#82930](openclaw/openclaw#82930). ([#82933](openclaw/openclaw#82933)) Thanks [@galiniliev](https://github.com/galiniliev). - Agents/code mode: spell out the `exec` tool's JavaScript/TypeScript, no Node module, and catalog-bridge constraints in model-visible schema text so agents can use enabled tools without trial-and-error. ([#84269](openclaw/openclaw#84269)) Thanks [@Kaspre](https://github.com/Kaspre). - Codex: give `image_generate` dynamic-tool calls a 120s default watchdog when no per-call or configured image timeout is set, so image generation no longer falls back to the generic 30s bridge timeout. ([#84254](openclaw/openclaw#84254)) Thanks [@moritzmmayerhofer](https://github.com/moritzmmayerhofer). - Codex: avoid duplicate dynamic tool terminal diagnostics while large diagnostic backlogs drain without blocking tool responses. ([#82937](openclaw/openclaw#82937)) Thanks [@galiniliev](https://github.com/galiniliev). - CLI/message: include a stable top-level `messageId` in `openclaw message --json` output when channel sends return one. ([#84191](openclaw/openclaw#84191)) Thanks [@100menotu001](https://github.com/100menotu001). - Cron: preserve legacy top-level array `jobs.json` stores when loading or adding scheduled jobs so old cron jobs are no longer treated as an empty store during upgrade. Fixes [#60799](openclaw/openclaw#60799). ([#84433](openclaw/openclaw#84433)) Thanks [@IWhatsskill](https://github.com/IWhatsskill). - Gateway/agents: use an agent's `identity.name` in Gateway agent summaries when `agents.list[].name` is unset, so configured agent labels remain visible in clients. ([#84355](openclaw/openclaw#84355); refs [#57835](openclaw/openclaw#57835)) Thanks [@luoyanglang](https://github.com/luoyanglang). - Channels/replies: keep normal `/verbose` failed-tool progress compact in message-tool replies and prevent late text-only tool output from appearing after the final answer. ([#84303](openclaw/openclaw#84303)) Thanks [@VACInc](https://github.com/VACInc). - Plugins/hooks: apply a default 30-second timeout to `before_compaction` and `after_compaction` hooks so a hung plugin handler no longer blocks compaction completion. ([#84153](openclaw/openclaw#84153)) - Discord: preserve disabled presentation buttons when adapting and rendering Discord message controls. ([#84188](openclaw/openclaw#84188)) Thanks [@100menotu001](https://github.com/100menotu001). - Twitch: add a test-only client-manager registry reset helper so non-isolated Twitch tests can clear cached managers between cases. Fixes [#83887](openclaw/openclaw#83887). ([#84244](openclaw/openclaw#84244)) Thanks [@hclsys](https://github.com/hclsys). - Cron: run main-session scheduled work on a cron-owned wake lane while preserving reply delivery context, so background cron turns no longer block human main-session chat. Fixes [#82766](openclaw/openclaw#82766). ([#82767](openclaw/openclaw#82767)) Thanks [@galiniliev](https://github.com/galiniliev). - Cron: use structured embedded-run denial metadata for isolated scheduled tasks so blocked exec requests fail the job without treating ordinary assistant prose as a denial. ([#84067](openclaw/openclaw#84067)) Thanks [@abnershang](https://github.com/abnershang). - Cron: keep recovered tool warnings diagnostic for successful scheduled runs so final cron output is delivered instead of being replaced by a post-processing warning. ([#84045](openclaw/openclaw#84045)) Thanks [@abnershang](https://github.com/abnershang). - Plugins/perf: thread explicit plugin discovery results through `loadBundledCapabilityRuntimeRegistry`, `resolveBundledPluginSources`, and `listChannelCatalogEntries` so callers that already hold a discovery result skip redundant filesystem walks. Thanks [@SebTardif](https://github.com/SebTardif). - harden update restart script creation \[AI]. ([#84088](openclaw/openclaw#84088)) Thanks [@pgondhi987](https://github.com/pgondhi987). - Docker: keep the bundled Codex plugin in official release image keep lists so the default OpenAI agent harness remains available after Docker pruning. Fixes [#83613](openclaw/openclaw#83613). ([#83626](openclaw/openclaw#83626)) Thanks [@YuanHanzhong](https://github.com/YuanHanzhong). - CLI/channels: preserve the first line of `openclaw channels logs` output when the rolling tail window starts exactly on a line boundary, mirroring the already-fixed `readLogSlice` behavior in `src/logging/log-tail.ts`. - Control UI: treat terminal session status as authoritative over stale active-run flags so completed terminal runs stop showing abort/live UI. ([#84057](openclaw/openclaw#84057)) - CLI: preserve embedded equals signs in inline root option values instead of truncating after the second separator. ([#83995](openclaw/openclaw#83995)) Thanks [@ThiagoCAltoe](https://github.com/ThiagoCAltoe). - Matrix/config: accept `messages.queue.byChannel.matrix` queue overrides and keep queue provider schema/type keys aligned for Matrix, Google Chat, and Mattermost. Thanks [@bdjben](https://github.com/bdjben). - CLI: format `openclaw acp client` failures through the shared error formatter so object-shaped errors stay readable instead of printing `[object Object]`. Fixes [#83904](openclaw/openclaw#83904). ([#84080](openclaw/openclaw#84080)) - Providers/Ollama: default unknown-capabilities models to tool-capable so discovered native Ollama models can use tools when `/api/show` omits capabilities. ([#84055](openclaw/openclaw#84055)) Thanks [@dutifulbob](https://github.com/dutifulbob). - Installer/Windows: launch `install.ps1` onboarding as an attached child process so fresh native Windows installs do not freeze visibly at `Starting setup...` or corrupt the wizard's terminal rendering. - CLI/update: keep restart health checks working across one-version CLI/Gateway protocol skew and use the managed Gateway service Node for all follow-up commands even when the package root is unchanged, so `openclaw update` no longer silently switches the gateway to a different Node binary when multiple Node installations are present. Thanks [@amknight](https://github.com/amknight). - CLI/gateway: include the running Gateway version in `gateway status` JSON output, preserving existing server metadata while falling back to status RPC data for read probes. Fixes [#56222](openclaw/openclaw#56222). Thanks [@galiniliev](https://github.com/galiniliev). - Memory/search: close local embedding providers when active-memory searches time out so pending local model loads and embedding contexts are aborted and released. ([#83858](openclaw/openclaw#83858)) Thanks [@brokemac79](https://github.com/brokemac79). - CLI/nodes: request pending node surface approval scopes before `openclaw nodes approve` so exec-capable node approval can use admin-scoped Gateway credentials instead of failing with `missing scope: operator.admin`. ([#84392](openclaw/openclaw#84392)) Thanks [@joshavant](https://github.com/joshavant). - Gateway: reject slow node event sends before outbound buffers grow unbounded and log the rejected payload diagnostic. ([#84387](openclaw/openclaw#84387)) Thanks [@samzong](https://github.com/samzong). - Agents: include bounded trajectory queued-writer diagnostics in `pi-trajectory-flush` timeout warnings so flush stalls show pending writes, queued bytes, and append state. Fixes [#82961](openclaw/openclaw#82961). ([#82962](openclaw/openclaw#82962)) Thanks [@galiniliev](https://github.com/galiniliev). - Agents/subagents: recover stale completion announces by retrying unsupported transcript-wait wakes without transcript waiting and forcing a message-tool handoff when the requester run is already stale. Fixes [#83699](openclaw/openclaw#83699). ([#83700](openclaw/openclaw#83700)) Thanks [@galiniliev](https://github.com/galiniliev). - Agents/subagents: constrain wildcard subagent target allowlists to configured agents while preserving explicitly listed compatibility targets. Fixes [#84040](openclaw/openclaw#84040). ([#84357](openclaw/openclaw#84357)) Thanks [@joshavant](https://github.com/joshavant). - Providers/Anthropic: route Anthropic model refs selected with Claude CLI auth through the Claude CLI runtime so shorthand refs such as `anthropic/opus-4.7` no longer fall back to embedded Anthropic billing. Fixes [#84222](openclaw/openclaw#84222). ([#84374](openclaw/openclaw#84374)) Thanks [@joshavant](https://github.com/joshavant). - Agents: honor explicit `models.providers.<id>.timeoutSeconds` values above the default idle watchdog for cloud and self-hosted providers, so long first-token waits no longer fall back at \~120s when the provider timeout is higher. ([#83979](openclaw/openclaw#83979)) Thanks [@yujiawei](https://github.com/yujiawei). - Agents/Codex: keep encrypted Responses reasoning replay provenance-bound so stale mirrored Codex transcripts drop invalid encrypted content before request assembly while preserving matching same-session replay. Fixes [#83836](openclaw/openclaw#83836). ([#84367](openclaw/openclaw#84367)) Thanks [@joshavant](https://github.com/joshavant). - Agents/subagents: skip stale embedded-run wake probes for dormant completion requesters, so late subagent completions go straight to requester-agent/direct handoff instead of producing `reason=no_active_run` queue noise. ([#82964](openclaw/openclaw#82964)) Thanks [@galiniliev](https://github.com/galiniliev). - CLI: retry config snapshot reads after a transient failure so one rejected read no longer poisons later commands in the same process. ([#83931](openclaw/openclaw#83931)) Thanks [@honor2030](https://github.com/honor2030). - Media: decode URL path basenames before using them as remote media fallback filenames, so files like `My%20Report.pdf` are surfaced as `My Report.pdf`. Fixes [#84050](openclaw/openclaw#84050). ([#84052](openclaw/openclaw#84052)) Thanks [@jbetala7](https://github.com/jbetala7). - WhatsApp: clarify inbound group diagnostics so observed but unregistered groups point to `channels.whatsapp.groups` without changing routing or sender authorization. ([#83846](openclaw/openclaw#83846)) Thanks [@neeravmakwana](https://github.com/neeravmakwana). - WhatsApp: drain pending outbound deliveries on a 30s periodic timer in addition to the reconnect handler, so messages enqueued while the provider is already connected no longer wait for the next reconnect to send. ([#79083](openclaw/openclaw#79083)) Thanks [@Oviemudiaga](https://github.com/Oviemudiaga). - CLI/TUI: include gateway plugin slash commands in TUI autocomplete, so connected sessions can suggest plugin-owned commands exposed by the running Gateway. ([#83640](openclaw/openclaw#83640)) Thanks [@se7en-agent](https://github.com/se7en-agent). - Gateway/mobile: restore QR setup-code handoff of bounded operator tokens for iOS and Android onboarding while keeping admin and pairing scopes out of bootstrap. ([#83684](openclaw/openclaw#83684)) Thanks [@ngutman](https://github.com/ngutman). - iOS: repair Release archive compilation for the TestFlight build. ([#84255](openclaw/openclaw#84255)) Thanks [@ngutman](https://github.com/ngutman). - Agents/compaction: bound plugin-owned CLI transcript compaction with the host safety timeout so a hung context engine can no longer stall post-turn cleanup. ([#84083](openclaw/openclaw#84083)) Thanks [@100yenadmin](https://github.com/100yenadmin). - Control UI/usage: truncate long context skill, tool, and file names in the usage panel while keeping the full name available on hover. ([#42197](openclaw/openclaw#42197)) Thanks [@Rain120](https://github.com/Rain120). - Codex: respect explicit `models auth order set` and `config.auth.order` precedence over stale `lastGood` in `/codex account`, and show `no working credential` when every explicit-order profile is ineligible instead of marking a lower-ranked profile as active. Fixes [#84386](openclaw/openclaw#84386). ([#84412](openclaw/openclaw#84412)) Thanks [@openperf](https://github.com/openperf). - Agents: honor `messages.suppressToolErrors` for mutating tool failures so configured chat surfaces do not receive separate warning payloads. ([#81561](openclaw/openclaw#81561)) Thanks [@moeedahmed](https://github.com/moeedahmed). - Agents/fallback: surface billing guidance for mixed rate-limit plus billing fallback exhaustion instead of generic failure copy. Fixes [#79396](openclaw/openclaw#79396). ([#79489](openclaw/openclaw#79489)) Thanks [@aayushprsingh](https://github.com/aayushprsingh). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/615

Summary: - Adds a `doctor` security warning for plaintext secret-bearing `openclaw.json` fields by reusing the secrets target registry and shared model-provider header sensitivity policy. - Reproducibility: yes. for source-level behavior: current main has plaintext secret audit coverage but no doc ... llector for those config targets, and the PR body includes live patched CLI output showing the new warning. Automerge notes: - PR branch already contained follow-up commit before automerge: Warn on plaintext secret config in doctor Validation: - ClawSweeper review passed for head 31f83aa. - Required merge gates passed before the squash merge. Prepared head SHA: 31f83aa Review: openclaw#84718 (comment) Co-authored-by: qingsenlab <qingsenlab@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>

openclaw-barnacle Bot added commands Command implementations size: S triage: needs-real-behavior-proof Candidate: external PR needs after-fix proof from a real setup. labels May 20, 2026

clawsweeper Bot added rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. and removed rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. labels May 20, 2026

lukaIvanic force-pushed the fix-doctor-plaintext-secret-warning branch 2 times, most recently from a907d43 to 03c8d7c Compare May 20, 2026 23:02

openclaw-barnacle Bot added proof: supplied External PR includes structured after-fix real behavior proof. and removed triage: needs-real-behavior-proof Candidate: external PR needs after-fix proof from a real setup. labels May 20, 2026

lukaIvanic force-pushed the fix-doctor-plaintext-secret-warning branch from 03c8d7c to 720fb5a Compare May 20, 2026 23:23

lukaIvanic requested a review from a team as a code owner May 20, 2026 23:23

openclaw-barnacle Bot added size: M and removed size: S labels May 20, 2026

openclaw-barnacle Bot removed the proof: sufficient ClawSweeper judged the real behavior proof convincing. label May 20, 2026

clawsweeper Bot added the clawsweeper:automerge Maintainer opted this PR into bounded ClawSweeper-reviewed automerge label May 21, 2026

qingsenlab and others added 2 commits May 21, 2026 00:10

Warn on plaintext secret config in doctor

8c2e534

Warn on plaintext secret config in doctor

31f83aa

clawsweeper Bot force-pushed the fix-doctor-plaintext-secret-warning branch from 720fb5a to 31f83aa Compare May 21, 2026 00:18

clawsweeper Bot added status: 🚀 automerge armed This PR is in ClawSweeper's automerge lane. and removed status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels May 21, 2026

clawsweeper Bot merged commit 9cdf8a1 into openclaw:main May 21, 2026
107 of 109 checks passed

Haderach-Ram mentioned this pull request May 21, 2026

Ecosystem Digest — 2026-05-21 Haderach-Ram/openclaw-radar#14

Open

github-actions Bot mentioned this pull request May 21, 2026

📡 Upstream Digest — 2026-05-21 02:35 UTC curtismercier/openclaw-mods#905

Open

lukaIvanic mentioned this pull request May 21, 2026

Security Roadmap: Protecting API Keys from Agent Access #11829

Open

clawsweeper Bot mentioned this pull request May 24, 2026

fix(agents): strip plaintext model provider keys #84581

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Warn on plaintext secret config in doctor#84718

Warn on plaintext secret config in doctor#84718
clawsweeper[bot] merged 2 commits into
openclaw:mainfrom
lukaIvanic:fix-doctor-plaintext-secret-warning

lukaIvanic commented May 20, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented May 20, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented May 20, 2026 •

edited

Loading

Uh oh!

lukaIvanic commented May 20, 2026

Uh oh!

clawsweeper Bot commented May 20, 2026 •

edited

Loading

Uh oh!

lukaIvanic commented May 20, 2026

Uh oh!

Takhoffman commented May 21, 2026

Uh oh!

clawsweeper Bot commented May 21, 2026 •

edited

Loading

Uh oh!

Uh oh!

lukaIvanic commented May 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

lukaIvanic commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Test

Real behavior proof

Uh oh!

clawsweeper Bot commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clawsweeper Bot commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Hatch command

Uh oh!

lukaIvanic commented May 20, 2026

Uh oh!

clawsweeper Bot commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lukaIvanic commented May 20, 2026

Uh oh!

Takhoffman commented May 21, 2026

Uh oh!

clawsweeper Bot commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

lukaIvanic commented May 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lukaIvanic commented May 20, 2026 •

edited

Loading

clawsweeper Bot commented May 20, 2026 •

edited

Loading

clawsweeper Bot commented May 20, 2026 •

edited

Loading

clawsweeper Bot commented May 20, 2026 •

edited

Loading

clawsweeper Bot commented May 21, 2026 •

edited

Loading