🐛 fix: fix scope issue by arvinxx · Pull Request #11719 · lobehub/lobehub

arvinxx · 2026-01-23T01:52:40Z

💻 Change Type

🔗 Related Issue

🔀 Description of Change

🧪 How to Test

Tested locally
Added/updated tests
No tests needed

📸 Screenshots / Videos

Before	After
...	...

📝 Additional Information

Summary by Sourcery

Bug Fixes:

Strip the scope field from the chat service response to prevent scope-related issues in downstream payload handling.

vercel · 2026-01-23T01:52:45Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
lobehub	Building	Preview, Comment	Jan 23, 2026 1:52am

sourcery-ai · 2026-01-23T01:52:48Z

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removes an unexpected scope property from the response before constructing the chat request payload to avoid leaking or misusing internal scoping information.

Sequence diagram for removing scope from chat response before payload merge

sequenceDiagram
  actor User
  participant UI as ChatUI
  participant ChatService
  participant Backend as BackendAPI

  User->>UI: Submit message
  UI->>ChatService: sendMessage(userMessage)
  ChatService->>Backend: fetchAgentChatConfig()
  Backend-->>ChatService: chatConfig

  ChatService->>Backend: createOrUpdateChat(res)
  Backend-->>ChatService: res (may contain scope)

  ChatService->>ChatService: delete res.scope
  ChatService->>ChatService: payload = merge(DEFAULT_AGENT_CONFIG, res, chatConfig)

  ChatService->>Backend: sendChatRequest(payload)
  Backend-->>ChatService: chatResponse
  ChatService-->>UI: chatResponse
  UI-->>User: Render assistant reply

File-Level Changes

Change	Details	Files
Sanitize the chat service response object by removing an unexpected `scope` property before merging into the outgoing payload.	Retrieve the current chat configuration via `agentChatConfigSelectors.currentChatConfig(getAgentStoreState())` as before. Delete the `scope` property from the `res` object using `delete (res as any).scope` immediately after obtaining the chat configuration. Continue merging the sanitized `res` object with the default agent model configuration when building the payload.	`src/services/chat/index.ts`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

gru-agent · 2026-01-23T01:52:52Z

TestGru Assignment

Summary

Link	CommitId	Status	Reason
Detail	`8b9cf06`	🚫 Skipped	No files need to be tested {"src/app/[variants]/(main)/agent/cron/[cronId]/index.tsx":"File path does not match include patterns.","src/services/chat/index.ts":"Can not find valuable test target.\nChatService: Out of scope - The exported class `ChatService` contains only methods and no logic in the constructor. According to the rules, code in service layers and classes with only methods are generally not suitable for unit testing, as their correctness often depends on integration with multipl…"}

History Assignment

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

sourcery-ai

Hey - I've left some high level feedback:

Instead of mutating res with delete (res as any).scope, consider creating a new object without scope (e.g., using destructuring) to keep the function side‑effect free and avoid unexpected changes to shared references.
The cast to any around res suggests the type definition is incomplete; it would be more robust to update the res type to include scope (possibly as optional) and then omit it in a type‑safe way.
Given that stripping scope is a non-obvious behavior, consider centralizing this into a small helper (e.g., sanitizeChatResponse) so that the intent and constraints are clearly expressed and reused consistently.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Instead of mutating `res` with `delete (res as any).scope`, consider creating a new object without `scope` (e.g., using destructuring) to keep the function side‑effect free and avoid unexpected changes to shared references.
- The cast to `any` around `res` suggests the type definition is incomplete; it would be more robust to update the `res` type to include `scope` (possibly as optional) and then omit it in a type‑safe way.
- Given that stripping `scope` is a non-obvious behavior, consider centralizing this into a small helper (e.g., `sanitizeChatResponse`) so that the intent and constraints are clearly expressed and reused consistently.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

lobehubbot · 2026-01-23T01:53:47Z

❤️ Great PR @arvinxx ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.

## [Version 2.0.0-next.343](v2.0.0-next.342...v2.0.0-next.343) <sup>Released on **2026-01-23**</sup> #### ♻ Code Refactoring - **misc**: Improve memory data with experience and identity. #### 🐛 Bug Fixes - **misc**: Fix scope issue. #### 💄 Styles - **misc**: Update share style. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### Code refactoring * **misc**: Improve memory data with experience and identity, closes [#11717](#11717) ([bdb3eb4](bdb3eb4)) #### What's fixed * **misc**: Fix scope issue, closes [#11719](#11719) ([17adde8](17adde8)) #### Styles * **misc**: Update share style, closes [#11716](#11716) ([3c70dfa](3c70dfa)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>

lobehubbot · 2026-01-23T02:13:55Z

🎉 This PR is included in version 2.0.0-next.343 🎉

The release is available on:

Your semantic-release bot 📦🚀

## [Version 1.153.0](v1.152.0...v1.153.0) <sup>Released on **2026-01-23**</sup> #### ♻ Code Refactoring - **auth**: Remove NEXT_PUBLIC_AUTH_URL env variable. - **model-select**: Migrate FunctionCallingModelSelect to LobeSelect. - **ModelSwitchPanel**: Migrate from Popover to DropdownMenu with virtual scrolling. - **userMemories**: Removed un-used code. - **misc**: Improve memory data with experience and identity, move vercel-react-best-practices skills to .agents directory. #### ✨ Features - **database**: Added user memory activity. - **desktop**: Add legacy local database detection and migration guidance. - **misc**: Add platform-aware download client menu option, add server version check for desktop app, remove Clerk authentication code, skill setting page and skill store, support agent group unpublish agents, support client tasks mode, update the sandbox preinstall libs in sys role. #### 🐛 Bug Fixes - **copilot**: Pass correct scope when creating new session in PageEditor. - **desktop**: Gracefully handle missing update manifest 404 errors. - **model-runtime**: Filter unsupported image types (SVG) before sending to vision models. - **pdf**: Upgrade pdfjs-dist and react-pdf to v5.x. - **sidebar-drawer**: Fix drawer positioning and title style. - **misc**: Fix group broadcast trigger tool use, fix local system tools, fix memory schema, fix multi agent tasks issue, fix multi tasks no summary issue, fix scope issue, fix tool argument scape and improve multi task run, fixed the sandbox tools call when error should use right callback, improve e2e server and complete i18n resources, slove the agent group editor not focus in editdata area, slove the agents header switch agents the lobeAI not show problem, sloved the old removeSessionTopics not work, TypewriterEffect not refreshing on language change, updata cron job ui & fixed commnuity pagenation goto error, update the agentbuilder tools not always use humanIntervention. #### 💄 Styles - **misc**: Improve auto scroll and group profile, update og, update share style. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### Code refactoring * **auth**: Remove NEXT_PUBLIC_AUTH_URL env variable, closes [lobehub#11658](https://github.com/jaworldwideorg/OneJA-Bot/issues/11658) ([c0f9875](c0f9875)) * **model-select**: Migrate FunctionCallingModelSelect to LobeSelect, closes [lobehub#11664](https://github.com/jaworldwideorg/OneJA-Bot/issues/11664) ([ad51305](ad51305)) * **ModelSwitchPanel**: Migrate from Popover to DropdownMenu with virtual scrolling, closes [lobehub#11663](https://github.com/jaworldwideorg/OneJA-Bot/issues/11663) ([c9d9dff](c9d9dff)) * **userMemories**: Removed un-used code, closes [lobehub#11713](https://github.com/jaworldwideorg/OneJA-Bot/issues/11713) ([89750fc](89750fc)) * **misc**: Improve memory data with experience and identity, closes [lobehub#11717](https://github.com/jaworldwideorg/OneJA-Bot/issues/11717) ([bdb3eb4](bdb3eb4)) * **misc**: Move vercel-react-best-practices skills to .agents directory, closes [lobehub#11703](https://github.com/jaworldwideorg/OneJA-Bot/issues/11703) ([6df7731](6df7731)) #### What's improved * **database**: Added user memory activity, closes [lobehub#11680](https://github.com/jaworldwideorg/OneJA-Bot/issues/11680) ([0160fbd](0160fbd)) * **desktop**: Add legacy local database detection and migration guidance, closes [lobehub#11682](https://github.com/jaworldwideorg/OneJA-Bot/issues/11682) ([5664b84](5664b84)) * **misc**: Add platform-aware download client menu option, closes [lobehub#11676](https://github.com/jaworldwideorg/OneJA-Bot/issues/11676) ([55abddc](55abddc)) * **misc**: Add server version check for desktop app, closes [lobehub#11710](https://github.com/jaworldwideorg/OneJA-Bot/issues/11710) ([0cf2723](0cf2723)) * **misc**: Remove Clerk authentication code, closes [lobehub#11711](https://github.com/jaworldwideorg/OneJA-Bot/issues/11711) ([395595a](395595a)) * **misc**: Skill setting page and skill store, closes [lobehub#11665](https://github.com/jaworldwideorg/OneJA-Bot/issues/11665) ([d8c0c26](d8c0c26)) * **misc**: Support agent group unpublish agents, closes [lobehub#11687](https://github.com/jaworldwideorg/OneJA-Bot/issues/11687) ([4e060be](4e060be)) * **misc**: Support client tasks mode, closes [lobehub#11666](https://github.com/jaworldwideorg/OneJA-Bot/issues/11666) ([98cf57b](98cf57b)) * **misc**: Update the sandbox preinstall libs in sys role, closes [lobehub#11688](https://github.com/jaworldwideorg/OneJA-Bot/issues/11688) ([404c577](404c577)) #### What's fixed * **copilot**: Pass correct scope when creating new session in PageEditor, closes [lobehub#11714](https://github.com/jaworldwideorg/OneJA-Bot/issues/11714) ([0259270](0259270)) * **desktop**: Gracefully handle missing update manifest 404 errors, closes [lobehub#11625](https://github.com/jaworldwideorg/OneJA-Bot/issues/11625) ([13e95b9](13e95b9)) * **model-runtime**: Filter unsupported image types (SVG) before sending to vision models, closes [lobehub#11698](https://github.com/jaworldwideorg/OneJA-Bot/issues/11698) ([c0c99a7](c0c99a7)) * **pdf**: Upgrade pdfjs-dist and react-pdf to v5.x, closes [lobehub#11686](https://github.com/jaworldwideorg/OneJA-Bot/issues/11686) ([2b620df](2b620df)) * **sidebar-drawer**: Fix drawer positioning and title style, closes [lobehub#11655](https://github.com/jaworldwideorg/OneJA-Bot/issues/11655) ([cf5320e](cf5320e)) * **misc**: Fix group broadcast trigger tool use, closes [lobehub#11646](https://github.com/jaworldwideorg/OneJA-Bot/issues/11646) ([831a9b3](831a9b3)) * **misc**: Fix local system tools, closes [lobehub#11702](https://github.com/jaworldwideorg/OneJA-Bot/issues/11702) ([6548fc7](6548fc7)) * **misc**: Fix memory schema, closes [lobehub#11645](https://github.com/jaworldwideorg/OneJA-Bot/issues/11645) ([3baf780](3baf780)) * **misc**: Fix multi agent tasks issue, closes [lobehub#11672](https://github.com/jaworldwideorg/OneJA-Bot/issues/11672) ([9de773b](9de773b)) * **misc**: Fix multi tasks no summary issue, closes [lobehub#11685](https://github.com/jaworldwideorg/OneJA-Bot/issues/11685) ([26ce317](26ce317)) * **misc**: Fix scope issue, closes [lobehub#11719](https://github.com/jaworldwideorg/OneJA-Bot/issues/11719) ([17adde8](17adde8)) * **misc**: Fix tool argument scape and improve multi task run, closes [lobehub#11691](https://github.com/jaworldwideorg/OneJA-Bot/issues/11691) ([b13bb8a](b13bb8a)) * **misc**: Fixed the sandbox tools call when error should use right callback, closes [lobehub#11721](https://github.com/jaworldwideorg/OneJA-Bot/issues/11721) ([e8fce68](e8fce68)) * **misc**: Improve e2e server and complete i18n resources, closes [lobehub#11678](https://github.com/jaworldwideorg/OneJA-Bot/issues/11678) ([d450dd9](d450dd9)) * **misc**: Slove the agent group editor not focus in editdata area, closes [lobehub#11677](https://github.com/jaworldwideorg/OneJA-Bot/issues/11677) ([9ac84e6](9ac84e6)) * **misc**: Slove the agents header switch agents the lobeAI not show problem, closes [lobehub#11726](https://github.com/jaworldwideorg/OneJA-Bot/issues/11726) ([f45f508](f45f508)) * **misc**: Sloved the old removeSessionTopics not work, closes [lobehub#11671](https://github.com/jaworldwideorg/OneJA-Bot/issues/11671) ([06d41e5](06d41e5)) * **misc**: TypewriterEffect not refreshing on language change, closes [lobehub#11657](https://github.com/jaworldwideorg/OneJA-Bot/issues/11657) ([ba30f46](ba30f46)) * **misc**: Updata cron job ui & fixed commnuity pagenation goto error, closes [lobehub#11700](https://github.com/jaworldwideorg/OneJA-Bot/issues/11700) ([42ad2a0](42ad2a0)) * **misc**: Update the agentbuilder tools not always use humanIntervention, closes [lobehub#11696](https://github.com/jaworldwideorg/OneJA-Bot/issues/11696) ([0d3017b](0d3017b)) #### Styles * **misc**: Improve auto scroll and group profile, closes [lobehub#11725](https://github.com/jaworldwideorg/OneJA-Bot/issues/11725) ([550acc2](550acc2)) * **misc**: Update og, closes [lobehub#11709](https://github.com/jaworldwideorg/OneJA-Bot/issues/11709) ([01cf4e4](01cf4e4)) * **misc**: Update share style, closes [lobehub#11716](https://github.com/jaworldwideorg/OneJA-Bot/issues/11716) ([3c70dfa](3c70dfa)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>

fix scope issue

8b9cf06

dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 23, 2026

dosubot bot added the 🐛 Bug label Jan 23, 2026

sourcery-ai bot reviewed Jan 23, 2026

View reviewed changes

arvinxx merged commit 17adde8 into next Jan 23, 2026
42 of 44 checks passed

arvinxx deleted the fix/scope-bug branch January 23, 2026 01:53

lobehubbot added the released on @next label Jan 23, 2026

vercel bot had a problem deploying to Preview January 23, 2026 02:37 Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

🐛 fix: fix scope issue#11719

🐛 fix: fix scope issue#11719
arvinxx merged 1 commit intonextfrom
fix/scope-bug

arvinxx commented Jan 23, 2026 •

edited by sourcery-ai bot

Loading

Uh oh!

vercel bot commented Jan 23, 2026

Uh oh!

sourcery-ai bot commented Jan 23, 2026 •

edited

Loading

Reviewer's Guide

Sequence diagram for removing scope from chat response before payload merge

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

gru-agent bot commented Jan 23, 2026 •

edited

Loading

Uh oh!

sourcery-ai bot left a comment

Uh oh!

Uh oh!

lobehubbot commented Jan 23, 2026

Uh oh!

lobehubbot commented Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

arvinxx commented Jan 23, 2026 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💻 Change Type

🔗 Related Issue

🔀 Description of Change

🧪 How to Test

📸 Screenshots / Videos

📝 Additional Information

Summary by Sourcery

Uh oh!

vercel bot commented Jan 23, 2026

Uh oh!

sourcery-ai bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

Sequence diagram for removing scope from chat response before payload merge

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

gru-agent bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TestGru Assignment

Summary

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lobehubbot commented Jan 23, 2026

Uh oh!

lobehubbot commented Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

arvinxx commented Jan 23, 2026 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Jan 23, 2026 •

edited

Loading

gru-agent bot commented Jan 23, 2026 •

edited

Loading