🐛 fix: fix local system tools by arvinxx · Pull Request #11702 · lobehub/lobehub

arvinxx · 2026-01-22T09:31:01Z

💻 Change Type

🔗 Related Issue

🔀 Description of Change

🧪 How to Test

Tested locally
Added/updated tests
No tests needed

📸 Screenshots / Videos

Before	After
...	...

📝 Additional Information

Summary by Sourcery

Bug Fixes:

Ensure the active agent ID is used when a provided agent ID is an empty string in AI chat streaming execution.

vercel · 2026-01-22T09:31:06Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
lobehub	Building	Preview, Comment	Jan 22, 2026 9:31am

sourcery-ai · 2026-01-22T09:31:07Z

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts agent ID selection in the streaming executor to correctly fall back to the active agent when a local/system tool passes an empty string as the agent ID.

Sequence diagram for agentId fallback behavior in streamingExecutor

sequenceDiagram
  participant LocalTool
  participant StreamingExecutor
  participant ChatStore

  LocalTool->>StreamingExecutor: executeStream(agentId, topicId, isSubTask)
  StreamingExecutor->>ChatStore: get()
  ChatStore-->>StreamingExecutor: activeAgentId, activeTopicId

  alt agentId is non_empty_string
    note over StreamingExecutor: paramAgentId is truthy
    StreamingExecutor->>StreamingExecutor: agentId = paramAgentId
  else agentId is empty_string_or_undefined
    note over StreamingExecutor: paramAgentId is falsy
    StreamingExecutor->>StreamingExecutor: agentId = activeAgentId
  end

  alt topicId is provided
    StreamingExecutor->>StreamingExecutor: topicId = paramTopicId
  else topicId not provided
    StreamingExecutor->>StreamingExecutor: topicId = activeTopicId
  end

  StreamingExecutor-->>LocalTool: stream initialized with agentId, topicId

File-Level Changes

Change	Details	Files
Fix agent ID fallback logic in the streaming executor so empty-string agent IDs from local/system tools correctly use the active agent.	Switch from nullish coalescing (??) to logical OR (

Possibly linked issues

#0: The PR fixes agentId fallback, which likely resolves memory tool failures in subtasks where local tools broke.

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

gru-agent · 2026-01-22T09:31:13Z

TestGru Assignment

Summary

Link	CommitId	Status	Reason
Detail	`27a07aa`	✅ Finished

History Assignment

Files

File	Pull Request
src/store/chat/slices/aiChat/actions/streamingExecutor.ts	❌ Failed (I failed to setup the environment.)

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

sourcery-ai

Hey - I've left some high level feedback:

Switching from ?? to || changes the behavior when paramAgentId is an intentionally empty string (now it will always fall back to activeAgentId); confirm that an empty string can never be a valid or intentional value before relying on this shortcut.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Switching from `??` to `||` changes the behavior when `paramAgentId` is an intentionally empty string (now it will always fall back to `activeAgentId`); confirm that an empty string can never be a valid or intentional value before relying on this shortcut.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

codecov · 2026-01-22T09:36:07Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.07%. Comparing base (de6009d) to head (27a07aa).
⚠️ Report is 14 commits behind head on next.

Additional details and impacted files

@@           Coverage Diff            @@
##             next   #11702    +/-   ##
========================================
  Coverage   74.07%   74.07%            
========================================
  Files        1188     1188            
  Lines       94668    94668            
  Branches    10429    10862   +433     
========================================
  Hits        70126    70126            
  Misses      24452    24452            
  Partials       90       90

Flag	Coverage Δ
app	`66.88% <100.00%> (ø)`
database	`93.29% <ø> (ø)`
packages/agent-runtime	`90.20% <ø> (ø)`
packages/context-engine	`85.39% <ø> (ø)`
packages/conversation-flow	`92.28% <ø> (ø)`
packages/file-loaders	`88.66% <ø> (ø)`
packages/memory-user-memory	`69.68% <ø> (ø)`
packages/model-bank	`100.00% <ø> (ø)`
packages/model-runtime	`86.70% <ø> (ø)`
packages/prompts	`79.33% <ø> (ø)`
packages/python-interpreter	`92.90% <ø> (ø)`
packages/ssrf-safe-fetch	`0.00% <ø> (ø)`
packages/utils	`93.25% <ø> (ø)`
packages/web-crawler	`95.62% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
Store	`66.80% <100.00%> (ø)`
Services	`50.55% <ø> (ø)`
Server	`67.81% <ø> (ø)`
Libs	`41.13% <ø> (ø)`
Utils	`93.82% <ø> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lobehubbot · 2026-01-22T09:43:51Z

❤️ Great PR @arvinxx ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.

## [Version 2.0.0-next.339](v2.0.0-next.338...v2.0.0-next.339) <sup>Released on **2026-01-22**</sup> #### ♻ Code Refactoring - **misc**: Move vercel-react-best-practices skills to .agents directory. #### ✨ Features - **misc**: Skill setting page and skill store. #### 🐛 Bug Fixes - **model-runtime**: Filter unsupported image types (SVG) before sending to vision models. - **misc**: Fix group broadcast trigger tool use, fix local system tools. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### Code refactoring * **misc**: Move vercel-react-best-practices skills to .agents directory, closes [#11703](#11703) ([6df7731](6df7731)) #### What's improved * **misc**: Skill setting page and skill store, closes [#11665](#11665) ([d8c0c26](d8c0c26)) #### What's fixed * **model-runtime**: Filter unsupported image types (SVG) before sending to vision models, closes [#11698](#11698) ([c0c99a7](c0c99a7)) * **misc**: Fix group broadcast trigger tool use, closes [#11646](#11646) ([831a9b3](831a9b3)) * **misc**: Fix local system tools, closes [#11702](#11702) ([6548fc7](6548fc7)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>

lobehubbot · 2026-01-22T11:43:02Z

🎉 This PR is included in version 2.0.0-next.339 🎉

The release is available on:

Your semantic-release bot 📦🚀

## [Version 1.153.0](v1.152.0...v1.153.0) <sup>Released on **2026-01-23**</sup> #### ♻ Code Refactoring - **auth**: Remove NEXT_PUBLIC_AUTH_URL env variable. - **model-select**: Migrate FunctionCallingModelSelect to LobeSelect. - **ModelSwitchPanel**: Migrate from Popover to DropdownMenu with virtual scrolling. - **userMemories**: Removed un-used code. - **misc**: Improve memory data with experience and identity, move vercel-react-best-practices skills to .agents directory. #### ✨ Features - **database**: Added user memory activity. - **desktop**: Add legacy local database detection and migration guidance. - **misc**: Add platform-aware download client menu option, add server version check for desktop app, remove Clerk authentication code, skill setting page and skill store, support agent group unpublish agents, support client tasks mode, update the sandbox preinstall libs in sys role. #### 🐛 Bug Fixes - **copilot**: Pass correct scope when creating new session in PageEditor. - **desktop**: Gracefully handle missing update manifest 404 errors. - **model-runtime**: Filter unsupported image types (SVG) before sending to vision models. - **pdf**: Upgrade pdfjs-dist and react-pdf to v5.x. - **sidebar-drawer**: Fix drawer positioning and title style. - **misc**: Fix group broadcast trigger tool use, fix local system tools, fix memory schema, fix multi agent tasks issue, fix multi tasks no summary issue, fix scope issue, fix tool argument scape and improve multi task run, fixed the sandbox tools call when error should use right callback, improve e2e server and complete i18n resources, slove the agent group editor not focus in editdata area, slove the agents header switch agents the lobeAI not show problem, sloved the old removeSessionTopics not work, TypewriterEffect not refreshing on language change, updata cron job ui & fixed commnuity pagenation goto error, update the agentbuilder tools not always use humanIntervention. #### 💄 Styles - **misc**: Improve auto scroll and group profile, update og, update share style. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### Code refactoring * **auth**: Remove NEXT_PUBLIC_AUTH_URL env variable, closes [lobehub#11658](https://github.com/jaworldwideorg/OneJA-Bot/issues/11658) ([c0f9875](c0f9875)) * **model-select**: Migrate FunctionCallingModelSelect to LobeSelect, closes [lobehub#11664](https://github.com/jaworldwideorg/OneJA-Bot/issues/11664) ([ad51305](ad51305)) * **ModelSwitchPanel**: Migrate from Popover to DropdownMenu with virtual scrolling, closes [lobehub#11663](https://github.com/jaworldwideorg/OneJA-Bot/issues/11663) ([c9d9dff](c9d9dff)) * **userMemories**: Removed un-used code, closes [lobehub#11713](https://github.com/jaworldwideorg/OneJA-Bot/issues/11713) ([89750fc](89750fc)) * **misc**: Improve memory data with experience and identity, closes [lobehub#11717](https://github.com/jaworldwideorg/OneJA-Bot/issues/11717) ([bdb3eb4](bdb3eb4)) * **misc**: Move vercel-react-best-practices skills to .agents directory, closes [lobehub#11703](https://github.com/jaworldwideorg/OneJA-Bot/issues/11703) ([6df7731](6df7731)) #### What's improved * **database**: Added user memory activity, closes [lobehub#11680](https://github.com/jaworldwideorg/OneJA-Bot/issues/11680) ([0160fbd](0160fbd)) * **desktop**: Add legacy local database detection and migration guidance, closes [lobehub#11682](https://github.com/jaworldwideorg/OneJA-Bot/issues/11682) ([5664b84](5664b84)) * **misc**: Add platform-aware download client menu option, closes [lobehub#11676](https://github.com/jaworldwideorg/OneJA-Bot/issues/11676) ([55abddc](55abddc)) * **misc**: Add server version check for desktop app, closes [lobehub#11710](https://github.com/jaworldwideorg/OneJA-Bot/issues/11710) ([0cf2723](0cf2723)) * **misc**: Remove Clerk authentication code, closes [lobehub#11711](https://github.com/jaworldwideorg/OneJA-Bot/issues/11711) ([395595a](395595a)) * **misc**: Skill setting page and skill store, closes [lobehub#11665](https://github.com/jaworldwideorg/OneJA-Bot/issues/11665) ([d8c0c26](d8c0c26)) * **misc**: Support agent group unpublish agents, closes [lobehub#11687](https://github.com/jaworldwideorg/OneJA-Bot/issues/11687) ([4e060be](4e060be)) * **misc**: Support client tasks mode, closes [lobehub#11666](https://github.com/jaworldwideorg/OneJA-Bot/issues/11666) ([98cf57b](98cf57b)) * **misc**: Update the sandbox preinstall libs in sys role, closes [lobehub#11688](https://github.com/jaworldwideorg/OneJA-Bot/issues/11688) ([404c577](404c577)) #### What's fixed * **copilot**: Pass correct scope when creating new session in PageEditor, closes [lobehub#11714](https://github.com/jaworldwideorg/OneJA-Bot/issues/11714) ([0259270](0259270)) * **desktop**: Gracefully handle missing update manifest 404 errors, closes [lobehub#11625](https://github.com/jaworldwideorg/OneJA-Bot/issues/11625) ([13e95b9](13e95b9)) * **model-runtime**: Filter unsupported image types (SVG) before sending to vision models, closes [lobehub#11698](https://github.com/jaworldwideorg/OneJA-Bot/issues/11698) ([c0c99a7](c0c99a7)) * **pdf**: Upgrade pdfjs-dist and react-pdf to v5.x, closes [lobehub#11686](https://github.com/jaworldwideorg/OneJA-Bot/issues/11686) ([2b620df](2b620df)) * **sidebar-drawer**: Fix drawer positioning and title style, closes [lobehub#11655](https://github.com/jaworldwideorg/OneJA-Bot/issues/11655) ([cf5320e](cf5320e)) * **misc**: Fix group broadcast trigger tool use, closes [lobehub#11646](https://github.com/jaworldwideorg/OneJA-Bot/issues/11646) ([831a9b3](831a9b3)) * **misc**: Fix local system tools, closes [lobehub#11702](https://github.com/jaworldwideorg/OneJA-Bot/issues/11702) ([6548fc7](6548fc7)) * **misc**: Fix memory schema, closes [lobehub#11645](https://github.com/jaworldwideorg/OneJA-Bot/issues/11645) ([3baf780](3baf780)) * **misc**: Fix multi agent tasks issue, closes [lobehub#11672](https://github.com/jaworldwideorg/OneJA-Bot/issues/11672) ([9de773b](9de773b)) * **misc**: Fix multi tasks no summary issue, closes [lobehub#11685](https://github.com/jaworldwideorg/OneJA-Bot/issues/11685) ([26ce317](26ce317)) * **misc**: Fix scope issue, closes [lobehub#11719](https://github.com/jaworldwideorg/OneJA-Bot/issues/11719) ([17adde8](17adde8)) * **misc**: Fix tool argument scape and improve multi task run, closes [lobehub#11691](https://github.com/jaworldwideorg/OneJA-Bot/issues/11691) ([b13bb8a](b13bb8a)) * **misc**: Fixed the sandbox tools call when error should use right callback, closes [lobehub#11721](https://github.com/jaworldwideorg/OneJA-Bot/issues/11721) ([e8fce68](e8fce68)) * **misc**: Improve e2e server and complete i18n resources, closes [lobehub#11678](https://github.com/jaworldwideorg/OneJA-Bot/issues/11678) ([d450dd9](d450dd9)) * **misc**: Slove the agent group editor not focus in editdata area, closes [lobehub#11677](https://github.com/jaworldwideorg/OneJA-Bot/issues/11677) ([9ac84e6](9ac84e6)) * **misc**: Slove the agents header switch agents the lobeAI not show problem, closes [lobehub#11726](https://github.com/jaworldwideorg/OneJA-Bot/issues/11726) ([f45f508](f45f508)) * **misc**: Sloved the old removeSessionTopics not work, closes [lobehub#11671](https://github.com/jaworldwideorg/OneJA-Bot/issues/11671) ([06d41e5](06d41e5)) * **misc**: TypewriterEffect not refreshing on language change, closes [lobehub#11657](https://github.com/jaworldwideorg/OneJA-Bot/issues/11657) ([ba30f46](ba30f46)) * **misc**: Updata cron job ui & fixed commnuity pagenation goto error, closes [lobehub#11700](https://github.com/jaworldwideorg/OneJA-Bot/issues/11700) ([42ad2a0](42ad2a0)) * **misc**: Update the agentbuilder tools not always use humanIntervention, closes [lobehub#11696](https://github.com/jaworldwideorg/OneJA-Bot/issues/11696) ([0d3017b](0d3017b)) #### Styles * **misc**: Improve auto scroll and group profile, closes [lobehub#11725](https://github.com/jaworldwideorg/OneJA-Bot/issues/11725) ([550acc2](550acc2)) * **misc**: Update og, closes [lobehub#11709](https://github.com/jaworldwideorg/OneJA-Bot/issues/11709) ([01cf4e4](01cf4e4)) * **misc**: Update share style, closes [lobehub#11716](https://github.com/jaworldwideorg/OneJA-Bot/issues/11716) ([3c70dfa](3c70dfa)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>

fix local system

27a07aa

dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 22, 2026

dosubot bot added the 🐛 Bug label Jan 22, 2026

sourcery-ai bot reviewed Jan 22, 2026

View reviewed changes

arvinxx merged commit 6548fc7 into next Jan 22, 2026
45 of 46 checks passed

arvinxx deleted the fix/local-system-tools branch January 22, 2026 09:43

lobehubbot added the released on @next label Jan 22, 2026

vercel bot deployed to Preview January 22, 2026 12:17 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

🐛 fix: fix local system tools#11702

🐛 fix: fix local system tools#11702
arvinxx merged 1 commit intonextfrom
fix/local-system-tools

arvinxx commented Jan 22, 2026 •

edited by sourcery-ai bot

Loading

Uh oh!

vercel bot commented Jan 22, 2026

Uh oh!

sourcery-ai bot commented Jan 22, 2026 •

edited

Loading

Reviewer's Guide

Sequence diagram for agentId fallback behavior in streamingExecutor

File-Level Changes

Possibly linked issues

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

gru-agent bot commented Jan 22, 2026 •

edited

Loading

Uh oh!

sourcery-ai bot left a comment

Uh oh!

codecov bot commented Jan 22, 2026 •

edited

Loading

Uh oh!

Uh oh!

lobehubbot commented Jan 22, 2026

Uh oh!

lobehubbot commented Jan 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

arvinxx commented Jan 22, 2026 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💻 Change Type

🔗 Related Issue

🔀 Description of Change

🧪 How to Test

📸 Screenshots / Videos

📝 Additional Information

Summary by Sourcery

Uh oh!

vercel bot commented Jan 22, 2026

Uh oh!

sourcery-ai bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

Sequence diagram for agentId fallback behavior in streamingExecutor

File-Level Changes

Possibly linked issues

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

gru-agent bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TestGru Assignment

Summary

Files

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

lobehubbot commented Jan 22, 2026

Uh oh!

lobehubbot commented Jan 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

arvinxx commented Jan 22, 2026 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Jan 22, 2026 •

edited

Loading

gru-agent bot commented Jan 22, 2026 •

edited

Loading

codecov bot commented Jan 22, 2026 •

edited

Loading