Skip to content

πŸ› fix: fix multi tasks no summary issue#11685

Merged
arvinxx merged 1 commit intonextfrom
fix/multi-tasks-stop
Jan 21, 2026
Merged

πŸ› fix: fix multi tasks no summary issue#11685
arvinxx merged 1 commit intonextfrom
fix/multi-tasks-stop

Conversation

@arvinxx
Copy link
Copy Markdown
Member

@arvinxx arvinxx commented Jan 21, 2026

πŸ’» Change Type

  • ✨ feat
  • πŸ› fix
  • ♻️ refactor
  • πŸ’„ style
  • πŸ‘· build
  • ⚑️ perf
  • βœ… test
  • πŸ“ docs
  • πŸ”¨ chore

πŸ”— Related Issue

πŸ”€ Description of Change

πŸ§ͺ How to Test

  • Tested locally
  • Added/updated tests
  • No tests needed

πŸ“Έ Screenshots / Videos

Before After
... ...

πŸ“ Additional Information

Summary by Sourcery

Ensure conversation parsing correctly includes summary messages attached to multi-task flows in the linearized output.

Bug Fixes:

  • Fix omission of non-task child messages (such as summaries) that are attached as children of task messages when building flat lists and context trees.

Tests:

  • Add fixtures and test coverage for parsing 10 parallel tasks with a summary attached as a task child.

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
lobehub Canceled Canceled Jan 21, 2026 2:01pm

Request Review

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 21, 2026
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Jan 21, 2026

Reviewer's Guide

Handles summaries attached as children of task messages in multi-task conversation flows by extending both flat list and context tree builders, and adds a regression test fixture for 10 parallel tasks with a summary message.

Class diagram for updated conversation flow builders handling task summaries

classDiagram
  class FlatListBuilder {
    - Map~string, Message~ messageMap
    - Map~string, string[]~ childrenMap
    + buildFlatListRecursive(rootId string, flatList Message[], processedIds Set~string~, allMessages Message[]): void
  }

  class ContextTreeBuilder {
    - Map~string, Message~ messageMap
    + transformToLinear(idNode IdNode, contextTree Message[]): void
  }

  class Message {
    + string id
    + string role
    + string content
  }

  class IdNode {
    + string id
    + IdNode[] children
  }

  FlatListBuilder "1" --> "many" Message : uses
  FlatListBuilder "1" --> "many" IdNode : traverses
  ContextTreeBuilder "1" --> "many" Message : uses
  ContextTreeBuilder "1" --> "many" IdNode : traverses
  IdNode "1" --> "many" IdNode : children
  Message "1" --> "0..1" Message : parent
Loading

Flow diagram for updated FlatListBuilder.buildFlatListRecursive task summary handling

flowchart TD
  A[start buildFlatListRecursive for task message] --> B[get taskChildren from childrenMap]
  B --> C[for each nonTaskChild of current message]
  C --> D{nonTaskChild not processed?}
  D -- yes --> E[push nonTaskChild to flatList]
  E --> F[mark nonTaskChild as processed]
  F --> G[recurse buildFlatListRecursive on nonTaskChild]
  D -- no --> H[skip nonTaskChild]
  G --> I[after nonTaskChildren processed]
  H --> I
  I --> J[for each taskChildId in taskChildren]
  J --> K[get taskChildrenIds from childrenMap for taskChildId]
  K --> L[for each taskGrandchildId in taskChildrenIds]
  L --> M{taskGrandchildId not processed?}
  M -- yes --> N[get taskGrandchild from messageMap]
  N --> O{taskGrandchild exists and role not task?}
  O -- yes --> P[push taskGrandchild to flatList]
  P --> Q[mark taskGrandchildId as processed]
  Q --> R[recurse buildFlatListRecursive on taskGrandchildId]
  O -- no --> S[skip taskGrandchild]
  M -- no --> T[skip already processed grandchild]
  R --> U[end loop over grandchildren]
  S --> U
  T --> U
  U --> V[end taskChildren loop and return]
Loading

File-Level Changes

Change Details Files
Extend flat list building to include non-task grandchildren of task messages so summaries attached under tasks appear in the main flow.
  • After creating the virtual tasks message, iterate over its child task messages to collect their children IDs.
  • For each grandchild of a task, if it has not been processed and its role is not 'task', push it into the flat list and recurse to include its descendants.
  • Reuse the existing processedIds guard to avoid duplicates or cycles when traversing additional descendants.
packages/conversation-flow/src/transformation/FlatListBuilder.ts
Extend context tree linearization to traverse non-task grandchildren of task messages so summaries nested under tasks are included in the linear context.
  • Identify children of the current node whose message role is 'task' after handling non-task children.
  • For each task child, iterate its children and, when the message role is not 'task', feed that grandchild into transformToLinear to append it to the context tree.
  • Ensure the traversal only adds non-task nodes, preserving tasks as virtual groupings rather than standalone context entries.
packages/conversation-flow/src/transformation/ContextTreeBuilder.ts
Add regression coverage for multi-task conversations with a summary message nested under the tasks, ensuring correct flatList structure and summary visibility.
  • Introduce a new tasks fixture multi-tasks-with-summary.json and export it via the tasks input index.
  • Add a test case that parses the multiTasksWithSummary input and asserts flatList has user, assistantGroup, tasks virtual node with 10 completed tasks, and a trailing assistant summary message.
  • Verify the summary assistant message has the expected id and content, confirming accessibility after the tasks node.
packages/conversation-flow/src/__tests__/parse.test.ts
packages/conversation-flow/src/__tests__/fixtures/inputs/tasks/index.ts
packages/conversation-flow/src/__tests__/fixtures/inputs/tasks/multi-tasks-with-summary.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@gru-agent
Copy link
Copy Markdown
Contributor

gru-agent bot commented Jan 21, 2026

TestGru Assignment

Summary

Link CommitId Status Reason
Detail 77e4d8a βœ… Finished

History Assignment

Files

File Pull Request
packages/conversation-flow/src/transformation/FlatListBuilder.ts ❌ Failed (I failed to setup the environment.)
packages/conversation-flow/src/transformation/ContextTreeBuilder.ts ❌ Failed (I failed to setup the environment.)

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

@dosubot dosubot bot added the πŸ› Bug label Jan 21, 2026
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue, and left some high level feedback:

  • The new logic in both FlatListBuilder and ContextTreeBuilder special-cases one extra level of task grandchildren; consider refactoring to a more generic descendant traversal so summaries (or other non-task descendants) are handled consistently at any depth rather than only one level under tasks.
  • In ContextTreeBuilder, task grandchildren are added without any duplicate protection, so if a summary is also reached via the existing nonTaskChildren path it may be appended twice; it might be worth ensuring each message is only linearized once.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The new logic in both FlatListBuilder and ContextTreeBuilder special-cases one extra level of task grandchildren; consider refactoring to a more generic descendant traversal so summaries (or other non-task descendants) are handled consistently at any depth rather than only one level under tasks.
- In ContextTreeBuilder, task grandchildren are added without any duplicate protection, so if a summary is also reached via the existing nonTaskChildren path it may be appended twice; it might be worth ensuring each message is only linearized once.

## Individual Comments

### Comment 1
<location> `packages/conversation-flow/src/__tests__/parse.test.ts:198-207` </location>
<code_context>
+    it('should handle 10 parallel tasks with summary as task child', () => {
</code_context>

<issue_to_address>
**suggestion (testing):** Add assertions to verify the context tree / linearized output for the summary, not just the flatList

Since this bug involved the context-tree/linearization logic (`ContextTreeBuilder`), this test should also verify the linearized output, not just the `flatList`. For example:

```ts
const serialized = serializeParseResult(result);
expect(serialized).toMatchObject({
  // expected structure for multi-tasks-with-summary
});
```

Or, like other tests here, add an `outputs.tasks.multiTasksWithSummary` fixture and assert:

```ts
expect(serializeParseResult(result)).toEqual(outputs.tasks.multiTasksWithSummary);
```

That way this case covers both the flat list and the context-tree/linearized view.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click πŸ‘ or πŸ‘Ž on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 21, 2026

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 74.07%. Comparing base (9de773b) to head (77e4d8a).
⚠️ Report is 14 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next   #11685   +/-   ##
=======================================
  Coverage   74.06%   74.07%           
=======================================
  Files        1187     1187           
  Lines       94515    94545   +30     
  Branches    10825    10833    +8     
=======================================
+ Hits        70004    70034   +30     
  Misses      24421    24421           
  Partials       90       90           
Flag Coverage Ξ”
app 66.90% <ΓΈ> (ΓΈ)
database 93.29% <ΓΈ> (ΓΈ)
packages/agent-runtime 90.20% <ΓΈ> (ΓΈ)
packages/context-engine 85.29% <ΓΈ> (ΓΈ)
packages/conversation-flow 92.53% <100.00%> (+0.15%) ⬆️
packages/file-loaders 88.66% <ΓΈ> (ΓΈ)
packages/memory-user-memory 69.75% <ΓΈ> (ΓΈ)
packages/model-bank 100.00% <ΓΈ> (ΓΈ)
packages/model-runtime 86.70% <ΓΈ> (ΓΈ)
packages/prompts 79.33% <ΓΈ> (ΓΈ)
packages/python-interpreter 92.90% <ΓΈ> (ΓΈ)
packages/ssrf-safe-fetch 0.00% <ΓΈ> (ΓΈ)
packages/utils 93.25% <ΓΈ> (ΓΈ)
packages/web-crawler 95.62% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Ξ”
Store 66.83% <ΓΈ> (ΓΈ)
Services 50.80% <ΓΈ> (ΓΈ)
Server 67.82% <ΓΈ> (ΓΈ)
Libs 41.13% <ΓΈ> (ΓΈ)
Utils 93.82% <ΓΈ> (ΓΈ)
πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arvinxx arvinxx merged commit 26ce317 into next Jan 21, 2026
44 of 46 checks passed
@arvinxx arvinxx deleted the fix/multi-tasks-stop branch January 21, 2026 14:01
@lobehubbot
Copy link
Copy Markdown
Member

❀️ Great PR @arvinxx ❀️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.

lobehubbot pushed a commit that referenced this pull request Jan 21, 2026
## [Version&nbsp;2.0.0-next.333](v2.0.0-next.332...v2.0.0-next.333)
<sup>Released on **2026-01-21**</sup>

#### ✨ Features

- **desktop**: Add legacy local database detection and migration guidance.
- **misc**: Update the sandbox preinstall libs in sys role.

#### πŸ› Bug Fixes

- **misc**: Fix multi tasks no summary issue.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's improved

* **desktop**: Add legacy local database detection and migration guidance, closes [#11682](#11682) ([5664b84](5664b84))
* **misc**: Update the sandbox preinstall libs in sys role, closes [#11688](#11688) ([404c577](404c577))

#### What's fixed

* **misc**: Fix multi tasks no summary issue, closes [#11685](#11685) ([26ce317](26ce317))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Copy Markdown
Member

πŸŽ‰ This PR is included in version 2.0.0-next.333 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

JamieStivala pushed a commit to jaworldwideorg/OneJA-Bot that referenced this pull request Jan 23, 2026
## [Version&nbsp;1.153.0](v1.152.0...v1.153.0)
<sup>Released on **2026-01-23**</sup>

#### β™» Code Refactoring

- **auth**: Remove NEXT_PUBLIC_AUTH_URL env variable.
- **model-select**: Migrate FunctionCallingModelSelect to LobeSelect.
- **ModelSwitchPanel**: Migrate from Popover to DropdownMenu with virtual scrolling.
- **userMemories**: Removed un-used code.
- **misc**: Improve memory data with experience and identity, move vercel-react-best-practices skills to .agents directory.

#### ✨ Features

- **database**: Added user memory activity.
- **desktop**: Add legacy local database detection and migration guidance.
- **misc**: Add platform-aware download client menu option, add server version check for desktop app, remove Clerk authentication code, skill setting page and skill store, support agent group unpublish agents, support client tasks mode, update the sandbox preinstall libs in sys role.

#### πŸ› Bug Fixes

- **copilot**: Pass correct scope when creating new session in PageEditor.
- **desktop**: Gracefully handle missing update manifest 404 errors.
- **model-runtime**: Filter unsupported image types (SVG) before sending to vision models.
- **pdf**: Upgrade pdfjs-dist and react-pdf to v5.x.
- **sidebar-drawer**: Fix drawer positioning and title style.
- **misc**: Fix group broadcast trigger tool use, fix local system tools, fix memory schema, fix multi agent tasks issue, fix multi tasks no summary issue, fix scope issue, fix tool argument scape and improve multi task run, fixed the sandbox tools call when error should use right callback, improve e2e server and complete i18n resources, slove the agent group editor not focus in editdata area, slove the agents header switch agents the lobeAI not show problem, sloved the old removeSessionTopics not work, TypewriterEffect not refreshing on language change, updata cron job ui & fixed commnuity pagenation goto error, update the agentbuilder tools not always use humanIntervention.

#### πŸ’„ Styles

- **misc**: Improve auto scroll and group profile, update og, update share style.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **auth**: Remove NEXT_PUBLIC_AUTH_URL env variable, closes [lobehub#11658](https://github.com/jaworldwideorg/OneJA-Bot/issues/11658) ([c0f9875](c0f9875))
* **model-select**: Migrate FunctionCallingModelSelect to LobeSelect, closes [lobehub#11664](https://github.com/jaworldwideorg/OneJA-Bot/issues/11664) ([ad51305](ad51305))
* **ModelSwitchPanel**: Migrate from Popover to DropdownMenu with virtual scrolling, closes [lobehub#11663](https://github.com/jaworldwideorg/OneJA-Bot/issues/11663) ([c9d9dff](c9d9dff))
* **userMemories**: Removed un-used code, closes [lobehub#11713](https://github.com/jaworldwideorg/OneJA-Bot/issues/11713) ([89750fc](89750fc))
* **misc**: Improve memory data with experience and identity, closes [lobehub#11717](https://github.com/jaworldwideorg/OneJA-Bot/issues/11717) ([bdb3eb4](bdb3eb4))
* **misc**: Move vercel-react-best-practices skills to .agents directory, closes [lobehub#11703](https://github.com/jaworldwideorg/OneJA-Bot/issues/11703) ([6df7731](6df7731))

#### What's improved

* **database**: Added user memory activity, closes [lobehub#11680](https://github.com/jaworldwideorg/OneJA-Bot/issues/11680) ([0160fbd](0160fbd))
* **desktop**: Add legacy local database detection and migration guidance, closes [lobehub#11682](https://github.com/jaworldwideorg/OneJA-Bot/issues/11682) ([5664b84](5664b84))
* **misc**: Add platform-aware download client menu option, closes [lobehub#11676](https://github.com/jaworldwideorg/OneJA-Bot/issues/11676) ([55abddc](55abddc))
* **misc**: Add server version check for desktop app, closes [lobehub#11710](https://github.com/jaworldwideorg/OneJA-Bot/issues/11710) ([0cf2723](0cf2723))
* **misc**: Remove Clerk authentication code, closes [lobehub#11711](https://github.com/jaworldwideorg/OneJA-Bot/issues/11711) ([395595a](395595a))
* **misc**: Skill setting page and skill store, closes [lobehub#11665](https://github.com/jaworldwideorg/OneJA-Bot/issues/11665) ([d8c0c26](d8c0c26))
* **misc**: Support agent group unpublish agents, closes [lobehub#11687](https://github.com/jaworldwideorg/OneJA-Bot/issues/11687) ([4e060be](4e060be))
* **misc**: Support client tasks mode, closes [lobehub#11666](https://github.com/jaworldwideorg/OneJA-Bot/issues/11666) ([98cf57b](98cf57b))
* **misc**: Update the sandbox preinstall libs in sys role, closes [lobehub#11688](https://github.com/jaworldwideorg/OneJA-Bot/issues/11688) ([404c577](404c577))

#### What's fixed

* **copilot**: Pass correct scope when creating new session in PageEditor, closes [lobehub#11714](https://github.com/jaworldwideorg/OneJA-Bot/issues/11714) ([0259270](0259270))
* **desktop**: Gracefully handle missing update manifest 404 errors, closes [lobehub#11625](https://github.com/jaworldwideorg/OneJA-Bot/issues/11625) ([13e95b9](13e95b9))
* **model-runtime**: Filter unsupported image types (SVG) before sending to vision models, closes [lobehub#11698](https://github.com/jaworldwideorg/OneJA-Bot/issues/11698) ([c0c99a7](c0c99a7))
* **pdf**: Upgrade pdfjs-dist and react-pdf to v5.x, closes [lobehub#11686](https://github.com/jaworldwideorg/OneJA-Bot/issues/11686) ([2b620df](2b620df))
* **sidebar-drawer**: Fix drawer positioning and title style, closes [lobehub#11655](https://github.com/jaworldwideorg/OneJA-Bot/issues/11655) ([cf5320e](cf5320e))
* **misc**: Fix group broadcast trigger tool use, closes [lobehub#11646](https://github.com/jaworldwideorg/OneJA-Bot/issues/11646) ([831a9b3](831a9b3))
* **misc**: Fix local system tools, closes [lobehub#11702](https://github.com/jaworldwideorg/OneJA-Bot/issues/11702) ([6548fc7](6548fc7))
* **misc**: Fix memory schema, closes [lobehub#11645](https://github.com/jaworldwideorg/OneJA-Bot/issues/11645) ([3baf780](3baf780))
* **misc**: Fix multi agent tasks issue, closes [lobehub#11672](https://github.com/jaworldwideorg/OneJA-Bot/issues/11672) ([9de773b](9de773b))
* **misc**: Fix multi tasks no summary issue, closes [lobehub#11685](https://github.com/jaworldwideorg/OneJA-Bot/issues/11685) ([26ce317](26ce317))
* **misc**: Fix scope issue, closes [lobehub#11719](https://github.com/jaworldwideorg/OneJA-Bot/issues/11719) ([17adde8](17adde8))
* **misc**: Fix tool argument scape and improve multi task run, closes [lobehub#11691](https://github.com/jaworldwideorg/OneJA-Bot/issues/11691) ([b13bb8a](b13bb8a))
* **misc**: Fixed the sandbox tools call when error should use right callback, closes [lobehub#11721](https://github.com/jaworldwideorg/OneJA-Bot/issues/11721) ([e8fce68](e8fce68))
* **misc**: Improve e2e server and complete i18n resources, closes [lobehub#11678](https://github.com/jaworldwideorg/OneJA-Bot/issues/11678) ([d450dd9](d450dd9))
* **misc**: Slove the agent group editor not focus in editdata area, closes [lobehub#11677](https://github.com/jaworldwideorg/OneJA-Bot/issues/11677) ([9ac84e6](9ac84e6))
* **misc**: Slove the agents header switch agents the lobeAI not show problem, closes [lobehub#11726](https://github.com/jaworldwideorg/OneJA-Bot/issues/11726) ([f45f508](f45f508))
* **misc**: Sloved the old removeSessionTopics not work, closes [lobehub#11671](https://github.com/jaworldwideorg/OneJA-Bot/issues/11671) ([06d41e5](06d41e5))
* **misc**: TypewriterEffect not refreshing on language change, closes [lobehub#11657](https://github.com/jaworldwideorg/OneJA-Bot/issues/11657) ([ba30f46](ba30f46))
* **misc**: Updata cron job ui & fixed commnuity pagenation goto error, closes [lobehub#11700](https://github.com/jaworldwideorg/OneJA-Bot/issues/11700) ([42ad2a0](42ad2a0))
* **misc**: Update the agentbuilder tools not always use humanIntervention, closes [lobehub#11696](https://github.com/jaworldwideorg/OneJA-Bot/issues/11696) ([0d3017b](0d3017b))

#### Styles

* **misc**: Improve auto scroll and group profile, closes [lobehub#11725](https://github.com/jaworldwideorg/OneJA-Bot/issues/11725) ([550acc2](550acc2))
* **misc**: Update og, closes [lobehub#11709](https://github.com/jaworldwideorg/OneJA-Bot/issues/11709) ([01cf4e4](01cf4e4))
* **misc**: Update share style, closes [lobehub#11716](https://github.com/jaworldwideorg/OneJA-Bot/issues/11716) ([3c70dfa](3c70dfa))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

πŸ› Bug released on @next size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants