π fix: updata cron job ui & fixed commnuity pagenation goto error#11700
π fix: updata cron job ui & fixed commnuity pagenation goto error#11700ONLY-yours merged 2 commits intonextfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Reviewer's GuideThis PR internationalizes the cron job weekday labels and schedule type UI, adjusts the cron save button copy, aligns Discover/community tab routing with the "agent" path segment, and adds the necessary i18n keys for the updated UI. Class diagram for cron job schedule config i18n integrationclassDiagram
class CronConfig {
<<module>>
+TIMEZONE_OPTIONS any[]
+WEEKDAY_OPTIONS any[]
+WEEKDAY_LABELS Record_number_string
}
class CronJobScheduleConfig {
<<ReactComponent>>
+scheduleType string
+weekdays number[]
+onScheduleChange scheduleChangeHandler
+buildSummary scheduleType_weekdays
+renderWeekdaySelect scheduleType_weekdays_onScheduleChange
}
class CronJobSaveButton {
<<ReactComponent>>
+disabled boolean
+loading boolean
+onSave onSaveHandler
+onSaveAsNew onSaveAsNewHandler
+renderSaveButton disabled_loading_onSave
+renderSaveAsNewButton disabled_loading_onSaveAsNew
}
class I18nSettingLocale {
<<i18nResource>>
+agentCronJobs_save string
+agentCronJobs_saveAsNew string
+agentCronJobs_schedule string
+agentCronJobs_scheduleType_daily string
+agentCronJobs_scheduleType_hourly string
+agentCronJobs_scheduleType_weekly string
+agentCronJobs_weekday_monday string
+agentCronJobs_weekday_tuesday string
+agentCronJobs_weekday_wednesday string
+agentCronJobs_weekday_thursday string
+agentCronJobs_weekday_friday string
+agentCronJobs_weekday_saturday string
+agentCronJobs_weekday_sunday string
+agentCronJobs_weekday_short_monday string
+agentCronJobs_weekday_short_tuesday string
+agentCronJobs_weekday_short_wednesday string
+agentCronJobs_weekday_short_thursday string
+agentCronJobs_weekday_short_friday string
+agentCronJobs_weekday_short_saturday string
+agentCronJobs_weekday_short_sunday string
}
class DiscoverTab {
<<enum>>
+Assistants agent
+GroupAgents group_agent
+Home home
+Mcp mcp
}
CronJobScheduleConfig --> CronConfig : uses_WEEKDAY_OPTIONS
CronJobScheduleConfig --> CronConfig : uses_WEEKDAY_LABELS
CronJobScheduleConfig --> I18nSettingLocale : uses_t_for_weekday_labels
CronJobSaveButton --> I18nSettingLocale : uses_agentCronJobs_saveAsNew
DiscoverTab .. I18nSettingLocale : independent_of_i18n
Flow diagram for community tab routing and Discover tab alignmentflowchart LR
CommunityUser["Community user
enters community page"] --> ReadPathname["Search component
reads pathname"]
ReadPathname --> ExtractTab["Extract tab segment
from pathname.split('/') [2]"]
ExtractTab -->|tab_present| ActiveTab["activeTab = extracted tab"]
ExtractTab -->|tab_missing| DefaultTab["activeTab = 'agent' (default)"]
ActiveTab --> BuildUrl["Build URL /community/ + activeTab"]
DefaultTab --> BuildUrl
BuildUrl --> RouterPush["router.push to /community/agent or other tab
with optional q query"]
subgraph DiscoverTypes
DiscoverTabEnum["DiscoverTab enum
Assistants = 'agent'
GroupAgents = 'group_agent'
Home = 'home'
Mcp = 'mcp'"]
end
RouterPush --- DiscoverTabEnum
DiscoverTabEnum --> ConsistentRouting["Consistent 'agent' segment
across Discover and Community"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
TestGru AssignmentSummary
Tip You can |
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The weekday labels and options are now i18n-aware, but the
placeholder="Select days"inCronJobScheduleConfigremains hardcoded in English; consider moving this to a translation key for consistency. - Both
WEEKDAY_OPTIONSandWEEKDAY_LABELSrequireas anycasting when passed tot(...); you could tighten their typing (e.g., using a union of translation key strings) so thattcan be called without unsafe casts.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The weekday labels and options are now i18n-aware, but the `placeholder="Select days"` in `CronJobScheduleConfig` remains hardcoded in English; consider moving this to a translation key for consistency.
- Both `WEEKDAY_OPTIONS` and `WEEKDAY_LABELS` require `as any` casting when passed to `t(...)`; you could tighten their typing (e.g., using a union of translation key strings) so that `t` can be called without unsafe casts.
## Individual Comments
### Comment 1
<location> `src/app/[variants]/(main)/agent/cron/[cronId]/features/CronJobScheduleConfig.tsx:129-133` </location>
<code_context>
mode="multiple"
onChange={(values: number[]) => onScheduleChange({ weekdays: values })}
- options={WEEKDAY_OPTIONS}
+ options={WEEKDAY_OPTIONS.map((opt) => ({
+ label: t(opt.label as any),
+ value: opt.value,
+ }))}
placeholder="Select days"
size="small"
style={{ minWidth: 150 }}
</code_context>
<issue_to_address>
**suggestion:** The weekday selector placeholder is still hardcoded English while the rest is localized.
The weekday labels now use i18n, but the `placeholder="Select days"` is still hardcoded. Please add an i18n key (e.g. `agentCronJobs.selectWeekdays`) and use `t` for the placeholder so itβs localized as well.
Suggested implementation:
```typescript
placeholder={t('agentCronJobs.selectWeekdays')}
```
Youβll also need to add the `agentCronJobs.selectWeekdays` key to your i18n translation resources (e.g. `en.json`, `de.json`, etc.) with an appropriate localized string such as `"Select days"` in English, and ensure this namespace is loaded where `t` is used in this component.
</issue_to_address>Help me be more useful! Please click π or π on each comment and I'll use the feedback to improve your reviews.
| options={WEEKDAY_OPTIONS.map((opt) => ({ | ||
| label: t(opt.label as any), | ||
| value: opt.value, | ||
| }))} | ||
| placeholder="Select days" |
There was a problem hiding this comment.
suggestion: The weekday selector placeholder is still hardcoded English while the rest is localized.
The weekday labels now use i18n, but the placeholder="Select days" is still hardcoded. Please add an i18n key (e.g. agentCronJobs.selectWeekdays) and use t for the placeholder so itβs localized as well.
Suggested implementation:
placeholder={t('agentCronJobs.selectWeekdays')}Youβll also need to add the agentCronJobs.selectWeekdays key to your i18n translation resources (e.g. en.json, de.json, etc.) with an appropriate localized string such as "Select days" in English, and ensure this namespace is loaded where t is used in this component.
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #11700 +/- ##
=======================================
Coverage 74.07% 74.07%
=======================================
Files 1188 1188
Lines 94668 94668
Branches 10429 10429
=======================================
Hits 70126 70126
Misses 24452 24452
Partials 90 90
Flags with carried forward coverage won't be shown. Click here to find out more.
π New features to boost your workflow:
|
|
β€οΈ Great PR @ONLY-yours β€οΈ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
## [Version 2.0.0-next.338](v2.0.0-next.337...v2.0.0-next.338) <sup>Released on **2026-01-22**</sup> #### π Bug Fixes - **misc**: Updata cron job ui & fixed commnuity pagenation goto error. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Updata cron job ui & fixed commnuity pagenation goto error, closes [#11700](#11700) ([42ad2a0](42ad2a0)) </details> <div align="right"> [](#readme-top) </div>
|
π This PR is included in version 2.0.0-next.338 π The release is available on: Your semantic-release bot π¦π |
## [Version 1.153.0](v1.152.0...v1.153.0) <sup>Released on **2026-01-23**</sup> #### β» Code Refactoring - **auth**: Remove NEXT_PUBLIC_AUTH_URL env variable. - **model-select**: Migrate FunctionCallingModelSelect to LobeSelect. - **ModelSwitchPanel**: Migrate from Popover to DropdownMenu with virtual scrolling. - **userMemories**: Removed un-used code. - **misc**: Improve memory data with experience and identity, move vercel-react-best-practices skills to .agents directory. #### β¨ Features - **database**: Added user memory activity. - **desktop**: Add legacy local database detection and migration guidance. - **misc**: Add platform-aware download client menu option, add server version check for desktop app, remove Clerk authentication code, skill setting page and skill store, support agent group unpublish agents, support client tasks mode, update the sandbox preinstall libs in sys role. #### π Bug Fixes - **copilot**: Pass correct scope when creating new session in PageEditor. - **desktop**: Gracefully handle missing update manifest 404 errors. - **model-runtime**: Filter unsupported image types (SVG) before sending to vision models. - **pdf**: Upgrade pdfjs-dist and react-pdf to v5.x. - **sidebar-drawer**: Fix drawer positioning and title style. - **misc**: Fix group broadcast trigger tool use, fix local system tools, fix memory schema, fix multi agent tasks issue, fix multi tasks no summary issue, fix scope issue, fix tool argument scape and improve multi task run, fixed the sandbox tools call when error should use right callback, improve e2e server and complete i18n resources, slove the agent group editor not focus in editdata area, slove the agents header switch agents the lobeAI not show problem, sloved the old removeSessionTopics not work, TypewriterEffect not refreshing on language change, updata cron job ui & fixed commnuity pagenation goto error, update the agentbuilder tools not always use humanIntervention. #### π Styles - **misc**: Improve auto scroll and group profile, update og, update share style. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### Code refactoring * **auth**: Remove NEXT_PUBLIC_AUTH_URL env variable, closes [lobehub#11658](https://github.com/jaworldwideorg/OneJA-Bot/issues/11658) ([c0f9875](c0f9875)) * **model-select**: Migrate FunctionCallingModelSelect to LobeSelect, closes [lobehub#11664](https://github.com/jaworldwideorg/OneJA-Bot/issues/11664) ([ad51305](ad51305)) * **ModelSwitchPanel**: Migrate from Popover to DropdownMenu with virtual scrolling, closes [lobehub#11663](https://github.com/jaworldwideorg/OneJA-Bot/issues/11663) ([c9d9dff](c9d9dff)) * **userMemories**: Removed un-used code, closes [lobehub#11713](https://github.com/jaworldwideorg/OneJA-Bot/issues/11713) ([89750fc](89750fc)) * **misc**: Improve memory data with experience and identity, closes [lobehub#11717](https://github.com/jaworldwideorg/OneJA-Bot/issues/11717) ([bdb3eb4](bdb3eb4)) * **misc**: Move vercel-react-best-practices skills to .agents directory, closes [lobehub#11703](https://github.com/jaworldwideorg/OneJA-Bot/issues/11703) ([6df7731](6df7731)) #### What's improved * **database**: Added user memory activity, closes [lobehub#11680](https://github.com/jaworldwideorg/OneJA-Bot/issues/11680) ([0160fbd](0160fbd)) * **desktop**: Add legacy local database detection and migration guidance, closes [lobehub#11682](https://github.com/jaworldwideorg/OneJA-Bot/issues/11682) ([5664b84](5664b84)) * **misc**: Add platform-aware download client menu option, closes [lobehub#11676](https://github.com/jaworldwideorg/OneJA-Bot/issues/11676) ([55abddc](55abddc)) * **misc**: Add server version check for desktop app, closes [lobehub#11710](https://github.com/jaworldwideorg/OneJA-Bot/issues/11710) ([0cf2723](0cf2723)) * **misc**: Remove Clerk authentication code, closes [lobehub#11711](https://github.com/jaworldwideorg/OneJA-Bot/issues/11711) ([395595a](395595a)) * **misc**: Skill setting page and skill store, closes [lobehub#11665](https://github.com/jaworldwideorg/OneJA-Bot/issues/11665) ([d8c0c26](d8c0c26)) * **misc**: Support agent group unpublish agents, closes [lobehub#11687](https://github.com/jaworldwideorg/OneJA-Bot/issues/11687) ([4e060be](4e060be)) * **misc**: Support client tasks mode, closes [lobehub#11666](https://github.com/jaworldwideorg/OneJA-Bot/issues/11666) ([98cf57b](98cf57b)) * **misc**: Update the sandbox preinstall libs in sys role, closes [lobehub#11688](https://github.com/jaworldwideorg/OneJA-Bot/issues/11688) ([404c577](404c577)) #### What's fixed * **copilot**: Pass correct scope when creating new session in PageEditor, closes [lobehub#11714](https://github.com/jaworldwideorg/OneJA-Bot/issues/11714) ([0259270](0259270)) * **desktop**: Gracefully handle missing update manifest 404 errors, closes [lobehub#11625](https://github.com/jaworldwideorg/OneJA-Bot/issues/11625) ([13e95b9](13e95b9)) * **model-runtime**: Filter unsupported image types (SVG) before sending to vision models, closes [lobehub#11698](https://github.com/jaworldwideorg/OneJA-Bot/issues/11698) ([c0c99a7](c0c99a7)) * **pdf**: Upgrade pdfjs-dist and react-pdf to v5.x, closes [lobehub#11686](https://github.com/jaworldwideorg/OneJA-Bot/issues/11686) ([2b620df](2b620df)) * **sidebar-drawer**: Fix drawer positioning and title style, closes [lobehub#11655](https://github.com/jaworldwideorg/OneJA-Bot/issues/11655) ([cf5320e](cf5320e)) * **misc**: Fix group broadcast trigger tool use, closes [lobehub#11646](https://github.com/jaworldwideorg/OneJA-Bot/issues/11646) ([831a9b3](831a9b3)) * **misc**: Fix local system tools, closes [lobehub#11702](https://github.com/jaworldwideorg/OneJA-Bot/issues/11702) ([6548fc7](6548fc7)) * **misc**: Fix memory schema, closes [lobehub#11645](https://github.com/jaworldwideorg/OneJA-Bot/issues/11645) ([3baf780](3baf780)) * **misc**: Fix multi agent tasks issue, closes [lobehub#11672](https://github.com/jaworldwideorg/OneJA-Bot/issues/11672) ([9de773b](9de773b)) * **misc**: Fix multi tasks no summary issue, closes [lobehub#11685](https://github.com/jaworldwideorg/OneJA-Bot/issues/11685) ([26ce317](26ce317)) * **misc**: Fix scope issue, closes [lobehub#11719](https://github.com/jaworldwideorg/OneJA-Bot/issues/11719) ([17adde8](17adde8)) * **misc**: Fix tool argument scape and improve multi task run, closes [lobehub#11691](https://github.com/jaworldwideorg/OneJA-Bot/issues/11691) ([b13bb8a](b13bb8a)) * **misc**: Fixed the sandbox tools call when error should use right callback, closes [lobehub#11721](https://github.com/jaworldwideorg/OneJA-Bot/issues/11721) ([e8fce68](e8fce68)) * **misc**: Improve e2e server and complete i18n resources, closes [lobehub#11678](https://github.com/jaworldwideorg/OneJA-Bot/issues/11678) ([d450dd9](d450dd9)) * **misc**: Slove the agent group editor not focus in editdata area, closes [lobehub#11677](https://github.com/jaworldwideorg/OneJA-Bot/issues/11677) ([9ac84e6](9ac84e6)) * **misc**: Slove the agents header switch agents the lobeAI not show problem, closes [lobehub#11726](https://github.com/jaworldwideorg/OneJA-Bot/issues/11726) ([f45f508](f45f508)) * **misc**: Sloved the old removeSessionTopics not work, closes [lobehub#11671](https://github.com/jaworldwideorg/OneJA-Bot/issues/11671) ([06d41e5](06d41e5)) * **misc**: TypewriterEffect not refreshing on language change, closes [lobehub#11657](https://github.com/jaworldwideorg/OneJA-Bot/issues/11657) ([ba30f46](ba30f46)) * **misc**: Updata cron job ui & fixed commnuity pagenation goto error, closes [lobehub#11700](https://github.com/jaworldwideorg/OneJA-Bot/issues/11700) ([42ad2a0](42ad2a0)) * **misc**: Update the agentbuilder tools not always use humanIntervention, closes [lobehub#11696](https://github.com/jaworldwideorg/OneJA-Bot/issues/11696) ([0d3017b](0d3017b)) #### Styles * **misc**: Improve auto scroll and group profile, closes [lobehub#11725](https://github.com/jaworldwideorg/OneJA-Bot/issues/11725) ([550acc2](550acc2)) * **misc**: Update og, closes [lobehub#11709](https://github.com/jaworldwideorg/OneJA-Bot/issues/11709) ([01cf4e4](01cf4e4)) * **misc**: Update share style, closes [lobehub#11716](https://github.com/jaworldwideorg/OneJA-Bot/issues/11716) ([3c70dfa](3c70dfa)) </details> <div align="right"> [](#readme-top) </div>
π» Change Type
π Related Issue
π Description of Change
π§ͺ How to Test
πΈ Screenshots / Videos
π Additional Information
Summary by Sourcery
Improve cron job scheduling UI internationalization and fix community pagination/search tab defaults.
Bug Fixes:
Enhancements: