π fix: improve e2e server and complete i18n resources#11678
Merged
Conversation
- Refactor webServer.ts with better process coordination and lock file mechanism - Add mock S3 env vars to prevent initialization errors - Complete missing i18n translations across all locales
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Reviewer's GuideRefactors the E2E web server helper to use a more robust spawn-based process model with connection-based readiness checks, better error/lock handling, mock S3/env configuration, and completes missing i18n translations across all supported locales for several feature namespaces. Sequence diagram for improved E2E web server startup and shutdownsequenceDiagram
actor E2EWorker
participant WebServerHelper as WebServerHelper(startWebServer)
participant FileSystem as FileSystem(LOCK_FILE)
participant NodeProcess as NodeChildProcess(spawn)
participant AppServer as AppServer
E2EWorker->>WebServerHelper: startWebServer(command, env, port, timeout)
WebServerHelper->>FileSystem: check LOCK_FILE
alt lock file does not exist
WebServerHelper->>FileSystem: create LOCK_FILE
else lock file exists
WebServerHelper-->>E2EWorker: wait for existing server (poll isServerRunning)
end
WebServerHelper->>NodeProcess: spawn(command, env: serverEnv)
NodeProcess-->>WebServerHelper: ChildProcess handle
WebServerHelper->>NodeProcess: attach stdout/stderr listeners
WebServerHelper->>NodeProcess: attach error and exit listeners
loop until server ready or timeout
WebServerHelper->>AppServer: isServerRunning(port)
AppServer-->>WebServerHelper: running? (true/false)
alt startupError set by NodeProcess
WebServerHelper-->>E2EWorker: throw startupError
WebServerHelper->>FileSystem: delete LOCK_FILE
WebServerHelper->>WebServerHelper: stopWebServer()
end
end
alt server ready before timeout
WebServerHelper->>FileSystem: delete LOCK_FILE
WebServerHelper-->>E2EWorker: resolve serverStartPromise
else timeout exceeded
WebServerHelper-->>E2EWorker: throw Error("Server failed to start within timeout")
WebServerHelper->>FileSystem: delete LOCK_FILE
WebServerHelper->>WebServerHelper: stopWebServer()
end
E2EWorker->>WebServerHelper: stopWebServer() (after tests)
WebServerHelper->>NodeProcess: kill()
WebServerHelper->>FileSystem: delete LOCK_FILE
NodeProcess-->>WebServerHelper: process exited
Note over WebServerHelper,NodeProcess: process.on(exit) also invokes stopWebServer() for cleanup
Sequence diagram for new connection-based server readiness checksequenceDiagram
participant WebServerHelper as WebServerHelper(isServerRunning)
participant Env as ProcessEnv
participant Net as NodeNet(connect)
participant Socket as TcpSocket
participant Caller
WebServerHelper->>Env: read HOST
Env-->>WebServerHelper: HOST value
WebServerHelper->>WebServerHelper: build hosts set {127.0.0.1, ::1, localhost, HOST?}
loop for each host in hosts
WebServerHelper->>Net: connect({host, port})
Net-->>Socket: TcpSocket
WebServerHelper->>Socket: set timeout(timeoutMs)
alt connection succeeds
Socket-->>WebServerHelper: connect event
WebServerHelper->>Socket: destroy()
WebServerHelper-->>WebServerHelper: resolve true
else connection fails or times out
Socket-->>WebServerHelper: error or timeout
WebServerHelper->>Socket: destroy()
WebServerHelper-->>WebServerHelper: resolve false for this host
end
end
alt any host succeeded
WebServerHelper-->>Caller: true (server running)
else all hosts failed
WebServerHelper-->>Caller: false (server not running)
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
|
There is too much information in the pull request to test. |
Contributor
There was a problem hiding this comment.
Hey - I've found 1 security issue, and left some high level feedback:
Security issues:
- Detected a Generic API Key, potentially exposing access to various services and sensitive operations. (link)
General comments:
- The
process.on('exit', () => void stopWebServer())handler never awaits the async cleanup, so the process may exit before the server is killed or the lock file is removed; consider using synchronous cleanup there or handlingbeforeExit/SIGINT/SIGTERMexplicitly for more reliable teardown. - In the
startWebServererror path you callunlinkSync(LOCK_FILE)and thenstopWebServer(), which also doesunlinkSync(LOCK_FILE); it would be cleaner to centralize lock-file cleanup in one place to avoid duplicate work and potential race conditions. - The switch to
spawn(command, { shell: true, ... })with a single command string ties behavior to the shell and can differ across platforms; consider splitting the command intofileandargs(and droppingshell: trueif possible) or documenting that this must be a valid shell command for the target environment.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `process.on('exit', () => void stopWebServer())` handler never awaits the async cleanup, so the process may exit before the server is killed or the lock file is removed; consider using synchronous cleanup there or handling `beforeExit`/`SIGINT`/`SIGTERM` explicitly for more reliable teardown.
- In the `startWebServer` error path you call `unlinkSync(LOCK_FILE)` and then `stopWebServer()`, which also does `unlinkSync(LOCK_FILE)`; it would be cleaner to centralize lock-file cleanup in one place to avoid duplicate work and potential race conditions.
- The switch to `spawn(command, { shell: true, ... })` with a single command string ties behavior to the shell and can differ across platforms; consider splitting the command into `file` and `args` (and dropping `shell: true` if possible) or documenting that this must be a valid shell command for the target environment.
## Individual Comments
### Comment 1
<location> `e2e/src/support/webServer.ts:138` </location>
<code_context>
LA7n9k3JdEcbSgml2sxfw+4TV1AzaaFU5+R176aQz4s=
</code_context>
<issue_to_address>
**security (generic-api-key):** Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
*Source: gitleaks*
</issue_to_address>Help me be more useful! Please click π or π on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 81900df160
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+42
to
+46
| const tryConnect = (host: string) => | ||
| new Promise<boolean>((resolve) => { | ||
| const socket = connect({ host, port }); | ||
| const timeoutId = setTimeout(() => { | ||
| socket.destroy(); |
There was a problem hiding this comment.
Verify HTTP readiness before reusing port
The new isServerRunning only attempts a raw TCP connection (node:net connect) to decide if the server is βready.β This will return true for any process that happens to be listening on the port (including a stale/other service), or for a Next.js server that has opened the socket but isnβt yet serving routes like /chat. In those cases startWebServer will skip starting the correct app or let tests proceed too early, leading to E2E runs against the wrong server or intermittent failures. Consider restoring an HTTP check for a known route (as before) or validating an expected response before reusing the port.
Useful? React with πΒ / π.
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #11678 +/- ##
=======================================
Coverage 74.06% 74.06%
=======================================
Files 1187 1187
Lines 94521 94521
Branches 12426 12426
=======================================
Hits 70004 70004
Misses 24427 24427
Partials 90 90
Flags with carried forward coverage won't be shown. Click here to find out more.
π New features to boost your workflow:
|
Member
|
β€οΈ Great PR @Innei β€οΈ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
lobehubbot
pushed a commit
that referenced
this pull request
Jan 21, 2026
## [Version 2.0.0-next.332](v2.0.0-next.331...v2.0.0-next.332) <sup>Released on **2026-01-21**</sup> #### π Bug Fixes - **misc**: Improve e2e server and complete i18n resources. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Improve e2e server and complete i18n resources, closes [#11678](#11678) ([d450dd9](d450dd9)) </details> <div align="right"> [](#readme-top) </div>
Member
|
π This PR is included in version 2.0.0-next.332 π The release is available on: Your semantic-release bot π¦π |
JamieStivala
pushed a commit
to jaworldwideorg/OneJA-Bot
that referenced
this pull request
Jan 23, 2026
## [Version 1.153.0](v1.152.0...v1.153.0) <sup>Released on **2026-01-23**</sup> #### β» Code Refactoring - **auth**: Remove NEXT_PUBLIC_AUTH_URL env variable. - **model-select**: Migrate FunctionCallingModelSelect to LobeSelect. - **ModelSwitchPanel**: Migrate from Popover to DropdownMenu with virtual scrolling. - **userMemories**: Removed un-used code. - **misc**: Improve memory data with experience and identity, move vercel-react-best-practices skills to .agents directory. #### β¨ Features - **database**: Added user memory activity. - **desktop**: Add legacy local database detection and migration guidance. - **misc**: Add platform-aware download client menu option, add server version check for desktop app, remove Clerk authentication code, skill setting page and skill store, support agent group unpublish agents, support client tasks mode, update the sandbox preinstall libs in sys role. #### π Bug Fixes - **copilot**: Pass correct scope when creating new session in PageEditor. - **desktop**: Gracefully handle missing update manifest 404 errors. - **model-runtime**: Filter unsupported image types (SVG) before sending to vision models. - **pdf**: Upgrade pdfjs-dist and react-pdf to v5.x. - **sidebar-drawer**: Fix drawer positioning and title style. - **misc**: Fix group broadcast trigger tool use, fix local system tools, fix memory schema, fix multi agent tasks issue, fix multi tasks no summary issue, fix scope issue, fix tool argument scape and improve multi task run, fixed the sandbox tools call when error should use right callback, improve e2e server and complete i18n resources, slove the agent group editor not focus in editdata area, slove the agents header switch agents the lobeAI not show problem, sloved the old removeSessionTopics not work, TypewriterEffect not refreshing on language change, updata cron job ui & fixed commnuity pagenation goto error, update the agentbuilder tools not always use humanIntervention. #### π Styles - **misc**: Improve auto scroll and group profile, update og, update share style. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### Code refactoring * **auth**: Remove NEXT_PUBLIC_AUTH_URL env variable, closes [lobehub#11658](https://github.com/jaworldwideorg/OneJA-Bot/issues/11658) ([c0f9875](c0f9875)) * **model-select**: Migrate FunctionCallingModelSelect to LobeSelect, closes [lobehub#11664](https://github.com/jaworldwideorg/OneJA-Bot/issues/11664) ([ad51305](ad51305)) * **ModelSwitchPanel**: Migrate from Popover to DropdownMenu with virtual scrolling, closes [lobehub#11663](https://github.com/jaworldwideorg/OneJA-Bot/issues/11663) ([c9d9dff](c9d9dff)) * **userMemories**: Removed un-used code, closes [lobehub#11713](https://github.com/jaworldwideorg/OneJA-Bot/issues/11713) ([89750fc](89750fc)) * **misc**: Improve memory data with experience and identity, closes [lobehub#11717](https://github.com/jaworldwideorg/OneJA-Bot/issues/11717) ([bdb3eb4](bdb3eb4)) * **misc**: Move vercel-react-best-practices skills to .agents directory, closes [lobehub#11703](https://github.com/jaworldwideorg/OneJA-Bot/issues/11703) ([6df7731](6df7731)) #### What's improved * **database**: Added user memory activity, closes [lobehub#11680](https://github.com/jaworldwideorg/OneJA-Bot/issues/11680) ([0160fbd](0160fbd)) * **desktop**: Add legacy local database detection and migration guidance, closes [lobehub#11682](https://github.com/jaworldwideorg/OneJA-Bot/issues/11682) ([5664b84](5664b84)) * **misc**: Add platform-aware download client menu option, closes [lobehub#11676](https://github.com/jaworldwideorg/OneJA-Bot/issues/11676) ([55abddc](55abddc)) * **misc**: Add server version check for desktop app, closes [lobehub#11710](https://github.com/jaworldwideorg/OneJA-Bot/issues/11710) ([0cf2723](0cf2723)) * **misc**: Remove Clerk authentication code, closes [lobehub#11711](https://github.com/jaworldwideorg/OneJA-Bot/issues/11711) ([395595a](395595a)) * **misc**: Skill setting page and skill store, closes [lobehub#11665](https://github.com/jaworldwideorg/OneJA-Bot/issues/11665) ([d8c0c26](d8c0c26)) * **misc**: Support agent group unpublish agents, closes [lobehub#11687](https://github.com/jaworldwideorg/OneJA-Bot/issues/11687) ([4e060be](4e060be)) * **misc**: Support client tasks mode, closes [lobehub#11666](https://github.com/jaworldwideorg/OneJA-Bot/issues/11666) ([98cf57b](98cf57b)) * **misc**: Update the sandbox preinstall libs in sys role, closes [lobehub#11688](https://github.com/jaworldwideorg/OneJA-Bot/issues/11688) ([404c577](404c577)) #### What's fixed * **copilot**: Pass correct scope when creating new session in PageEditor, closes [lobehub#11714](https://github.com/jaworldwideorg/OneJA-Bot/issues/11714) ([0259270](0259270)) * **desktop**: Gracefully handle missing update manifest 404 errors, closes [lobehub#11625](https://github.com/jaworldwideorg/OneJA-Bot/issues/11625) ([13e95b9](13e95b9)) * **model-runtime**: Filter unsupported image types (SVG) before sending to vision models, closes [lobehub#11698](https://github.com/jaworldwideorg/OneJA-Bot/issues/11698) ([c0c99a7](c0c99a7)) * **pdf**: Upgrade pdfjs-dist and react-pdf to v5.x, closes [lobehub#11686](https://github.com/jaworldwideorg/OneJA-Bot/issues/11686) ([2b620df](2b620df)) * **sidebar-drawer**: Fix drawer positioning and title style, closes [lobehub#11655](https://github.com/jaworldwideorg/OneJA-Bot/issues/11655) ([cf5320e](cf5320e)) * **misc**: Fix group broadcast trigger tool use, closes [lobehub#11646](https://github.com/jaworldwideorg/OneJA-Bot/issues/11646) ([831a9b3](831a9b3)) * **misc**: Fix local system tools, closes [lobehub#11702](https://github.com/jaworldwideorg/OneJA-Bot/issues/11702) ([6548fc7](6548fc7)) * **misc**: Fix memory schema, closes [lobehub#11645](https://github.com/jaworldwideorg/OneJA-Bot/issues/11645) ([3baf780](3baf780)) * **misc**: Fix multi agent tasks issue, closes [lobehub#11672](https://github.com/jaworldwideorg/OneJA-Bot/issues/11672) ([9de773b](9de773b)) * **misc**: Fix multi tasks no summary issue, closes [lobehub#11685](https://github.com/jaworldwideorg/OneJA-Bot/issues/11685) ([26ce317](26ce317)) * **misc**: Fix scope issue, closes [lobehub#11719](https://github.com/jaworldwideorg/OneJA-Bot/issues/11719) ([17adde8](17adde8)) * **misc**: Fix tool argument scape and improve multi task run, closes [lobehub#11691](https://github.com/jaworldwideorg/OneJA-Bot/issues/11691) ([b13bb8a](b13bb8a)) * **misc**: Fixed the sandbox tools call when error should use right callback, closes [lobehub#11721](https://github.com/jaworldwideorg/OneJA-Bot/issues/11721) ([e8fce68](e8fce68)) * **misc**: Improve e2e server and complete i18n resources, closes [lobehub#11678](https://github.com/jaworldwideorg/OneJA-Bot/issues/11678) ([d450dd9](d450dd9)) * **misc**: Slove the agent group editor not focus in editdata area, closes [lobehub#11677](https://github.com/jaworldwideorg/OneJA-Bot/issues/11677) ([9ac84e6](9ac84e6)) * **misc**: Slove the agents header switch agents the lobeAI not show problem, closes [lobehub#11726](https://github.com/jaworldwideorg/OneJA-Bot/issues/11726) ([f45f508](f45f508)) * **misc**: Sloved the old removeSessionTopics not work, closes [lobehub#11671](https://github.com/jaworldwideorg/OneJA-Bot/issues/11671) ([06d41e5](06d41e5)) * **misc**: TypewriterEffect not refreshing on language change, closes [lobehub#11657](https://github.com/jaworldwideorg/OneJA-Bot/issues/11657) ([ba30f46](ba30f46)) * **misc**: Updata cron job ui & fixed commnuity pagenation goto error, closes [lobehub#11700](https://github.com/jaworldwideorg/OneJA-Bot/issues/11700) ([42ad2a0](42ad2a0)) * **misc**: Update the agentbuilder tools not always use humanIntervention, closes [lobehub#11696](https://github.com/jaworldwideorg/OneJA-Bot/issues/11696) ([0d3017b](0d3017b)) #### Styles * **misc**: Improve auto scroll and group profile, closes [lobehub#11725](https://github.com/jaworldwideorg/OneJA-Bot/issues/11725) ([550acc2](550acc2)) * **misc**: Update og, closes [lobehub#11709](https://github.com/jaworldwideorg/OneJA-Bot/issues/11709) ([01cf4e4](01cf4e4)) * **misc**: Update share style, closes [lobehub#11716](https://github.com/jaworldwideorg/OneJA-Bot/issues/11716) ([3c70dfa](3c70dfa)) </details> <div align="right"> [](#readme-top) </div>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
π» Change Type
π Related Issue
π Description of Change
E2E Server Improvements:
webServer.tswith better process coordination using file-based lock mechanismstopWebServer()function beforestartWebServer()to fix ESLint no-use-before-define errori18n Resources:
π§ͺ How to Test
πΈ Screenshots / Videos
π Additional Information
This PR fixes E2E test infrastructure issues and ensures i18n resources are complete for all supported locales.
Summary by Sourcery
Improve E2E test web server reliability and complete missing i18n resources across all supported locales.
Bug Fixes:
Enhancements:
Documentation: