✨ feat: add platform-aware download client menu option#11676
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Reviewer's GuideImplements a platform-aware "Download Client" entry in both the mobile home features and user panel menus, replacing PWA install logic with platform-specific download URLs and updating platform detection and localization accordingly. Sequence diagram for platform-aware download client selectionsequenceDiagram
actor User
participant MobileHome as MobileHomeFeatures_useCategory
participant Platform as usePlatform
participant Const as DOWNLOAD_URL
participant Browser
User->>MobileHome: Tap Download Client menu item
MobileHome->>Platform: usePlatform()
Platform-->>MobileHome: isIOS, isAndroid, isDesktop
MobileHome->>Const: Read DOWNLOAD_URL
Const-->>MobileHome: ios, android, default URLs
MobileHome->>MobileHome: Compute downloadUrl via useMemo
MobileHome->>Browser: window.open(downloadUrl, __blank)
Browser-->>User: Opens platform specific store or download page
Sequence diagram for platform-aware download client in user panel menusequenceDiagram
actor User
participant UserPanel as UserPanel_useMenu
participant Platform as usePlatform
participant Const as DOWNLOAD_URL
participant Browser
User->>UserPanel: Open user panel
UserPanel->>Platform: usePlatform()
Platform-->>UserPanel: isIOS, isAndroid, isDesktop
UserPanel->>Const: Read DOWNLOAD_URL
Const-->>UserPanel: ios, android, default URLs
UserPanel->>UserPanel: Compute downloadUrl via useMemo
alt Desktop
UserPanel-->>User: Download Client item hidden
else Mobile or Tablet
UserPanel-->>User: Show Download Client menu item
User->>UserPanel: Click Download Client
UserPanel->>Browser: Open link with target _blank
Browser-->>User: Opens platform specific store or download page
end
Updated class diagram for platform and download client menu logicclassDiagram
class UsePlatformHook {
+boolean isAndroid
+boolean isApple
+boolean isArc
+boolean isChrome
+boolean isDesktop
+boolean isElectron
+boolean isMobile
+boolean isSafari
+boolean isWeChat
+boolean isWeCom
+boolean isWeWork
+boolean isWindows
+boolean isMacOS
+boolean isIOS
+object platformInfo
}
class DownloadUrlConst {
+string android
+string ios
+string default
}
class UseCategoryHook {
+CellProps[] profile
+CellProps[] support
+CellProps[] helps
+CellProps[] downloadClient
+CellProps[] list
+function useCategory(onOpenChangelogModal)
-string downloadUrl
}
class UseMenuHook {
+MenuItem[] settings
+MenuItem[] businessMenuItems
+MenuItem[] data
+MenuItem[] helps
+MenuItem[] downloadClient
+MenuItem[] items
+function useMenu()
-string downloadUrl
}
UseCategoryHook --> UsePlatformHook : uses
UseCategoryHook --> DownloadUrlConst : reads
UseMenuHook --> UsePlatformHook : uses
UseMenuHook --> DownloadUrlConst : reads
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've found 2 issues, and left some high level feedback:
- The platform-specific
downloadUrlselection logic is duplicated in bothuseCategoryanduseMenu; consider extracting this into a shared helper (e.g., agetDownloadUrlfunction or hook) to keep the logic in one place. - In
useCategory,window.open(downloadUrl, '__blank')uses a non-standard target name ('__blank'); if the intent is to open a new tab/window, this should be'_blank'and ideally paired withrel="noopener,noreferrer"for consistency with the user panel link.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The platform-specific `downloadUrl` selection logic is duplicated in both `useCategory` and `useMenu`; consider extracting this into a shared helper (e.g., a `getDownloadUrl` function or hook) to keep the logic in one place.
- In `useCategory`, `window.open(downloadUrl, '__blank')` uses a non-standard target name (`'__blank'`); if the intent is to open a new tab/window, this should be `'_blank'` and ideally paired with `rel="noopener,noreferrer"` for consistency with the user panel link.
## Individual Comments
### Comment 1
<location> `src/app/[variants]/(mobile)/me/(home)/features/useCategory.tsx:62` </location>
<code_context>
- onClick: () => install(),
+ key: 'download-client',
+ label: t('downloadClient'),
+ onClick: () => window.open(downloadUrl, '__blank'),
},
{
</code_context>
<issue_to_address>
**issue (bug_risk):** Use the standard `'_blank'` target instead of `'__blank'` in `window.open`.
`'__blank'` is treated as a named window, so subsequent calls will reuse the same tab instead of opening a new one, and it won’t match the behavior of the `<a target="_blank">` in `useMenu`. Please change this to `window.open(downloadUrl, '_blank')`. You may also want to pass `'noopener,noreferrer'` as the third argument to match the anchor’s security behavior.
</issue_to_address>
### Comment 2
<location> `src/features/User/UserPanel/useMenu.tsx:57-61` </location>
<code_context>
const [isLoginWithAuth] = useUserStore((s) => [authSelectors.isLoginWithAuth(s)]);
+ const { isIOS, isAndroid } = usePlatform();
+
+ const downloadUrl = useMemo(() => {
+ if (isIOS) return DOWNLOAD_URL.ios;
+ if (isAndroid) return DOWNLOAD_URL.android;
+ return DOWNLOAD_URL.default;
+ }, [isIOS, isAndroid]);
const profile: CellProps[] = [
</code_context>
<issue_to_address>
**suggestion:** The `downloadUrl` logic could be shared to avoid duplication and ensure consistent behavior.
A nearly identical `downloadUrl` memoization now appears in both `useCategory` and `useMenu`. Duplicating this platform-dependent URL logic makes future changes (e.g., new platforms or rules) harder and more error-prone. Extract a shared helper (hook or pure function) that computes the URL from `usePlatform()` so both callers use the same implementation.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #11676 +/- ##
=========================================
Coverage 74.06% 74.06%
=========================================
Files 1187 1187
Lines 94549 94564 +15
Branches 10833 12870 +2037
=========================================
+ Hits 70030 70042 +12
- Misses 24429 24432 +3
Partials 90 90
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Signed-off-by: Innei <tukon479@gmail.com>
Member
|
❤️ Great PR @Innei ❤️ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
lobehubbot
pushed a commit
that referenced
this pull request
Jan 21, 2026
## [Version 2.0.0-next.334](v2.0.0-next.333...v2.0.0-next.334) <sup>Released on **2026-01-21**</sup> #### ✨ Features - **misc**: Add platform-aware download client menu option. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's improved * **misc**: Add platform-aware download client menu option, closes [#11676](#11676) ([55abddc](55abddc)) </details> <div align="right"> [](#readme-top) </div>
Member
|
🎉 This PR is included in version 2.0.0-next.334 🎉 The release is available on: Your semantic-release bot 📦🚀 |
JamieStivala
pushed a commit
to jaworldwideorg/OneJA-Bot
that referenced
this pull request
Jan 23, 2026
## [Version 1.153.0](v1.152.0...v1.153.0) <sup>Released on **2026-01-23**</sup> #### ♻ Code Refactoring - **auth**: Remove NEXT_PUBLIC_AUTH_URL env variable. - **model-select**: Migrate FunctionCallingModelSelect to LobeSelect. - **ModelSwitchPanel**: Migrate from Popover to DropdownMenu with virtual scrolling. - **userMemories**: Removed un-used code. - **misc**: Improve memory data with experience and identity, move vercel-react-best-practices skills to .agents directory. #### ✨ Features - **database**: Added user memory activity. - **desktop**: Add legacy local database detection and migration guidance. - **misc**: Add platform-aware download client menu option, add server version check for desktop app, remove Clerk authentication code, skill setting page and skill store, support agent group unpublish agents, support client tasks mode, update the sandbox preinstall libs in sys role. #### 🐛 Bug Fixes - **copilot**: Pass correct scope when creating new session in PageEditor. - **desktop**: Gracefully handle missing update manifest 404 errors. - **model-runtime**: Filter unsupported image types (SVG) before sending to vision models. - **pdf**: Upgrade pdfjs-dist and react-pdf to v5.x. - **sidebar-drawer**: Fix drawer positioning and title style. - **misc**: Fix group broadcast trigger tool use, fix local system tools, fix memory schema, fix multi agent tasks issue, fix multi tasks no summary issue, fix scope issue, fix tool argument scape and improve multi task run, fixed the sandbox tools call when error should use right callback, improve e2e server and complete i18n resources, slove the agent group editor not focus in editdata area, slove the agents header switch agents the lobeAI not show problem, sloved the old removeSessionTopics not work, TypewriterEffect not refreshing on language change, updata cron job ui & fixed commnuity pagenation goto error, update the agentbuilder tools not always use humanIntervention. #### 💄 Styles - **misc**: Improve auto scroll and group profile, update og, update share style. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### Code refactoring * **auth**: Remove NEXT_PUBLIC_AUTH_URL env variable, closes [lobehub#11658](https://github.com/jaworldwideorg/OneJA-Bot/issues/11658) ([c0f9875](c0f9875)) * **model-select**: Migrate FunctionCallingModelSelect to LobeSelect, closes [lobehub#11664](https://github.com/jaworldwideorg/OneJA-Bot/issues/11664) ([ad51305](ad51305)) * **ModelSwitchPanel**: Migrate from Popover to DropdownMenu with virtual scrolling, closes [lobehub#11663](https://github.com/jaworldwideorg/OneJA-Bot/issues/11663) ([c9d9dff](c9d9dff)) * **userMemories**: Removed un-used code, closes [lobehub#11713](https://github.com/jaworldwideorg/OneJA-Bot/issues/11713) ([89750fc](89750fc)) * **misc**: Improve memory data with experience and identity, closes [lobehub#11717](https://github.com/jaworldwideorg/OneJA-Bot/issues/11717) ([bdb3eb4](bdb3eb4)) * **misc**: Move vercel-react-best-practices skills to .agents directory, closes [lobehub#11703](https://github.com/jaworldwideorg/OneJA-Bot/issues/11703) ([6df7731](6df7731)) #### What's improved * **database**: Added user memory activity, closes [lobehub#11680](https://github.com/jaworldwideorg/OneJA-Bot/issues/11680) ([0160fbd](0160fbd)) * **desktop**: Add legacy local database detection and migration guidance, closes [lobehub#11682](https://github.com/jaworldwideorg/OneJA-Bot/issues/11682) ([5664b84](5664b84)) * **misc**: Add platform-aware download client menu option, closes [lobehub#11676](https://github.com/jaworldwideorg/OneJA-Bot/issues/11676) ([55abddc](55abddc)) * **misc**: Add server version check for desktop app, closes [lobehub#11710](https://github.com/jaworldwideorg/OneJA-Bot/issues/11710) ([0cf2723](0cf2723)) * **misc**: Remove Clerk authentication code, closes [lobehub#11711](https://github.com/jaworldwideorg/OneJA-Bot/issues/11711) ([395595a](395595a)) * **misc**: Skill setting page and skill store, closes [lobehub#11665](https://github.com/jaworldwideorg/OneJA-Bot/issues/11665) ([d8c0c26](d8c0c26)) * **misc**: Support agent group unpublish agents, closes [lobehub#11687](https://github.com/jaworldwideorg/OneJA-Bot/issues/11687) ([4e060be](4e060be)) * **misc**: Support client tasks mode, closes [lobehub#11666](https://github.com/jaworldwideorg/OneJA-Bot/issues/11666) ([98cf57b](98cf57b)) * **misc**: Update the sandbox preinstall libs in sys role, closes [lobehub#11688](https://github.com/jaworldwideorg/OneJA-Bot/issues/11688) ([404c577](404c577)) #### What's fixed * **copilot**: Pass correct scope when creating new session in PageEditor, closes [lobehub#11714](https://github.com/jaworldwideorg/OneJA-Bot/issues/11714) ([0259270](0259270)) * **desktop**: Gracefully handle missing update manifest 404 errors, closes [lobehub#11625](https://github.com/jaworldwideorg/OneJA-Bot/issues/11625) ([13e95b9](13e95b9)) * **model-runtime**: Filter unsupported image types (SVG) before sending to vision models, closes [lobehub#11698](https://github.com/jaworldwideorg/OneJA-Bot/issues/11698) ([c0c99a7](c0c99a7)) * **pdf**: Upgrade pdfjs-dist and react-pdf to v5.x, closes [lobehub#11686](https://github.com/jaworldwideorg/OneJA-Bot/issues/11686) ([2b620df](2b620df)) * **sidebar-drawer**: Fix drawer positioning and title style, closes [lobehub#11655](https://github.com/jaworldwideorg/OneJA-Bot/issues/11655) ([cf5320e](cf5320e)) * **misc**: Fix group broadcast trigger tool use, closes [lobehub#11646](https://github.com/jaworldwideorg/OneJA-Bot/issues/11646) ([831a9b3](831a9b3)) * **misc**: Fix local system tools, closes [lobehub#11702](https://github.com/jaworldwideorg/OneJA-Bot/issues/11702) ([6548fc7](6548fc7)) * **misc**: Fix memory schema, closes [lobehub#11645](https://github.com/jaworldwideorg/OneJA-Bot/issues/11645) ([3baf780](3baf780)) * **misc**: Fix multi agent tasks issue, closes [lobehub#11672](https://github.com/jaworldwideorg/OneJA-Bot/issues/11672) ([9de773b](9de773b)) * **misc**: Fix multi tasks no summary issue, closes [lobehub#11685](https://github.com/jaworldwideorg/OneJA-Bot/issues/11685) ([26ce317](26ce317)) * **misc**: Fix scope issue, closes [lobehub#11719](https://github.com/jaworldwideorg/OneJA-Bot/issues/11719) ([17adde8](17adde8)) * **misc**: Fix tool argument scape and improve multi task run, closes [lobehub#11691](https://github.com/jaworldwideorg/OneJA-Bot/issues/11691) ([b13bb8a](b13bb8a)) * **misc**: Fixed the sandbox tools call when error should use right callback, closes [lobehub#11721](https://github.com/jaworldwideorg/OneJA-Bot/issues/11721) ([e8fce68](e8fce68)) * **misc**: Improve e2e server and complete i18n resources, closes [lobehub#11678](https://github.com/jaworldwideorg/OneJA-Bot/issues/11678) ([d450dd9](d450dd9)) * **misc**: Slove the agent group editor not focus in editdata area, closes [lobehub#11677](https://github.com/jaworldwideorg/OneJA-Bot/issues/11677) ([9ac84e6](9ac84e6)) * **misc**: Slove the agents header switch agents the lobeAI not show problem, closes [lobehub#11726](https://github.com/jaworldwideorg/OneJA-Bot/issues/11726) ([f45f508](f45f508)) * **misc**: Sloved the old removeSessionTopics not work, closes [lobehub#11671](https://github.com/jaworldwideorg/OneJA-Bot/issues/11671) ([06d41e5](06d41e5)) * **misc**: TypewriterEffect not refreshing on language change, closes [lobehub#11657](https://github.com/jaworldwideorg/OneJA-Bot/issues/11657) ([ba30f46](ba30f46)) * **misc**: Updata cron job ui & fixed commnuity pagenation goto error, closes [lobehub#11700](https://github.com/jaworldwideorg/OneJA-Bot/issues/11700) ([42ad2a0](42ad2a0)) * **misc**: Update the agentbuilder tools not always use humanIntervention, closes [lobehub#11696](https://github.com/jaworldwideorg/OneJA-Bot/issues/11696) ([0d3017b](0d3017b)) #### Styles * **misc**: Improve auto scroll and group profile, closes [lobehub#11725](https://github.com/jaworldwideorg/OneJA-Bot/issues/11725) ([550acc2](550acc2)) * **misc**: Update og, closes [lobehub#11709](https://github.com/jaworldwideorg/OneJA-Bot/issues/11709) ([01cf4e4](01cf4e4)) * **misc**: Update share style, closes [lobehub#11716](https://github.com/jaworldwideorg/OneJA-Bot/issues/11716) ([3c70dfa](3c70dfa)) </details> <div align="right"> [](#readme-top) </div>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Introduce a platform-aware download client entry in user menus, replacing the previous PWA installation flow and wiring it to platform-specific download URLs.
New Features:
Enhancements: