[4.4] Rebuild module Breadcrumbs with new Joomla 4 structure#40328
[4.4] Rebuild module Breadcrumbs with new Joomla 4 structure#40328laoneo merged 19 commits intojoomla:4.4-devfrom
Conversation
here no longer required, moved
Missing tag
|
Drone fails AssertionError: Timed out retrying after 4000ms: |
BreadcrumbsHelper has no constructor.
Please restore it and deprecate it
More logical
Needed for setSeparator
tests/System/integration/site/modules/mod_breadcrumbs/Default.cy.js
Outdated
Show resolved
Hide resolved
|
In my php editor, appears the following message in the Dispatcher.php file: Method 'getBreadcrumbs' not found in \Joomla\Database\DatabaseAwareInterface|null|\stdClass This error disappears when I change in the BreadcrumbsHelper.php file: to: The database is not called in this file. So that's why I don't understand this message. |
|
@sandewt I applied the patch, but I did not see any warning message in the editor or in the site about the |
Agree, but that means that the underlying code of the Dispatcher.php is not quite correct. And so it is a point of attention. |
In accordance with joomla#40386
$this->getHome => $this->getHomeItem
add text
|
Thanks! |
|
Thanks all, and @laoneo special thanks for your support. |
|
I hope you guys do continue the good work and convert more modules. This is very important work for the future. Especially when system tests are added... |
|
I like to do that. As soon as I have time, I will convert a new module / plugin. |
* Add deleted files from #40066 , #40092 , #40142 and #40146 * Add deleted files from #40180 and #40174 * Add deleted files from #39527 , #39535 , #40169 and #40173 * Add deleted files from #39552 , #39931 , #39628 and #40328 * Add deleted files from #40216 * Add deleted files from #40561 , #40190 and #40205
Pull Request for Issue # .
Summary of Changes
Rebuild mod_breadcrumbs with new Joomla 4 structure
The method
setSeparatorhas beendroppeddeprecated, it was not used in J4. (A nice feature in itself.)The function
public static function getListbecomespublic function getBreadcrumbs(non-static)The function
public static function getHomebecomespublic function getHomeItem(non-static)A system test has been added (Cypress)
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
ping @laoneo