Skip to content

Convert user plugins to service provider#40180

Merged
MacJoom merged 18 commits intojoomla:4.4-devfrom
Digital-Peak:provider/plugins/user
Mar 29, 2023
Merged

Convert user plugins to service provider#40180
MacJoom merged 18 commits intojoomla:4.4-devfrom
Digital-Peak:provider/plugins/user

Conversation

@laoneo
Copy link
Copy Markdown
Member

@laoneo laoneo commented Mar 23, 2023

Summary of Changes

Converts the user plugins to service providers.

Testing Instructions

  • Enable all user plugins
  • Create a contact
  • Enable registration
  • Create a new user on the front end with some contact fields

Actual result BEFORE applying this Pull Request

User is created with some extra fields like address.

Expected result AFTER applying this Pull Request

User is created with some extra fields like address.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

heelc29
heelc29 suggested changes Mar 25, 2023
View reviewed changes
laoneo and others added 7 commits March 25, 2023 15:32
@laoneo @heelc29
Update plugins/user/contactcreator/services/provider.php
5e9adef 
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
@laoneo @heelc29
Update plugins/user/joomla/services/provider.php
fe37312 
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
@laoneo @heelc29
Update plugins/user/profile/services/provider.php
03bc989 
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
@laoneo @heelc29
Update plugins/user/terms/services/provider.php
e378183 
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
@laoneo @heelc29
Update plugins/user/token/services/provider.php
b98e31f 
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
@laoneo @heelc29
Update plugins/user/joomla/src/Extension/Joomla.php
bc7639b 
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
@laoneo @heelc29
Update plugins/user/joomla/src/Extension/Joomla.php
75e4c3d 
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
@heelc29
Copy link
Copy Markdown
Contributor

heelc29 commented Mar 25, 2023

I have tested this item 🔴 unsuccessfully on 75e4c3d

Mail to new user is not translated
image
when frontend language of new user is not equal to administrators language
image

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40180.

heelc29
heelc29 reviewed Mar 25, 2023
View reviewed changes
@laoneo
Copy link
Copy Markdown
Member Author

laoneo commented Mar 25, 2023

@heelc29 does this not happen on 4.3-dev?

@heelc29
Copy link
Copy Markdown
Contributor

heelc29 commented Mar 25, 2023

@heelc29 does this not happen on 4.3-dev?

No, without this PR it's working.

@joomdonation
Copy link
Copy Markdown
Contributor

joomdonation commented Mar 26, 2023

@laoneo See Digital-Peak#28 , it will fix the email issue.

@MacJoom MacJoom self-assigned this Mar 26, 2023
heelc29
heelc29 reviewed Mar 26, 2023
View reviewed changes
@laoneo @heelc29
Update plugins/user/joomla/src/Extension/Joomla.php
92bc582 
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
@heelc29
Copy link
Copy Markdown
Contributor

heelc29 commented Mar 26, 2023

I have tested this item ✅ successfully on 92bc582

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40180.

@heelc29
Copy link
Copy Markdown
Contributor

heelc29 commented Mar 26, 2023

I have tested this item ✅ successfully on 48241fa

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40180.

@joomdonation
Copy link
Copy Markdown
Contributor

joomdonation commented Mar 28, 2023

I have tested this item ✅ successfully on fcfd5c8

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40180.

@joomdonation
Copy link
Copy Markdown
Contributor

joomdonation commented Mar 28, 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40180.

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 29, 2023
@MacJoom MacJoom added this to the Joomla! 4.4.0 milestone Mar 29, 2023
@laoneo laoneo deleted the provider/plugins/user branch March 30, 2023 05:49
@richard67 richard67 mentioned this pull request Mar 30, 2023
Merged
2 tasks
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 30, 2023
@richard67
Add deleted files from joomla#40180 and joomla#40174
898e85a
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 30, 2023
@richard67
Add deleted files from joomla#40180 and joomla#40174
09eb0f9
@richard67 richard67 mentioned this pull request Apr 1, 2023
Merged
2 tasks
richard67 added a commit to richard67/joomla-cms that referenced this pull request Apr 4, 2023
@richard67
Add deleted files from joomla#40180 and joomla#40174
7cb42aa
richard67 added a commit to richard67/joomla-cms that referenced this pull request Apr 30, 2023
@richard67
Add deleted files from joomla#40180 and joomla#40174
3ffb24e
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 9, 2023
@richard67
Add deleted files from joomla#40180 and joomla#40174
15f14e6
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 22, 2023
@richard67
Add deleted files from joomla#40180 and joomla#40174
409c25d
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 23, 2023
@richard67
Add deleted files from joomla#40180 and joomla#40174
59bd39a
laoneo pushed a commit that referenced this pull request May 23, 2023
@richard67
[4.4] Update deleted files list in script.php for 4.4.0-alpha1 (#40231)
deab947 
* Add deleted files from #40066 , #40092 , #40142 and #40146

* Add deleted files from #40180 and #40174

* Add deleted files from #39527 , #39535 , #40169 and #40173

* Add deleted files from #39552 , #39931 , #39628 and #40328

* Add deleted files from #40216

* Add deleted files from #40561 , #40190 and #40205
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 27, 2023
@richard67
Add deleted files from joomla#40180 and joomla#40174
b7ef005
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 3, 2023
@richard67
Add deleted files from joomla#40180 and joomla#40174
914b108
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 8, 2023
@richard67
Add deleted files from joomla#40180 and joomla#40174
b11e52b
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 23, 2023
@richard67
Add deleted files from joomla#40180 and joomla#40174
46454bd
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 3, 2023
@richard67
Add deleted files from joomla#40180 and joomla#40174
301f89e
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 23, 2023
@richard67
Add deleted files from joomla#40180 and joomla#40174
15bdb73
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 12, 2023
@richard67
Add deleted files from joomla#40180 and joomla#40174
7d12e95
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 19, 2023
@richard67
Add deleted files from joomla#40180 and joomla#40174
2e0c7f1
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 20, 2023
@richard67
Add deleted files from joomla#40180 and joomla#40174
f4b51d0
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 22, 2023
@richard67
Add deleted files from joomla#40180 and joomla#40174
bb6905b
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 1, 2023
@richard67
Add deleted files from joomla#40180 and joomla#40174
fbc40cf
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 4, 2023
@richard67
Add deleted files from joomla#40180 and joomla#40174
5fe24a0
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 4, 2023
@richard67
Add deleted files from joomla#40180 and joomla#40174
724026c
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 14, 2023
@richard67
Add deleted files from joomla#40180 and joomla#40174
86fb07f
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 19, 2023
@richard67
Add deleted files from joomla#40180 and joomla#40174
6d0e226
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 26, 2023
@richard67
Add deleted files from joomla#40180 and joomla#40174
2afb79a
richard67 added a commit to richard67/joomla-cms that referenced this pull request Oct 1, 2023
@richard67
Add deleted files from joomla#40180 and joomla#40174
17771c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@heelc29 heelc29 heelc29 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MacJoom MacJoom

Labels

None yet

Projects

None yet

Milestone

Joomla! 4.4.0

Development

Successfully merging this pull request may close these issues.

5 participants

@laoneo @heelc29 @joomdonation @MacJoom @joomla-cms-bot