Skip to content

Convert mod_articles_categories to new structure#39552

Merged
MacJoom merged 42 commits intojoomla:4.4-devfrom
carlitorweb:convert_mod_articles_categories
Apr 14, 2023
Merged

Convert mod_articles_categories to new structure#39552
MacJoom merged 42 commits intojoomla:4.4-devfrom
carlitorweb:convert_mod_articles_categories

Conversation

@carlitorweb
Copy link
Copy Markdown
Member

@carlitorweb carlitorweb commented Jan 3, 2023

Summary of Changes

This PR converts mod_articles_categories to the new structure

Testing Instructions

  • Use Joomla 4.3
  • Create an instance of the module Articles - Categories. Note how it works.
  • Apply patch
  • Delete administrator/cache/autoload_psr4.php
  • Refresh the page, make sure the module still displays the same as before.

Additional comments

I not sure of the best approach to use cache here, if is needed.

@carlitorweb carlitorweb requested a review from chmst as a code owner January 3, 2023 18:00
ReLater
ReLater reviewed Jan 8, 2023
View reviewed changes
@richard67 richard67 mentioned this pull request Feb 18, 2023
Merged
2 tasks
@carlitorweb carlitorweb changed the base branch from 4.3-dev to 4.4-dev March 11, 2023 20:37
@Quy Quy removed the PR-4.3-dev label Mar 11, 2023
@carlitorweb
Copy link
Copy Markdown
Member Author

carlitorweb commented Mar 13, 2023

@Quy any hint why is failing here the drone?

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Mar 13, 2023

Click on Details.
Click on phpcs to see the console logs.

@carlitorweb
Copy link
Copy Markdown
Member Author

carlitorweb commented Mar 13, 2023

Yes I did that....

@MacJoom MacJoom merged commit 2f46198 into joomla:4.4-dev Apr 14, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 14, 2023
@MacJoom MacJoom added this to the Joomla! 4.4.0 milestone Apr 14, 2023
@carlitorweb carlitorweb deleted the convert_mod_articles_categories branch April 14, 2023 14:13
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 1, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
7e75033 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 1, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
218d9cb 
…oomla#40328
@richard67 richard67 mentioned this pull request May 1, 2023
Merged
2 tasks
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 9, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
9c7bc48 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 22, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
04e05c0 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 23, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
fbe3841 
…oomla#40328
laoneo pushed a commit that referenced this pull request May 23, 2023
@richard67
[4.4] Update deleted files list in script.php for 4.4.0-alpha1 (#40231)
deab947 
* Add deleted files from #40066 , #40092 , #40142 and #40146

* Add deleted files from #40180 and #40174

* Add deleted files from #39527 , #39535 , #40169 and #40173

* Add deleted files from #39552 , #39931 , #39628 and #40328

* Add deleted files from #40216

* Add deleted files from #40561 , #40190 and #40205
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 27, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
b9590f5 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 3, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
ae4d12f 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 8, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
5ec80b1 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 23, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
e7877d8 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 3, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
b956c59 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 23, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
fa06895 
…oomla#40328
@heelc29 heelc29 mentioned this pull request Jul 23, 2023
Merged
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 12, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
4949dc6 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 19, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
38d6e00 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 20, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
aab6e7b 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 22, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
0fb965f 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 1, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
5a56007 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 4, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
b07bd79 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 4, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
b48a6b4 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 14, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
a3a1d8a 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 19, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
d9569b7 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 26, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
516ee41 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request Oct 1, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
2777b9b 
…oomla#40328
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laoneo laoneo laoneo left review comments

@chmst chmst chmst approved these changes

+1 more reviewer

@ReLater ReLater ReLater left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@MacJoom MacJoom

Labels

Feature Unit/System Tests

Projects

None yet

Milestone

Joomla! 4.4.0

Development

Successfully merging this pull request may close these issues.

9 participants

@carlitorweb @Quy @laoneo @drmenzelit @chmst @ReLater @Hackwar @MacJoom @joomla-cms-bot