[4.4] Rebuild mod_footer with new Joomla 4 structure#40066
Merged
laoneo merged 32 commits intojoomla:4.4-devfrom Mar 22, 2023
Merged
[4.4] Rebuild mod_footer with new Joomla 4 structure#40066laoneo merged 32 commits intojoomla:4.4-devfrom
laoneo merged 32 commits intojoomla:4.4-devfrom
Conversation
Contributor
joomdonation
left a comment
There was a problem hiding this comment.
Thanks for working on on this @sandewt . Overall, it looks good. Just some minor suggestions from me and I think it should be fine.
Is no longer necessary
no need to use Helper
No longer necessary
$list moved by $lineOne
Forgot somethingto change
Contributor
sergeytolkachyov
left a comment
There was a problem hiding this comment.
I would be careful when changing the layout files, since many people may have redefinitions that are in the tmpl module or in the template and their files will have old variable names, which will cause an error when updating Joomla and force them to look for the cause.
Contributor
joomdonation
left a comment
There was a problem hiding this comment.
Thanks. There are still some minor things left and we should be good.
$data['lineOne'] to $data['lineone']
$lineOne to $lineone
Member
|
Can you guys rebase this and the other pr's which do convert the modules to service providers to the 4.4 branch? |
More consistent with other provider.php files
Small type
Contributor
Author
How can I convert this PR in an easy way? |
Member
|
Click on the edit button next to the title and then change the target branch. |
Member
|
Thanks! |
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Mar 29, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Mar 29, 2023
2 tasks
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Mar 30, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Apr 4, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Apr 30, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
May 9, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
May 22, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
May 23, 2023
laoneo
pushed a commit
that referenced
this pull request
May 23, 2023
* Add deleted files from #40066 , #40092 , #40142 and #40146 * Add deleted files from #40180 and #40174 * Add deleted files from #39527 , #39535 , #40169 and #40173 * Add deleted files from #39552 , #39931 , #39628 and #40328 * Add deleted files from #40216 * Add deleted files from #40561 , #40190 and #40205
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
May 27, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jun 3, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jun 8, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jun 23, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jul 3, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jul 23, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Aug 12, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Aug 19, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Aug 20, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Aug 22, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 1, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 4, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 4, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 14, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 19, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 26, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Oct 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Rebuild mod_footer with new Joomla 4 structure
See: testing Instructions
Testing Instructions
Just try to use it as usual.
Actual result BEFORE applying this Pull Request
Module works
Expected result AFTER applying this Pull Request
Module works
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Related to #39931 (mod_custom). Thks @sergeytolkachyov and @joomdonation
[EDIT mod_footer system test #40114]