Skip to content

Convert mod_articles_archive to new structure#39535

Merged
laoneo merged 38 commits intojoomla:4.4-devfrom
carlitorweb:convert_mod_articles_archive
Apr 3, 2023
Merged

Convert mod_articles_archive to new structure#39535
laoneo merged 38 commits intojoomla:4.4-devfrom
carlitorweb:convert_mod_articles_archive

Conversation

@carlitorweb
Copy link
Copy Markdown
Member

@carlitorweb carlitorweb commented Jan 1, 2023 •
edited
Loading

Summary of Changes

This PR converts mod_articles_archive to the new structure

Testing Instructions

  • Use Joomla 4.3
  • Create an instance of the module Articles - Archived. Note how it works.
  • Apply patch
  • Delete administrator/cache/autoload_psr4.php
  • Refresh the page, make sure the module still displays the same as before.

Additional comments

A small change to the layout was made. Now will show the amount of articles the month have archived, for example:

Before patch:
December, 2022

After patch:
December, 2022 (1)

If is not allowed, let me kown and I revert the change

@carlitorweb carlitorweb requested a review from chmst as a code owner January 1, 2023 16:21
@carlitorweb
Copy link
Copy Markdown
Member Author

carlitorweb commented Jan 1, 2023

@laoneo the name of the method getArticles() do not describe really the purpose of the method. Can be changed for this module to something like getMonths() for example?

ReLater
ReLater reviewed Jan 1, 2023
View reviewed changes
@laoneo
Copy link
Copy Markdown
Member

laoneo commented Jan 3, 2023

Sure, change it. More accurate names are always better...

@richard67 richard67 mentioned this pull request Feb 18, 2023
Merged
2 tasks
@carlitorweb carlitorweb changed the base branch from 4.3-dev to 4.4-dev March 11, 2023 20:47
@Quy Quy removed the PR-4.3-dev label Mar 11, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Apr 4, 2023
@richard67
Add deleted files from joomla#39527 , joomla#39535 , joomla#40169 and j…
2b8c061 
…oomla#40173
richard67 added a commit to richard67/joomla-cms that referenced this pull request Apr 4, 2023
@richard67
Add deleted files from joomla#39527 , joomla#39535 , joomla#40169 and j…
1eebe72 
…oomla#40173
@richard67 richard67 mentioned this pull request Apr 4, 2023
Merged
2 tasks
@sandewt
Copy link
Copy Markdown
Contributor

sandewt commented Apr 4, 2023

Thanks for the hint, can you make a new pr for this?

I noticed even more details in the already modified modules. I think it would be useful to change those as well, so that they become more consistent. But first gain some more experience with the modules.

@sandewt sandewt mentioned this pull request Apr 8, 2023
Merged
richard67 added a commit to richard67/joomla-cms that referenced this pull request Apr 30, 2023
@richard67
Add deleted files from joomla#39527 , joomla#39535 , joomla#40169 and j…
ebc89f1 
…oomla#40173
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 9, 2023
@richard67
Add deleted files from joomla#39527 , joomla#39535 , joomla#40169 and j…
7f53935 
…oomla#40173
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 22, 2023
@richard67
Add deleted files from joomla#39527 , joomla#39535 , joomla#40169 and j…
0143c8c 
…oomla#40173
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 23, 2023
@richard67
Add deleted files from joomla#39527 , joomla#39535 , joomla#40169 and j…
d4bc320 
…oomla#40173
laoneo pushed a commit that referenced this pull request May 23, 2023
@richard67
[4.4] Update deleted files list in script.php for 4.4.0-alpha1 (#40231)
deab947 
* Add deleted files from #40066 , #40092 , #40142 and #40146

* Add deleted files from #40180 and #40174

* Add deleted files from #39527 , #39535 , #40169 and #40173

* Add deleted files from #39552 , #39931 , #39628 and #40328

* Add deleted files from #40216

* Add deleted files from #40561 , #40190 and #40205
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 27, 2023
@richard67
Add deleted files from joomla#39527 , joomla#39535 , joomla#40169 and j…
72097d5 
…oomla#40173
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 3, 2023
@richard67
Add deleted files from joomla#39527 , joomla#39535 , joomla#40169 and j…
05cc5f1 
…oomla#40173
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 8, 2023
@richard67
Add deleted files from joomla#39527 , joomla#39535 , joomla#40169 and j…
3af256f 
…oomla#40173
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 23, 2023
@richard67
Add deleted files from joomla#39527 , joomla#39535 , joomla#40169 and j…
8e35cb0 
…oomla#40173
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 3, 2023
@richard67
Add deleted files from joomla#39527 , joomla#39535 , joomla#40169 and j…
09e2215 
…oomla#40173
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 23, 2023
@richard67
Add deleted files from joomla#39527 , joomla#39535 , joomla#40169 and j…
10201e4 
…oomla#40173
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 12, 2023
@richard67
Add deleted files from joomla#39527 , joomla#39535 , joomla#40169 and j…
cd39e72 
…oomla#40173
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 19, 2023
@richard67
Add deleted files from joomla#39527 , joomla#39535 , joomla#40169 and j…
ff6c4d5 
…oomla#40173
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 20, 2023
@richard67
Add deleted files from joomla#39527 , joomla#39535 , joomla#40169 and j…
138ca42 
…oomla#40173
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 22, 2023
@richard67
Add deleted files from joomla#39527 , joomla#39535 , joomla#40169 and j…
73385e8 
…oomla#40173
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 1, 2023
@richard67
Add deleted files from joomla#39527 , joomla#39535 , joomla#40169 and j…
fb4c611 
…oomla#40173
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 4, 2023
@richard67
Add deleted files from joomla#39527 , joomla#39535 , joomla#40169 and j…
ccd8713 
…oomla#40173
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 4, 2023
@richard67
Add deleted files from joomla#39527 , joomla#39535 , joomla#40169 and j…
d4aad98 
…oomla#40173
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 14, 2023
@richard67
Add deleted files from joomla#39527 , joomla#39535 , joomla#40169 and j…
bde0c55 
…oomla#40173
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 19, 2023
@richard67
Add deleted files from joomla#39527 , joomla#39535 , joomla#40169 and j…
e59c1fc 
…oomla#40173
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 26, 2023
@richard67
Add deleted files from joomla#39527 , joomla#39535 , joomla#40169 and j…
578f9bf 
…oomla#40173
richard67 added a commit to richard67/joomla-cms that referenced this pull request Oct 1, 2023
@richard67
Add deleted files from joomla#39527 , joomla#39535 , joomla#40169 and j…
7a587d3 
…oomla#40173
muddygs added a commit to muddygs/joomla-claw-admin that referenced this pull request Feb 25, 2024
@muddygs
Updated to new module structure
a8c960e 
See joomla/joomla-cms#39535
muddygs added a commit to muddygs/joomla-claw-admin that referenced this pull request Feb 27, 2024
@muddygs
Updated to new module structure (+conversion to templates)
8ea84be 
See joomla/joomla-cms#39535
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laoneo laoneo laoneo approved these changes

@chmst chmst Awaiting requested review from chmst

+3 more reviewers

@brianteeman brianteeman brianteeman left review comments

@sandewt sandewt sandewt left review comments

@ReLater ReLater ReLater left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@laoneo laoneo

Labels

Unit/System Tests

Projects

None yet

Milestone

Joomla! 4.4.0

Development

Successfully merging this pull request may close these issues.

9 participants

@carlitorweb @laoneo @obuisard @sandewt @chmst @brianteeman @ReLater @Quy @joomla-cms-bot