[4.4] Rebuild plugin PageNavigation with new Joomla 4 structure#40142
Merged
MacJoom merged 19 commits intojoomla:4.4-devfrom Mar 23, 2023
Merged
[4.4] Rebuild plugin PageNavigation with new Joomla 4 structure#40142MacJoom merged 19 commits intojoomla:4.4-devfrom
MacJoom merged 19 commits intojoomla:4.4-devfrom
Conversation
wrong folder
wrong folder
wrong file
sandewt
commented
Mar 17, 2023
laoneo
reviewed
Mar 17, 2023
plugins/content/pagenavigation/src/Extension/PageNavigation.php
Outdated
Show resolved
Hide resolved
sandewt
commented
Mar 17, 2023
Contributor
|
I have tested this item ✅ successfully on 6564797 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40142. |
Contributor
|
I have tested this item ✅ successfully on ba76e94 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40142. |
Contributor
|
@toivo Could you please help testing this PR again? Thanks. |
Contributor
Author
|
Related to #40146 to get consistent code |
Contributor
|
I have tested this item ✅ successfully on ba76e94 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40142. |
Contributor
|
RTC. If decision is using This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40142. |
_DEPLOY_VERSION__ becomes __DEPLOY_VERSION__
Contributor
Author
|
Slip of the pen, (last) correction in code 😅 |
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Mar 29, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Mar 29, 2023
2 tasks
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Mar 30, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Apr 4, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Apr 30, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
May 9, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
May 22, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
May 23, 2023
laoneo
pushed a commit
that referenced
this pull request
May 23, 2023
* Add deleted files from #40066 , #40092 , #40142 and #40146 * Add deleted files from #40180 and #40174 * Add deleted files from #39527 , #39535 , #40169 and #40173 * Add deleted files from #39552 , #39931 , #39628 and #40328 * Add deleted files from #40216 * Add deleted files from #40561 , #40190 and #40205
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
May 27, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jun 3, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jun 8, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jun 23, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jul 3, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jul 23, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Aug 12, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Aug 19, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Aug 20, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Aug 22, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 1, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 4, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 4, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 14, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 19, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 26, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Oct 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Rebuild plugin PageNavigation with new Joomla 4 structure
Replacing (some) deprecated classes
Testing Instructions
Code review
Just try to use it as usual
Actual result BEFORE applying this Pull Request
Plugin works
Expected result AFTER applying this Pull Request
Plugin works
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed