Skip to content

Convert system plugins to service provider#40216

Merged
MacJoom merged 40 commits intojoomla:4.4-devfrom
Digital-Peak:providers/plugins/system
May 9, 2023
Merged

Convert system plugins to service provider#40216
MacJoom merged 40 commits intojoomla:4.4-devfrom
Digital-Peak:providers/plugins/system

Conversation

@laoneo
Copy link
Copy Markdown
Member

@laoneo laoneo commented Mar 27, 2023

Summary of Changes

Converts the system plugins to service providers.

Testing Instructions

Do different things like login/logout on the front end, enable debug mode, play around with http headers.

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Fedik
Copy link
Copy Markdown
Member

Fedik commented Mar 27, 2023

@laoneo please keep plugin constructors consistent.

new Plugin($dispatcher, $config, ... other variables)

instead of

new Plugin(... other variables, $dispatcher, $config)

That would be nice :)

@laoneo laoneo changed the title Convert system plugins to service provider [Draft] Convert system plugins to service provider Mar 27, 2023
@laoneo
Copy link
Copy Markdown
Member Author

laoneo commented Mar 27, 2023

@Fedik changed it

@Fedik
Copy link
Copy Markdown
Member

Fedik commented Mar 27, 2023

Thanks! Looks good

@laoneo laoneo changed the title [Draft] Convert system plugins to service provider Convert system plugins to service provider Mar 27, 2023
@joomla-cms-bot joomla-cms-bot added the Language Change This is for Translators label Mar 27, 2023
@laoneo laoneo removed the Language Change This is for Translators label Mar 27, 2023
@MacJoom MacJoom self-assigned this Mar 28, 2023
@MacJoom MacJoom merged commit 3ff8f00 into joomla:4.4-dev May 9, 2023
@MacJoom MacJoom added this to the Joomla! 4.4.0 milestone May 9, 2023
@MacJoom MacJoom deleted the providers/plugins/system branch May 9, 2023 10:12
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 9, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 9, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 22, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 23, 2023
laoneo pushed a commit that referenced this pull request May 23, 2023
* Add deleted files from #40066 , #40092 , #40142 and #40146

* Add deleted files from #40180 and #40174

* Add deleted files from #39527 , #39535 , #40169 and #40173

* Add deleted files from #39552 , #39931 , #39628 and #40328

* Add deleted files from #40216

* Add deleted files from #40561 , #40190 and #40205
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 27, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 3, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 8, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 23, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 3, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 23, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 12, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 19, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 20, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 22, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 1, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 4, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 4, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 14, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 19, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 26, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants