@carlitorweb Unfortunately you have made the moving of the file and the changes inside the moved file with the same one commit, so GitHub does not show a moved and changed file but a deleted and a new file, so the history got lost. To avoid that, moving a file and changing its content have to be made with 2 separate commits. It’s not a big problem, but please remember that for future PR‘s.

@carlitorweb Unfortunately you have made the moving of the file and the changes inside the moved file with the same one commit, so GitHub does not show a moved and changed file but a deleted and a new file, so the history got lost. To avoid that, moving a file and changing its content have to be made with 2 separate commits. It’s not a big problem, but please remember that for future PR‘s.

Copy that. Really not notice this when doing the changes, sorry. If is neccessary I can do all again, not problem.

If is neccessary I can do all again, not problem.

@carlitorweb Not necessary. All ok.

@richard67 sometimes, even when you rename a file and do a lot of changes, git is not able to detect the rename.

@carlitorweb thank you very much, now we need the two tests to get it merged.

@laoneo you are welcome, glad to help. I will continue with the rest.

I don't know how "hungry" $db = $this->getDatabase(); is, but as far as I see $db is only used once. Maybe it's more efficient to move this->getDatabase down to the place where it's used (if it's used)?

                case 'random':
                    $articlesModel->setState('list.ordering', $this->getDatabase()->getQuery(true)->rand());
                    break;

Would it be possible to write also a system test for this module, similar as we did in #40092? If you need help how to get started with system tests, you can find some information here.