Fix account notification email language#28
Fix account notification email language#28laoneo merged 1 commit intoDigital-Peak:provider/plugins/userfrom
Conversation
|
Thanks. I guess the method exists calls can be removed. |
|
Why is this all of the sudden needed? All I did was changing $this->app to $this->getApplication(), so it basically should be the same as before. |
The
It is not the same as before. Please look at https://github.com/joomla/joomla-cms/blob/4.3-dev/libraries/src/Plugin/CMSPlugin.php#L168 . Before, we did not pass application to plugin, so the language file is loaded base on global language. With application object passed to plugin, it will now load the language file to the application language, so there is a difference. |
|
Ok, thanks! |
* Convert user plugins to service provider * form path * Update plugins/user/contactcreator/services/provider.php Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update plugins/user/joomla/services/provider.php Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update plugins/user/profile/services/provider.php Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update plugins/user/terms/services/provider.php Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update plugins/user/token/services/provider.php Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update plugins/user/joomla/src/Extension/Joomla.php Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update plugins/user/joomla/src/Extension/Joomla.php Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * revert debug * private * Fix account notification email language (#28) * Update plugins/user/joomla/src/Extension/Joomla.php Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * minor change --------- Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> Co-authored-by: Tuan Pham Ngoc <github@joomdonation.com>
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed