Improve system tests descriptions#40386
Merged
MacJoom merged 13 commits intojoomla:4.4-devfrom Apr 17, 2023
Merged
Conversation
Member
Author
|
@brianteeman can you have a look here if I screwed up something? |
Contributor
|
@laoneo lol - I was going to take a look at all of this today. Looks like there might still be a few tweaks needed. setting up my pc for tests and then will post back shortly |
sandewt
reviewed
Apr 14, 2023
tests/System/integration/site/components/com_contact/Categories.cy.js
Outdated
Show resolved
Hide resolved
sandewt
reviewed
Apr 14, 2023
tests/System/integration/site/components/com_users/Remind.cy.js
Outdated
Show resolved
Hide resolved
Member
Author
|
@sandewt thanks for the hint, changed it |
brianteeman
reviewed
Apr 14, 2023
tests/System/integration/administrator/components/com_categories/Categories.cy.js
Outdated
Show resolved
Hide resolved
Contributor
|
'can create a article' |
brianteeman
reviewed
Apr 14, 2023
Contributor
|
I have tested this item ✅ successfully on 41e01f1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40386. |
Contributor
|
These text patterns should be documented This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40386. |
sandewt
reviewed
Apr 15, 2023
sandewt
reviewed
Apr 15, 2023
sandewt
reviewed
Apr 15, 2023
tests/System/integration/administrator/components/com_login/Login.cy.js
Outdated
Show resolved
Hide resolved
Contributor
|
Suggestion: it('testing registration form for a test user through a menu item', () => { |
sandewt
added a commit
to sandewt/joomla-cms
that referenced
this pull request
Apr 15, 2023
In accordance with joomla#40386
Contributor
|
|
…gin.cy.js Co-authored-by: jsanders <j53.sanders@gmail.com>
Member
Author
|
Better to use display |
sandewt
reviewed
Apr 17, 2023
tests/System/integration/site/components/com_users/Registration.cy.js
Outdated
Show resolved
Hide resolved
Contributor
|
Thanks all |
laoneo
pushed a commit
that referenced
this pull request
Apr 25, 2023
* services * Delete mod_breadcrumbs.php here no longer required, moved * Updated to new structure * Create Dispatcher.php * Create provider.php * Create Default.cy.js * Correction Missing tag * Correction * Delete $data parameter BreadcrumbsHelper has no constructor. * Restore setSeparator function Please restore it and deprecate it * Order functions changed More logical * HTMLHelper Needed for setSeparator * Improve test description In accordance with #40386 * Correction $this->getHome => $this->getHomeItem * not used anymore add text * functionality better description
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unifies the test descriptions. The describe text should always be:
Test that the {component name} {view name} viewWhile the description of the test itself should be a continuation of the description text like:
can {the tests which are performed}Both texts should be possible to concat so a meaningful sentence will be built. Because these texts will be displayed in cypress like:
