[lib & admin & template & plugins] Always use htmlspecialchars($str, ENT_COMPAT, 'UTF-8') by zero-24 · Pull Request #10438 · joomla/joomla-cms

zero-24 · 2016-05-12T12:15:56Z

Pull Request for Issue #10399 .

Summary of Changes

Always use htmlspecialchars($str, ENT_COMPAT, 'UTF-8')

Testing Instructions

Please do a code review or test all changed files.

brianteeman · 2016-05-12T16:41:47Z

I have tested this item ✅ successfully on 6aa2082

on review

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10438.}

alikon · 2016-05-12T18:48:48Z

I have tested this item ✅ successfully on 6aa2082

on review

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10438.}

brianteeman · 2016-05-12T18:56:20Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10438.}

andrepereiradasilva · 2016-05-13T20:56:48Z

libraries/joomla/document/opensearch.php


 		$elShortName = $xml->createElementNs($osns, 'ShortName');
-		$elShortName->appendChild($xml->createTextNode(htmlspecialchars($this->_shortName)));
+		$elShortName->appendChild($xml->createTextNode(htmlspecialchars($this->_shortName), ENT_COMPAT, 'UTF-8'));


this is not correct!

$xml->createTextNode(htmlspecialchars($this->_shortName), ENT_COMPAT, 'UTF-8')

should be

$xml->createTextNode(htmlspecialchars($this->_shortName, ENT_COMPAT, 'UTF-8'))

andrepereiradasilva · 2016-05-13T20:58:32Z

@brianteeman please remove the RTC from this one. It as errors.

brianteeman · 2016-05-13T20:59:06Z

Please explain the errors - saying it is not correct is not helpful

andrepereiradasilva · 2016-05-13T21:00:37Z

htmlspecialchars($image->data), ENT_COMPAT, 'UTF-8'

should be
htmlspecialchars($image->data, ENT_COMPAT, 'UTF-8)'

brianteeman · 2016-05-13T21:01:18Z

Explain not quote ;)

andrepereiradasilva · 2016-05-13T21:02:29Z

the parentisis is the wrong place

andrepereiradasilva · 2016-05-13T21:02:59Z

travis is also telling that.

brianteeman · 2016-05-13T21:06:04Z

RTC removed as requested

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10438.}

wojsmol · 2016-05-14T01:10:30Z

@zero-24 see zero-24#12

* fix travis error * CS

…oomla#10437) * Update default_items.php * Update list.php * Update view.html.php * Update view.html.php * Update view.html.php * Update route.php * Update mysqli.php * Update oauth.php * Update mod_articles_category.php * Update mysqli.php

rdeutz · 2016-05-16T16:18:34Z

@zero-24 could you have a look at the merge conflicts, thanks.

@robert

…i key if one was set (joomla#10439) * Change api scheme to https While the main change to this file is about setting the scheme to https, I've also refactored the uri handling and added the option to apply an api key as well. * Remove urlencode from address since it will be handled automatically in toString() * Create a new JUri instance instead of using $this->uri to prevent errors with e.g. isSercure() * Remove the sensor parameter since it doesn't seem to be need any longer Remove the sensor parameter since it doesn't seem to be need any longer. Thanks for pointing it out @robert. * Satisfy Travis, maybe?! * Add the sensor parameter back to the api url since the tests seem to rely on it Add the sensor parameter back to the api url since the tests seem to rely on it. If that really is the case, we should implement be a better way of "parsing" the url and / or looking for an array index in the tests. * Fix url parsing to properly handle query params * Remove the sensor parameter since it doesn't seem to be needed any more This time the test(s) shouldn't fail - fingers crossed.

…MPAT, 'UTF-8') (joomla#10440) * Update default.php * Update category_default.php * Update pdomysql.php * Update object.php * Update default_items.php * Update default_items.php * Update default.php * Update view.html.php * Update categories.php * codestyle https://travis-ci.org/joomla/joomla-cms/jobs/129754482

* Improve categories modal container * Add modal viewport dimensions * Remove single "double quote" in token * Fix JS error Uncaught SyntaxError: Unexpected token ) * Array indent * Add edit category as a modal and other improvements

….renderModal) (joomla#10428)

* Use getState instead of direct property read Use getState instead of direct property read to avoid any undefined property warnings. * Fix test case We're setting state manually for this test case. But since the flag is not set the populateState will be called and it will overwrite them.

…la#10515) * Code style filter_categories.xml Add empty line before opening tags for readability * Code style category.xml + fix closing tag field "tags" * Remove extra empty lines at end of categories.xml

* Simplify newsfeed modal, by setting edit layout * Improve Select & Edit com_newsfeeds modals

* add close button to js messages * type button

* cleaner tree * new view * and now?

) * New lang string for successful language installation * took off pack

[com_tags] use the same visual level structure as categories

…ories (joomla#10528) * user groups tree * forgot the * * add space * remove space

[com_config] filters tab: use the same tree level visual

* use layout * add tree prefix to categories modal

joomla-cms-bot · 2016-05-17T17:53:59Z

This PR has received new commits.

CC: @alikon, @andrepereiradasilva, @brianteeman

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10438.}

zero-24 · 2016-05-17T17:58:33Z

i did broken my branch please remove the milestone. @brianteeman

zero-24 added 9 commits May 12, 2016 14:06

Update highlight.php

405c6fe

Update default.php

bbe0f66

Update view.html.php

8aa361c

Update error.php

15cb32b

Update default_items.php

012ae03

Update offline.php

403d638

Update opensearch.php

057739b

Update debug.php

017f27e

Update component.php

6aa2082

joomla-cms-bot added the PR-staging label May 12, 2016

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 12, 2016

andrepereiradasilva reviewed May 13, 2016
View reviewed changes

brianteeman removed the RTC This Pull Request is Ready To Commit label May 13, 2016

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 13, 2016

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 13, 2016

wojsmol mentioned this pull request May 14, 2016

fix for travis zero-24/joomla-cms#12

Merged

fix for travis (#12)

972ba4f

* fix travis error * CS

matrikular and others added 22 commits May 16, 2016 18:20

Do not count all table rows if start offset is 0 (joomla#9162)

56068d5

Check out in case of modal close not needed anymore (set in bootstrap…

cef2ecd

….renderModal) (joomla#10428)

[com_categories] Coding standards xml + fix a wrong closing tag (joom…

2125659

…la#10515) * Code style filter_categories.xml Add empty line before opening tags for readability * Code style category.xml + fix closing tag field "tags" * Remove extra empty lines at end of categories.xml

Modal com_newsfeeds: improve Select & Edit Newsfeed (joomla#10516)

6ee4c6f

* Simplify newsfeed modal, by setting edit layout * Improve Select & Edit com_newsfeeds modals

[js message system] Add close button (joomla#10517)

f7f3e2b

* add close button to js messages * type button

correct js messages class (joomla#10521)

4052683

[com_categories] Cleaner tree view (joomla#10213)

3b8e664

* cleaner tree * new view * and now?

use the same level structure as categories

c13f53a

add to com_config filters and solve html error (th to td)

c0a4ab3

[imp] New lang string for successful language installation (joomla#10523

b61d68c

) * New lang string for successful language installation * took off pack

Merge pull request joomla#10526 from andrepereiradasilva/patch-7

7473c74

[com_tags] use the same visual level structure as categories

[com_users] user groups: use the same visual level structure as categ…

a18e851

…ories (joomla#10528) * user groups tree * forgot the * * add space * remove space

debuguser and debuggroup tree view (joomla#10530)

c6f129d

Merge pull request joomla#10531 from andrepereiradasilva/patch-13

5fd188c

[com_config] filters tab: use the same tree level visual

use the new layout (joomla#10536)

ea7f341

tree prefix for rules field. (joomla#10532)

4761590

[com_categories] modal: use the same tree level visual (joomla#10533)

082ff91

* use layout * add tree prefix to categories modal

merge conflicts

5741bd1

zero-24 closed this May 17, 2016

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 17, 2016

zero-24 deleted the patch-33 branch May 17, 2016 17:58

rdeutz removed this from the Joomla 3.6.0 milestone May 17, 2016

Uh oh!

Conversation

zero-24 commented May 12, 2016 • edited by brianteeman Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Testing Instructions

Uh oh!

brianteeman commented May 12, 2016

Uh oh!

alikon commented May 12, 2016

Uh oh!

brianteeman commented May 12, 2016

Uh oh!

andrepereiradasilva May 13, 2016

Choose a reason for hiding this comment

Uh oh!

brianteeman May 13, 2016

Choose a reason for hiding this comment

Uh oh!

andrepereiradasilva May 13, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andrepereiradasilva commented May 13, 2016

Uh oh!

brianteeman commented May 13, 2016

Uh oh!

andrepereiradasilva commented May 13, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brianteeman commented May 13, 2016

Uh oh!

andrepereiradasilva commented May 13, 2016

Uh oh!

andrepereiradasilva commented May 13, 2016

Uh oh!

brianteeman commented May 13, 2016

Uh oh!

wojsmol commented May 14, 2016

Uh oh!

rdeutz commented May 16, 2016

Uh oh!

joomla-cms-bot commented May 17, 2016

Uh oh!

zero-24 commented May 17, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

zero-24 commented May 12, 2016 •

edited by brianteeman

Loading

andrepereiradasilva May 13, 2016 •

edited

Loading

andrepereiradasilva commented May 13, 2016 •

edited

Loading