Skip to content

[comp & lib] Always use htmlspecialchars($str, ENT_COMPAT, 'UTF-8')#10437

Merged
rdeutz merged 10 commits intojoomla:stagingfrom
zero-24:patch-32
May 16, 2016
Merged

[comp & lib] Always use htmlspecialchars($str, ENT_COMPAT, 'UTF-8')#10437
rdeutz merged 10 commits intojoomla:stagingfrom
zero-24:patch-32

Conversation

@zero-24
Copy link
Copy Markdown
Contributor

@zero-24 zero-24 commented May 12, 2016

Pull Request for Issue #10399 .

Summary of Changes

Always use htmlspecialchars($str, ENT_COMPAT, 'UTF-8')

Testing Instructions

Please do a code review or test all changed files.

@brianteeman
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 0898f7f

On review


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10437.

@alikon
Copy link
Copy Markdown
Contributor

alikon commented May 12, 2016

I have tested this item ✅ successfully on 0898f7f

it's quite strange that travis is unhappy with @zero-24 👀

tested on code review


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10437.

@brianteeman brianteeman added this to the Joomla 3.6.0 milestone May 12, 2016
@brianteeman
Copy link
Copy Markdown
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10437.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 12, 2016
@zero-24
Copy link
Copy Markdown
Contributor Author

zero-24 commented May 12, 2016

I'm going to fix it tomorrow. It is an too much char per line error :(

@brianteeman brianteeman removed the RTC This Pull Request is Ready To Commit label May 12, 2016
@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 12, 2016
@brianteeman
Copy link
Copy Markdown
Contributor

Remove RTC for now

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 3.6.0 milestone May 12, 2016
@brianteeman
Copy link
Copy Markdown
Contributor

remove milestone for now

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 12, 2016
@brianteeman
Copy link
Copy Markdown
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10437.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 13, 2016
@brianteeman brianteeman added this to the Joomla 3.6.0 milestone May 13, 2016
@joomla-cms-bot
Copy link
Copy Markdown

This PR has received new commits.

CC: @alikon, @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10437.

@rdeutz rdeutz merged commit f1c382c into joomla:staging May 16, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 16, 2016
@zero-24 zero-24 deleted the patch-32 branch May 16, 2016 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants