[com_categories] Coding standards xml + fix a wrong closing tag#10515
[com_categories] Coding standards xml + fix a wrong closing tag#10515roland-d merged 3 commits intojoomla:stagingfrom
Conversation
Add empty line before opening tags for readability
| size="45" | ||
| hint="JFIELD_ALIAS_PLACEHOLDER" | ||
| size="45"/> | ||
| /> |
There was a problem hiding this comment.
i would put hint after description, because it's also a text var value.
doesn't exist in the coding standards, but makes sense to me.
There was a problem hiding this comment.
I've tried to follow loading order of extra field attributes : https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/form/fields/text.php#L218
But i agree we could write a rule with all often used attributes: default, class, size, hint ...
Here, no defined rules... So tried to keep form field rendering logical with HTML rendering.
|
I have tested this item ✅ successfully on c63a85a This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10515. |
|
@andrepereiradasilva Thanks for testing! (maybe we could work on some extra code standards rules/recommendations? ;-) ) |
|
I have tested this item ✅ successfully on c63a85a However, I have spotted an issue related to the changes to modals recently done and which are already merged into the latest staging. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10515. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10515. |
|
Thanks everybody |
Code standards (https://joomla.github.io/coding-standards/?coding-standards/chapters/xml.md) + correction closing tag, form xml files com_contact
Summary of Changes
categories.xml
models/forms/category.xml
tagsmodels/forms/filter_categories.xml
Testing Instructions