Skip to content

[com_content] modal article edit: Fix for TypeError: window.parent is null#10428

Merged
roland-d merged 1 commit intojoomla:stagingfrom
cyrez:patch-30
May 16, 2016
Merged

[com_content] modal article edit: Fix for TypeError: window.parent is null#10428
roland-d merged 1 commit intojoomla:stagingfrom
cyrez:patch-30

Conversation

@cyrez
Copy link
Copy Markdown
Contributor

@cyrez cyrez commented May 11, 2016

Pull Request for Issue #9935 (comment) .

Summary of Changes

Testing Instructions

With console error opened, on latest staging.

  • Test in Menus > Menu Item type "single article" > Edit article to open the modal to edit article
  • Then click CLOSE button of the modal
  • Go to Articles : Check that the article is not locked (the article edition was well closed)

@cyrez
Copy link
Copy Markdown
Contributor Author

cyrez commented May 12, 2016

@mbabker I don't understand why Travis fails in this PR, about this : c2de752#diff-4287911d5dd8bdce36df239fa55d6b33R619
😣

@andrepereiradasilva
Copy link
Copy Markdown
Contributor

andrepereiradasilva commented May 12, 2016

travis error is because of a long line in this commit (c2de752#diff-4287911d5dd8bdce36df239fa55d6b33R619). Just CS

Unrelated to this PR

@andrepereiradasilva
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 7cbbd7d

Tested and no javascript error on Close the module now.

Travis error is unrelated to this PR.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10428.

@BurtNL
Copy link
Copy Markdown

BurtNL commented May 12, 2016

I have tested this item ✅ successfully on 7cbbd7d


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10428.

@brianteeman
Copy link
Copy Markdown
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10428.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 12, 2016
@brianteeman brianteeman added this to the Joomla 3.6.0 milestone May 12, 2016
@roland-d roland-d merged commit cef2ecd into joomla:staging May 16, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 16, 2016
@roland-d
Copy link
Copy Markdown
Contributor

Thanks everybody

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants