Skip to content

[js message system] Correct js messages class#10521

Merged
Kubik-Rubik merged 1 commit intojoomla:stagingfrom
andrepereiradasilva:js-messages
May 17, 2016
Merged

[js message system] Correct js messages class#10521
Kubik-Rubik merged 1 commit intojoomla:stagingfrom
andrepereiradasilva:js-messages

Conversation

@andrepereiradasilva
Copy link
Copy Markdown
Contributor

@andrepereiradasilva andrepereiradasilva commented May 16, 2016

Summary of Changes

Simple PR to correct the colors and titles of the js messages.

Before

image

After

image

Testing Instructions

  • Go to isis/protostar index.php and add this code
// JS Messages
JText::script('MESSAGE');
JText::script('ERROR');
JText::script('NOTICE');
JText::script('WARNING');

JFactory::getDocument()->addScriptDeclaration("
jQuery(document).ready(function() {
    var messages = {
        'message': ['JS Success Message 1', 'JS Success Message 2'],
        'error': ['JS Error Message 1', 'JS Error Message 2'],
        'notice': ['JS Notice Message 1', 'JS Notice Message 2'],
        'warning': ['JS Warning Message 1', 'JS Warning Message 2']
    };
    Joomla.renderMessages(messages);
});");
  • Now run any isis/protostar page. You'll see the "Before" scenario
  • Apply patch
  • Repeat step 2 (clear browser cache). You will see the "After" scenario.

@brianteeman
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 8575693

Good spot


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10521.

@infograf768
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on 8575693


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10521.

@andrepereiradasilva
Copy link
Copy Markdown
Contributor Author

thanks for testing @brianteeman @infograf768 !

@brianteeman
Copy link
Copy Markdown
Contributor

Rtc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10521.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 17, 2016
@brianteeman brianteeman added this to the Joomla 3.6.0 milestone May 17, 2016
@Kubik-Rubik
Copy link
Copy Markdown
Member

Thank you @andrepereiradasilva and testers!

@Kubik-Rubik Kubik-Rubik merged commit 4052683 into joomla:staging May 17, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 17, 2016
@andrepereiradasilva andrepereiradasilva deleted the js-messages branch May 17, 2016 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants