[js message system] Add close button#10517
Merged
roland-d merged 4 commits intojoomla:stagingfrom May 16, 2016
Merged
Conversation
|
I have tested this item ✅ successfully on 015a289 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10517. |
Contributor
|
I have tested this item ✅ successfully on 015a289 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10517. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10517. |
Contributor
|
Thanks everybody |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This simple PR adds a close button to the JS message system, just like the one that exists for the php message system.
This applies to all js messages (error, warning, success or info messages).
Testing Instructions
Test also on frontend js messages (ex: email remainder or other).