Skip to content

[js message system] Add close button#10517

Merged
roland-d merged 4 commits intojoomla:stagingfrom
andrepereiradasilva:js-close
May 16, 2016
Merged

[js message system] Add close button#10517
roland-d merged 4 commits intojoomla:stagingfrom
andrepereiradasilva:js-close

Conversation

@andrepereiradasilva
Copy link
Copy Markdown
Contributor

@andrepereiradasilva andrepereiradasilva commented May 16, 2016

Summary of Changes

This simple PR adds a close button to the JS message system, just like the one that exists for the php message system.

This applies to all js messages (error, warning, success or info messages).

Testing Instructions

  1. Use latest staging
  2. Go to Menus -> Message -> Add new menu item and Save without any field, you'get a js erro message.
    image
  3. Apply patch, refresh browser cache and repeat the same process, you'll now get a close button in the message (test it)
    image

Test also on frontend js messages (ex: email remainder or other).

@BurtNL
Copy link
Copy Markdown

BurtNL commented May 16, 2016

I have tested this item ✅ successfully on 015a289

Works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10517.

@brianteeman
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 015a289


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10517.

@brianteeman
Copy link
Copy Markdown
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10517.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 16, 2016
@roland-d roland-d merged commit f7f3e2b into joomla:staging May 16, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 16, 2016
@roland-d
Copy link
Copy Markdown
Contributor

Thanks everybody

@andrepereiradasilva andrepereiradasilva deleted the js-close branch May 16, 2016 22:59
@brianteeman brianteeman added this to the Joomla 3.6.0 milestone May 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants