Skip to content

[imp] New lang string for successful language installation#10523

Merged
Kubik-Rubik merged 2 commits intojoomla:stagingfrom
infograf768:lang_string_install_language
May 17, 2016
Merged

[imp] New lang string for successful language installation#10523
Kubik-Rubik merged 2 commits intojoomla:stagingfrom
infograf768:lang_string_install_language

Conversation

@infograf768
Copy link
Copy Markdown
Member

@infograf768 infograf768 commented May 17, 2016 •
edited by brianteeman
Loading

The language string for language installation is the same as used in general install.
COM_INSTALLER_INSTALL_SUCCESS="Installation of the %s was successful."
In the case of general install, the variable is of the type

COM_INSTALLER_TYPE_TYPE_COMPONENT="component"
COM_INSTALLER_TYPE_TYPE_FILE="file"
COM_INSTALLER_TYPE_TYPE_LANGUAGE="language"
COM_INSTALLER_TYPE_TYPE_LIBRARY="library"
COM_INSTALLER_TYPE_TYPE_MODULE="module"
COM_INSTALLER_TYPE_TYPE_PACKAGE="package"
COM_INSTALLER_TYPE_TYPE_PLUGIN="plugin"
COM_INSTALLER_TYPE_TYPE_TEMPLATE="template"

This does not fit with installing a language pack as we get

screen shot 2016-05-17 at 08 20 48

Ugly in any language...

This PR adds a new string for language installation:
COM_INSTALLER_INSTALL_LANGUAGE_SUCCESS="Installation of the <strong>%s</strong> language pack was successful."
Which gives:

screen shot 2016-05-17 at 09 33 12

To test go to administrator/index.php?option=com_installer&view=languages and install any language.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels May 17, 2016
@infograf768
Copy link
Copy Markdown
Member Author

infograf768 commented May 17, 2016

@brianteeman
I can change pack to package
COM_INSTALLER_INSTALL_LANGUAGE_SUCCESS="Installation of the <strong>%s</strong> language package was successful."
if you wish.

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented May 17, 2016

I was wondering if we even need that word at all.
COM_INSTALLER_INSTALL_LANGUAGE_SUCCESS="Installation of the
%s language was successful."

On 17 May 2016 at 08:52, infograf768 notifications@github.com wrote:

@brianteeman https://github.com/brianteeman
I can change pack to package
COM_INSTALLER_INSTALL_LANGUAGE_SUCCESS="Installation of the
%s language package was successful."
if you wish.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10523 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@infograf768
Copy link
Copy Markdown
Member Author

infograf768 commented May 17, 2016

No objection.

@sgagner
Copy link
Copy Markdown

sgagner commented May 17, 2016

I think we can skip "pack" or "package" and just use "language"

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented May 17, 2016

Make it so and I will make it RTC- its a simple and obvious improvement

@imanickam
Copy link
Copy Markdown
Contributor

imanickam commented May 17, 2016

The text phrase "Installation of the %s language was successful." is fine.

@infograf768
Copy link
Copy Markdown
Member Author

infograf768 commented May 17, 2016

Please mark test as successful IN https://issues.joomla.org/tracker/joomla-cms/10523

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented May 17, 2016

I have tested this item ✅ successfully on 940a822

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10523.

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented May 17, 2016

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10523.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 17, 2016
@brianteeman brianteeman added this to the Joomla 3.6.0 milestone May 17, 2016
@sgagner
Copy link
Copy Markdown

sgagner commented May 17, 2016

We could make even simpler like: "%s language is now installed."

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10523.

@infograf768
Copy link
Copy Markdown
Member Author

infograf768 commented May 17, 2016

@sgagner
Stefan, if we were doing that (which indeed could be done), it would not be consequent with other success messages we have all over.
Let's see that, if necessary, for 4.0. 😃

@BurtNL
Copy link
Copy Markdown

BurtNL commented May 17, 2016

I have tested this item ✅ successfully on 940a822

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10523.

1 similar comment
@MATsxm
Copy link
Copy Markdown

MATsxm commented May 17, 2016

I have tested this item ✅ successfully on 940a822

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10523.

@Kubik-Rubik
Copy link
Copy Markdown
Member

Kubik-Rubik commented May 17, 2016

Thank you @infograf768!

@Kubik-Rubik Kubik-Rubik merged commit b61d68c into joomla:staging May 17, 2016
@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented May 17, 2016

@joomla-cms-bot come here and fix the label :P

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 17, 2016
@infograf768 infograf768 deleted the lang_string_install_language branch May 29, 2016 05:45
@brianteeman brianteeman mentioned this pull request Sep 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Language Change This is for Translators

Projects

None yet

Milestone

Joomla 3.6.0

Development

Successfully merging this pull request may close these issues.

9 participants

@infograf768 @brianteeman @sgagner @imanickam @BurtNL @MATsxm @Kubik-Rubik @zero-24 @joomla-cms-bot