[tags & users & libs & beez] Always use htmlspecialchars($str, ENT_COMPAT, 'UTF-8')#10440
[tags & users & libs & beez] Always use htmlspecialchars($str, ENT_COMPAT, 'UTF-8')#10440rdeutz merged 10 commits intojoomla:stagingfrom
Conversation
| </div> | ||
| <div class="pagination"> | ||
| <?php if ($this->params->def('show_pagination_results', 1)) : ?> | ||
| <p class="counter"> |
There was a problem hiding this comment.
is this extra tab correct?
There was a problem hiding this comment.
Yes because itbis in a if see line 92 ;)
There was a problem hiding this comment.
so shouldnt that be
if
tab div
tab tab if
tab tab tab p
There was a problem hiding this comment.
no as the div is on the same hirachie than the if ;)
so
if
tab div
tab if
tab tab p
is correct ;)
There was a problem hiding this comment.
Seems wrong to me - but what do I know ;)
|
I have tested this item ✅ successfully on f346618 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10440. |
|
I have tested this item ✅ successfully on f346618 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10440. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10440. |
|
We always ignore all your comments ;) Cant wait to share a beer or three next week On 13 May 2016 at 21:55, andrepereiradasilva notifications@github.com
Brian Teeman |
|
This PR has received new commits. CC: @alikon, @brianteeman This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10440. |
|
I have fixed the codestyle issue. I hope travis is happy than ;) |
Pull Request for Issue #10399 .
Summary of Changes
Always use htmlspecialchars($str, ENT_COMPAT, 'UTF-8')
Testing Instructions
Please do a code review or test all changed files.