Conversation
This is an attempt at catching this sort of problem in the future. As of now, the test passses.
…e-parsing PB-1491 : Add a test to parse an online kml with the wrong content-type
PB-1300: KML feature selection 3D
PB-1257: add tile debug for COGs
PB-1679: fix local cog file compare
PB-1680 : Fix icon selector border
Text position at center (left, center and right) needs to be pushed down half the height of the description to be placed correctly. The full height of the description needs to be added to the offset when placed at the bottom (bottm_left, bottom and bottom_right)
to better accommodate more button/component in the drawing feature edit use case
…iption-on-the-map PB-1695: add the option to show marker description on the map
Issue : a translation was wrong Fix : a translation was corrected
Quick fix: translation error
The Marker icon has an offset in 2d space, in order to display it anchored on the tip, which cause the offset visible in 3d. Our solution is to add a conditional check in 3d to properly display markers, as all other icons don't have this problem.
PB-1691 : Remove pin and highlight position offset in 3D view
…ind-terrain PB-1357 : Enable depth testing for labels
the CI is currently running the project using preview:dev target, which isn't ideal, because we run the test target locally (it can lead to differences, and failing tests). So here I add a preview:test target, that uses the correcte Vite mode "test", I'll change the CI after this is merged, to use it (and have both local and CI tests using the test target)
and fix filtering, it should be placed before the command (if placed after, it is passed to the command as argument, instead of being interpreted) name main build target simply "build" and not "build-all" anymore.
PB-1754: add missing prewiew:test target in main package json
Refines the CTRL+Click feature selection logic to prevent user confusion when toggling features. Specifically, it ensures that adding new features via CTRL+Click does not occur immediately after deselecting an existing feature at the same location, thus avoiding the impression that the deselect action had no effect.
PB-1068: Add CTRL + Click to Toggle Selected Features
Dynamically configures props for specialized drawing interactions based on the current edit mode. This allows passing specific properties, such as the starting feature for line extensions, to the appropriate interaction component, and not to those that do not need it (which would raise a Vue warning for extraneous props)
one that was raised because we are using an obsolete `watch(fn, options?)` signature the second because some external WMS features didn't have any title, fallback to the feature ID if none is defined
PB-1681: fix vue warnings
PB-120: Fix Selected Feature is not Highlighted in 3D map
set up caching for HTML/JS/CSS files (so that the app can be reloaded even without network), essentials backend items (layers config, topics) and for a limited amount of tiles from our WMS/WMTS the app has loaded while being used.
half our test suites were failing with Service Worker active, so disabling the setup of Service Worker API if we detect that we are in our Cypress tests
as Service Worker is disabled when testing with Cypress, the component that was importing part of the SW API function was failing to build when running Cypress. With this conditional build, it can now be emptied (and especially not import the SW part) when we are running Cypress. This lib needed rollup v4+ so I've set it as such in the overrides of the package.json of the mapviewer package Also adding TypeScript types for all env variables declared through Vite and .env files
the CI was still running in non Cypress mode
causes some issue that it stays active on some CI tests (it still messes up with the loading bar logic when it should be deactivated) taking the opportunity to add a little bit of style to our logging, to better visually differentiate the now huge amount of logs we have in our dev console Add style to store/router sync plugin and fix 2 TS error/lint issues
should reduce the flakiness on some print tests that were running too early This is also "testing" our PostMessage API code, which will later be used to implement our new print service.
Add a SimpleWindow that warns the user he/she should refresh the app because the version of the code that is cached on the device is obsolete add i18n for ServiceWorker updating the existing text for out-of-date data, and adding a new text for the refresh button
PB-1754: add client-side caching through Service Worker API
Issue: In some wms, there exists legends for multiple sub layers, which are available through a SLD-enabled endpoint. We would like to show them Fix: We parse SLD attributes and add legends where there is no `style` element for it, and the `getLegendGraphic` endpoint is enabled
Issue: When importing layers from our own services, a disclaimer was visible, saying the sources were provided by a third party. Fix: We "white list" all sources coming from a "*.map.geo.admin.ch" domain, removing the disclaimer.
… disclaimers exists
…po-external-layers PB-1699: White listing internal services used as an external provider
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 05m 00s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
20
|
|
|
0
|
|
|
254
|
| View all changes introduced in this branch ↗︎ | |
sami-nouidri-swisstopo
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link