PB-1699: White listing internal services used as an external provider#1365
Merged
PB-1699: White listing internal services used as an external provider#1365
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
feat-PB-1699-whitelist-swisstopo-external-layers
|
| Run status |
|
| Run duration | 05m 10s |
| Commit |
|
| Committer | Martin Künzi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
20
|
Skipped
|
0
|
Passing
|
254
|
| View all changes introduced in this branch ↗︎ | |
c7945bc to
6f3a703
Compare
pakb
reviewed
Jun 26, 2025
packages/mapviewer/tests/cypress/fixtures/import-tool/wms-non-geo-admin-get-capabilities.xml
Outdated
Show resolved
Hide resolved
4a23c56 to
7d22bf5
Compare
pakb
reviewed
Jul 1, 2025
packages/mapviewer/tests/cypress/tests-e2e/importToolMaps.cy.js
Outdated
Show resolved
Hide resolved
7d22bf5 to
cd99bd7
Compare
pakb
approved these changes
Jul 1, 2025
Issue: When importing layers from our own services, a disclaimer was visible, saying the sources were provided by a third party. Fix: We "white list" all sources coming from a "*.map.geo.admin.ch" domain, removing the disclaimer.
… disclaimers exists
cd99bd7 to
be0ea61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: When importing layers from our own services, a disclaimer was visible, saying the sources were provided by a third party.
Fix: We "white list" all sources coming from a "*.map.geo.admin.ch" domain, removing the disclaimer.
Test link