PB-1357 : Enable depth testing for labels#1356
Merged
sami-nouidri-swisstopo merged 1 commit intodevelopfrom Jun 2, 2025
Merged
PB-1357 : Enable depth testing for labels#1356sami-nouidri-swisstopo merged 1 commit intodevelopfrom
sami-nouidri-swisstopo merged 1 commit intodevelopfrom
Conversation
6216215 to
b9ffe97
Compare
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
bug-PB-1357-hide-3d-labels-behind-terrain
|
| Run status |
|
| Run duration | 06m 20s |
| Commit |
|
| Committer | Sami Nouidri |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
20
|
Skipped
|
0
|
Passing
|
252
|
| View all changes introduced in this branch ↗︎ | |
b9ffe97 to
28193ce
Compare
pakb
approved these changes
Jun 2, 2025
Contributor
pakb
left a comment
There was a problem hiding this comment.
I don't remember why I disabled that... Let's roll with what you changed, I like it better when it's on, on the "before/after" screenshot you posted.
I'm surprised with the location you selected to showcase your fix 🦅
Contributor
Author
🦅🦅🦅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to fix the issue of labels being shown despite being behind terrain. Previously, it seems we weren't doing any depth testing for labels (perhaps intentionally?) so I've enabled it back.
Before :
After :
Test link