PB-1491 : Add a test to parse an online kml with the wrong content-type#1304
Merged
sami-nouidri-swisstopo merged 2 commits intodevelopfrom May 21, 2025
Merged
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
bug-PB-1491-s3-kml-content-type-parsing
|
| Run status |
|
| Run duration | 05m 56s |
| Commit |
|
| Committer | Sami Nouidri |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
20
|
Skipped
|
0
|
Passing
|
251
|
| View all changes introduced in this branch ↗︎ | |
87aa985 to
b60da16
Compare
pakb
reviewed
Apr 17, 2025
5149199 to
1f8f146
Compare
pakb
reviewed
Apr 22, 2025
packages/mapviewer/tests/cypress/tests-e2e/importToolFile.cy.js
Outdated
Show resolved
Hide resolved
packages/mapviewer/tests/cypress/tests-e2e/importToolFile.cy.js
Outdated
Show resolved
Hide resolved
cd45818 to
28bac2b
Compare
pakb
reviewed
Apr 24, 2025
28bac2b to
49aaf03
Compare
7ca9e69 to
a5ea6b6
Compare
fcc79ad to
13848d9
Compare
pakb
reviewed
May 19, 2025
| .contains(errorMessage) | ||
|
|
||
| // Mouseout to remove tooltip | ||
| cy.wrap($layer).trigger('mouseout', { force: true }) |
Contributor
There was a problem hiding this comment.
not sure this will really be removing the tooltip, as you are triggering the mouseout on a different element than the mouseover.
Might be a good idea to replicate the selector above and add the missing .find('[data-cy^="button-has-error"]') before triggering the event
| ).click({ | ||
| force: true, | ||
| }) | ||
| cy.get(`[data-cy^="button-remove-layer-${invalidFileOnlineUrl}-"]:visible`).click({ |
Contributor
There was a problem hiding this comment.
why is there a trailing - at the end here?
If the HTML is rendered with that character, I'd prefer we remove it, it's not "nice" 😉
80c5dd0 to
7d2c40c
Compare
This is an attempt at catching this sort of problem in the future. As of now, the test passses.
7d2c40c to
37f0161
Compare
37f0161 to
c3008a3
Compare
c3008a3 to
12cb974
Compare
pakb
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt at catching this sort of problem in the future. As of now, the test passses.
Test link