PB-1680 : Fix icon selector border#1350
Merged
sami-nouidri-swisstopo merged 1 commit intodevelopfrom May 22, 2025
Merged
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
bug-PB-1680-icon-selector-bug
|
| Run status |
|
| Run duration | 06m 13s |
| Commit |
|
| Committer | Sami Nouidri |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
20
|
Skipped
|
0
|
Passing
|
252
|
| View all changes introduced in this branch ↗︎ | |
pakb
reviewed
May 22, 2025
| <div | ||
| v-if="currentIconSet && currentIconSet.icons.length > 0" | ||
| class="icon-selector border-2 bg-light rounded" | ||
| class="icon-selector bg-light rounded border border-gray-300" |
Contributor
There was a problem hiding this comment.
wait... border-gray-300 that's some Tailwind???
how the hell is this not prefixed by tw:? I'm confused
Contributor
Author
There was a problem hiding this comment.
It's listed here : https://tailwindcss.com/docs/border-color
Contributor
There was a problem hiding this comment.
yeah, but we import Tailwind with @import 'tailwindcss' prefix(tw) important;, so it should be tw:border-gray-300, so why is it still interpreted?
That's a huge deal, as the class border is the same in both library, so if we now know that Tailwind doesn't care about our prefix, and still applies its classes without the prefix, we should move to Tailwind ASAP instead of keeping Bootstrap alongside it
pakb
approved these changes
May 22, 2025
8631eb5 to
a8fe2c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also changed the border class to be tailwind-compliant
Here's the result :
Test link