PB-1703: Add support for .png files in reportProblem window#1355
Merged
sami-nouidri-swisstopo merged 1 commit intodevelopfrom May 28, 2025
Merged
Conversation
pakb
reviewed
May 27, 2025
| "feedback_more_info_url": "https://www.geo.admin.ch/de/kartenviewer-navigation-und-orientierung#Problem-melden", | ||
| "feedback_permalink": "Folgender Link wird übermittelt: ", | ||
| "feedback_placeholder": "Fügen Sie eine .pdf, .zip, .jpg, .jpeg, .kml, .kmz oder .gpx Datei hinzu", | ||
| "feedback_placeholder": "Fügen Sie eine .pdf, .zip, .jpg, .jpeg, png, .kml, .kmz oder .gpx Datei hinzu", |
Contributor
There was a problem hiding this comment.
other file format have a . in German, please add it too
| "feedback_more_info_url": "https://www.geo.admin.ch/de/kartenviewer-navigation-und-orientierung#Problem-melden#Die-Problem-Melden-Kategorien", | ||
| "feedback_permalink": "Il suandant link vegn transmess:", | ||
| "feedback_placeholder": "Agiuntai ina datoteca .pdf, .zip, .jpg, .jpeg, .kml, .kmz u .gpx", | ||
| "feedback_placeholder": "Agiuntai ina datoteca .pdf, .zip, .jpg, .jpeg, png, .kml, .kmz u .gpx", |
Contributor
There was a problem hiding this comment.
same here, it needs a . to match the others
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
task-PB-1703-allow-png-report-problem
|
| Run status |
|
| Run duration | 06m 12s |
| Commit |
|
| Committer | Sami Nouidri |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
20
|
Skipped
|
0
|
Passing
|
252
|
| View all changes introduced in this branch ↗︎ | |
419aa6c to
86486f6
Compare
pakb
reviewed
May 28, 2025
$
Outdated
Contributor
There was a problem hiding this comment.
I don't think this file/data should be added to your git commit
86486f6 to
c052b80
Compare
pakb
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be merged after the changes made to the
service-feedbackbackendTest link