PB-120: Fix Selected Feature is not Highlighted in 3D map#1366
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses PB-120 by ensuring that the selected feature is properly highlighted in the 3D map. The changes rework the highlightPolygon function to recursively handle both single and multi-polygon geometries, and they add descriptive comments to improve code clarity.
- Refactored highlightPolygon to handle multi-level coordinate arrays.
- Introduced a recursive getAllPolygonEntities function for better flexibility.
- Added explanatory comments for improved readability.
packages/mapviewer/src/modules/map/components/cesium/utils/highlightUtils.js
Show resolved
Hide resolved
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
bug-pb-120-cesium-highlight
|
| Run status |
|
| Run duration | 05m 09s |
| Commit |
|
| Committer | Ismail Sunni |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
20
|
Skipped
|
0
|
Passing
|
253
|
| View all changes introduced in this branch ↗︎ | |
sommerfe
approved these changes
Jun 18, 2025
pakb
reviewed
Jun 18, 2025
packages/mapviewer/src/modules/map/components/cesium/utils/highlightUtils.js
Show resolved
Hide resolved
9fdd4c2 to
ec172c8
Compare
pakb
approved these changes
Jun 26, 2025
ec172c8 to
ac2d43a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link