PB-1695: add the option to show marker description on the map#1339
Merged
PB-1695: add the option to show marker description on the map#1339
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
feat-PB-1695-show-marker-description-on-the-map
|
| Run status |
|
| Run duration | 05m 45s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
20
|
Skipped
|
0
|
Passing
|
252
|
| View all changes introduced in this branch ↗︎ | |
1691d0d to
98a7fa3
Compare
sommerfe
reviewed
May 19, 2025
packages/mapviewer/src/modules/infobox/components/styling/FeatureStyleEdit.vue
Outdated
Show resolved
Hide resolved
sommerfe
reviewed
May 19, 2025
Contributor
Maybe it could be enhanced a little bit: it isn't entirely clear "what" it's supposed to display on the map... Maybe you could increase the margin between the upper text input and the "Description" Label a little bit, then it's clearer that the toggle belongs just to the description (see arrows): on that note, the margins above and below the textarea aren't the same (see highlight) |
98a7fa3 to
4dbcbbe
Compare
4dbcbbe to
0c9efb4
Compare
Text position at center (left, center and right) needs to be pushed down half the height of the description to be placed correctly. The full height of the description needs to be added to the offset when placed at the bottom (bottm_left, bottom and bottom_right)
to better accommodate more button/component in the drawing feature edit use case
0c9efb4 to
b3bcfde
Compare
sommerfe
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new checkbox on the feature detail/edit to opt-in and show the description on the map
Test link