PB-1754: use "test" npm targets also on the CI#1360
Merged
Conversation
the CI is currently running the project using preview:dev target, which isn't ideal, because we run the test target locally (it can lead to differences, and failing tests). So here I add a preview:test target, that uses the correcte Vite mode "test", I'll change the CI after this is merged, to use it (and have both local and CI tests using the test target)
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
feat-PB-1754-use-test-target-on-CI
|
| Run status |
|
| Run duration | 05m 47s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
20
|
Skipped
|
0
|
Passing
|
252
|
| View all changes introduced in this branch ↗︎ | |
sommerfe
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the CI is currently running the project using preview:dev target, which isn't ideal, because we run the test target locally (it can lead to differences, and failing tests).
So here I add a preview:test target, that uses the correcte Vite mode "test", I'll change the CI after this is merged, to use it (and have both local and CI tests using the test target)
Test link