PB-1754: add missing prewiew:test target in main package json#1361
Merged
PB-1754: add missing prewiew:test target in main package json#1361
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
feat-PB-1754-fix-pnpm-filters
|
| Run status |
|
| Run duration | 07m 30s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
20
|
Skipped
|
0
|
Passing
|
252
|
| View all changes introduced in this branch ↗︎ | |
schtibe
approved these changes
Jun 5, 2025
package.json
Outdated
| "build:int": "pnpm -r run build:int", | ||
| "build:prod": "pnpm -r run build:prod", | ||
| "dev": "pnpm run -r --filter=web-mapviewer dev ", | ||
| "build-all": "pnpm run --recursive build", |
Contributor
There was a problem hiding this comment.
(I've been having this thought for quite some time now) I think we could change this back to just build. Then we would follow more a standard way again.
I think I did that because I ended up with a sort of infinite recursion, probably before I fully understood this stuff, but I don't see now why this should still happen.
Contributor
Author
There was a problem hiding this comment.
Works well too, and sticks to standard target name. I'll change it to simply build, and adapt the CI if needed
Contributor
There was a problem hiding this comment.
Yes I think it's in the buildspec, too.
Contributor
Author
There was a problem hiding this comment.
sommerfe
approved these changes
Jun 5, 2025
and fix filtering, it should be placed before the command (if placed after, it is passed to the command as argument, instead of being interpreted) name main build target simply "build" and not "build-all" anymore.
a8fa92a to
b1bc38d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and fix filtering, it should be placed before the command (if placed after, it is passed to the command as argument, instead of being interpreted)
Test link