Skip to content

chore(release): 1.117.0#15900

Merged
otaviomacedo merged 49 commits intoreleasefrom
bump/1.117.0
Aug 5, 2021
Merged

chore(release): 1.117.0#15900
otaviomacedo merged 49 commits intoreleasefrom
bump/1.117.0

Conversation

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation commented Aug 5, 2021

See CHANGELOG

mergify bot and others added 30 commits July 28, 2021 14:23
Since context passed via command line overrides the App context, setting newStyleSynthesis in the pipeline integration tests will not work since in the v2 branch we set newStyleSynth to “false” explicitly in cdk-integ.

Introduce a new cdk-integ pragma that can be used to override this context and use it for pipelines integration tests.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
https://aws.amazon.com/about-aws/whats-new/2020/06/announcing-aws-privatelink-support-for-amazon-transcribe-real-time-streaming/

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…14817)

This PR address #4702

I am primarily solving for the use case of using SNS publish with
message attributes for sns filtering. If EventBridge integrations have a
fast follow for wait for task token features, that would solve my use
case. Because I'm solving for filtering and based on anecdotal
experience String is the primary attribute type. I've included Binary
because the pattern is the same. I have not implemented Number or
String.Array because they are not Lambda supported and I believe less
common.

I chose to attempt to solve for consumer ergonomics with:

```ts
    const task = new SnsPublish(stack, 'Publish', {
      topic,
      message: sfn.TaskInput.fromText('Publish this message'),
      messageAttributes: {
        cake: {
          type: SnsMessageAttributeType.STRING,
          value: sfn.TaskInput.fromText('chocolate'),
        },
        cakePic: {
          type: SnsMessageAttributeType.BINARY,
          value: sfn.TaskInput.fromDataAt('$.cake.pic'),
        },
      },
    });
```

This results in a `value` member on the message attribute interface.
While I think that maps best for the SNS json definition and does yield
this ugly line in the private render methods:

```
      attrs[a][`${attr.type}Value`] = attr.value.value;
```

Is there a better way?

I did not implement SQS message attributes yet. Based on my limited
knowledge the StepFunction integrations are similar(potentially
identical if we again only support Binary and String). If the answer is
one implementation, should I move the below code snippets into something
generically named MessageAttribute within the stepfunctions package
perhaps as part of base-task?

```ts
/**
 * SNS Message Attribute type enum
 */
export enum SnsMessageAttributeType {

  /**
   * String type attributes.
   *
   * @see https://docs.aws.amazon.com/sns/latest/dg/sns-message-attributes.html#SNSMessageAttributes.DataTypes
   */
  STRING = 'String',

  /**
   * Binary type attributes.
   *
   * @see https://docs.aws.amazon.com/sns/latest/dg/sns-message-attributes.html#SNSMessageAttributes.DataTypes
   */
  BINARY = 'Binary',
}

/**
 * SNS Message Attribute
 */
export interface SnsMessageAttribute {
  /**
   * MessageAttributeType is the type of data being passed.
   *
   *
   * @see https://docs.aws.amazon.com/sns/latest/dg/sns-message-attributes.html#SNSMessageAttributes.DataTypes
   */
  readonly type: SnsMessageAttributeType;

  /**
   * The value of the data being passed
   */
  readonly value: sfn.TaskInput;
}
```
…15803)

closes #15697


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Closes #15543 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…veryStream (#15547)

Closes #15546 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
… delivery stream destinations (#15550)

Closes #15548 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…3 destination (#15552)

Closes #15551 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
docs(s3): let sample code can work, after copy and paste.
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Closes #15554

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…eliveryStream (#15558)

Closes #15555 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Allows cloudfront web distribution to be enabled or disabled. This prop is available in `Distribution` but not `CloudFrontWebDistribution`


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Closes #15703

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Closes #12489

This allows a user to configure Lambda Insights and have the relevant IAM policy be added to the Lambda role.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Fail flag is only used inside the diff command. Currently, the fail option is tied down to the toolkit itself as opposed to the diff command. While this doesn't create issues in execution because we dont pass `argv.fail` to anything but `diff`, we should just fix it.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…ttpApiEndpoint task definition (#15755)

`this.stageName` was not initialized by `props.stageName` when calling `CallApiGatewayHttpApiEndpoint`'s constructor, therefore causing the `Stage` field to not get rendered even though we specified that property.

fixes #14242

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…rizationConfig (#15830)

fixes: #15039

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Support Kubernetes 1.21

Closes #15758.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…meters. (#15487)

----
Added logic similar to AutoscalngGroup    module to allow EKS NodeGroups to accept CfnParameters for desiredsize minsize and maxsize as CfnParameter.valueAsNumber. 

Helps with issue #15485
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This PR adds a couple of basic SubnetFilters into the CDK directly so they don't have to be needlessly reimplemented.  The `SubnetIdSubnetFilter` filters subnets by ID and the `CidrMaskSubnetFilter` filters subnets based on the CIDR netmask.

closes #15228
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
**Closes [#12872](#12872 - Origin Shield is a part of the CfnDistribution resources but has not yet been added to the relevant CloudFront constructs. These changes add `originShieldRegion` fields to `OriginProps` and `SourceConfiguration` as specified [here](#12872 (comment)) as well as update the ReadMe and all the necessary tests.

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…ationRecord (#15782)

add support for RemovalPolicy in CrossAccountZoneDelegationRecord

closes #15211

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Fixes an issue where unresolved Listener `priority` would resolve in Error: `Priority must have value greater than or equal to 1`.

This adds support for cases where the Listener `priority` can be supplied through CloudFormation Template Parameters.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…packages (#15826)

Remove all hard coded references to the @aws-cdk/aws-lambda and @aws-cdk/aws-lambda-go packages from the tests which should fix the issue that prevent building the aws-cdk-lib package.

Resolves #15585


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
fixes: #15831

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
… (under feature flag) (#15477)

This pull request adds the new TLSv1.2_2021 security policy to the respective enum and adds the feature flag `@aws-cdk/aws-cloudfront:defaultSecurityPolicyTLSv1.2_2021`, which, when enabled, causes distributions to use the new security policy by default.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Feature flags -- by definition -- don't introduce breaking changes to existing
customers, simply alter behavior for new apps, or allow opting in to new
behavior. Additionally, our linter does not allow breaking changes in stable
modules, which means as stands it's impossible to satisfy this requirement and
introduce a feature flag for stable modules.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
#15725)

Closes #15724 


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
arcrank and others added 15 commits July 30, 2021 19:57
Add ability to configure parameter options for when launching a product.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*


Co-authored-by: Dillon Ponzo <dponzo18@gmail.com>
…5819)

Fixes #15711.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
The class `TemplateAssertions` is already part of the
`@aws-cdk/assertions` module. The word 'assertions' is redundant.

Further, this class now has the method `findResources()` which is not an
assertion.
All assertion methods are named in a way that makes it clear that it is
an assertion, viz., `hasResource()`, `resourceCountIs()`,
`templateMatches()`.

BREAKING CHANGE: `TemplateAssertions` is now renamed to
`Template`.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Add support for BucketDeployment accessControl property to aws-s3-deployment package.

This is needed to run, for example, `aws s3 sync` with `--acl bucket-owner-full-control`.
Without this feature there is no easy way (without hacking cdk nodes) to sync assets to bucket located in another account.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…s for tokenized values (#15849)

A SlackChannelConfiguration can be imported using `fromSlackChannelConfigurationArn`. In this method, the given ARN will be validated. However, the validation failed for tokenized values.
The validation was enhanced. The ARN validation will be only executed if the ARN can be resolved. For unresolved tokens, the validation will be skipped.

Closes #15842.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
#15870)



----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Added a method `Template.toJSON()` to get the object
representation of the CloudFormation template.
This is most useful for snapshot testing.

BREAKING CHANGE: `Template.fromTemplate()` is now
renamed to `Template.fromJSON()` to provide clarity.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Switch all current cfn-only packages to depend on
`assertions` instead of `assert`.

Update `example-construct-library` to showcase using
the `assertions` module.

Update `cfnspec` so that new packages are created with
the `assertions` module.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Happens because `python3.8` doesn't support inline code (i.e `ZipFile`) in some regions. 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Co-authored-by: AWS CDK Team <aws-cdk@amazon.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Setting the lower and upper bound breaks the build on Windows.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…ry stream (#15836)

closes #15500 
closes #10783 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Aug 5, 2021

@aws-cdk-automation aws-cdk-automation added the pr/no-squash This PR should be merged instead of squash-merging it label Aug 5, 2021
@otaviomacedo otaviomacedo requested a review from a team August 5, 2021 08:14
@nija-at nija-at added the pr/do-not-merge This PR should not be merged at this time. label Aug 5, 2021
Copy link
Copy Markdown
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provisional approval. see comments below

otaviomacedo and others added 3 commits August 5, 2021 10:05
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 275e6b6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@otaviomacedo otaviomacedo removed the pr/do-not-merge This PR should not be merged at this time. label Aug 5, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 5, 2021

Thank you for contributing! Your pull request will be automatically updated and merged without squashing (do not update manually, and be sure to allow changes to be pushed to your fork).

@otaviomacedo otaviomacedo merged commit 0047c98 into release Aug 5, 2021
@otaviomacedo otaviomacedo deleted the bump/1.117.0 branch August 5, 2021 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/no-squash This PR should be merged instead of squash-merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.