Merged
Conversation
Since context passed via command line overrides the App context, setting newStyleSynthesis in the pipeline integration tests will not work since in the v2 branch we set newStyleSynth to “false” explicitly in cdk-integ. Introduce a new cdk-integ pragma that can be used to override this context and use it for pipelines integration tests. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
https://aws.amazon.com/about-aws/whats-new/2020/06/announcing-aws-privatelink-support-for-amazon-transcribe-real-time-streaming/ ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…14817) This PR address #4702 I am primarily solving for the use case of using SNS publish with message attributes for sns filtering. If EventBridge integrations have a fast follow for wait for task token features, that would solve my use case. Because I'm solving for filtering and based on anecdotal experience String is the primary attribute type. I've included Binary because the pattern is the same. I have not implemented Number or String.Array because they are not Lambda supported and I believe less common. I chose to attempt to solve for consumer ergonomics with: ```ts const task = new SnsPublish(stack, 'Publish', { topic, message: sfn.TaskInput.fromText('Publish this message'), messageAttributes: { cake: { type: SnsMessageAttributeType.STRING, value: sfn.TaskInput.fromText('chocolate'), }, cakePic: { type: SnsMessageAttributeType.BINARY, value: sfn.TaskInput.fromDataAt('$.cake.pic'), }, }, }); ``` This results in a `value` member on the message attribute interface. While I think that maps best for the SNS json definition and does yield this ugly line in the private render methods: ``` attrs[a][`${attr.type}Value`] = attr.value.value; ``` Is there a better way? I did not implement SQS message attributes yet. Based on my limited knowledge the StepFunction integrations are similar(potentially identical if we again only support Binary and String). If the answer is one implementation, should I move the below code snippets into something generically named MessageAttribute within the stepfunctions package perhaps as part of base-task? ```ts /** * SNS Message Attribute type enum */ export enum SnsMessageAttributeType { /** * String type attributes. * * @see https://docs.aws.amazon.com/sns/latest/dg/sns-message-attributes.html#SNSMessageAttributes.DataTypes */ STRING = 'String', /** * Binary type attributes. * * @see https://docs.aws.amazon.com/sns/latest/dg/sns-message-attributes.html#SNSMessageAttributes.DataTypes */ BINARY = 'Binary', } /** * SNS Message Attribute */ export interface SnsMessageAttribute { /** * MessageAttributeType is the type of data being passed. * * * @see https://docs.aws.amazon.com/sns/latest/dg/sns-message-attributes.html#SNSMessageAttributes.DataTypes */ readonly type: SnsMessageAttributeType; /** * The value of the data being passed */ readonly value: sfn.TaskInput; } ```
Closes #15543 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
docs(s3): let sample code can work, after copy and paste. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Closes #15554 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Allows cloudfront web distribution to be enabled or disabled. This prop is available in `Distribution` but not `CloudFrontWebDistribution` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Closes #15703 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Closes #12489 This allows a user to configure Lambda Insights and have the relevant IAM policy be added to the Lambda role. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Fail flag is only used inside the diff command. Currently, the fail option is tied down to the toolkit itself as opposed to the diff command. While this doesn't create issues in execution because we dont pass `argv.fail` to anything but `diff`, we should just fix it. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…ttpApiEndpoint task definition (#15755) `this.stageName` was not initialized by `props.stageName` when calling `CallApiGatewayHttpApiEndpoint`'s constructor, therefore causing the `Stage` field to not get rendered even though we specified that property. fixes #14242 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Support Kubernetes 1.21 Closes #15758. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…meters. (#15487) ---- Added logic similar to AutoscalngGroup module to allow EKS NodeGroups to accept CfnParameters for desiredsize minsize and maxsize as CfnParameter.valueAsNumber. Helps with issue #15485 *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This PR adds a couple of basic SubnetFilters into the CDK directly so they don't have to be needlessly reimplemented. The `SubnetIdSubnetFilter` filters subnets by ID and the `CidrMaskSubnetFilter` filters subnets based on the CIDR netmask. closes #15228 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
**Closes [#12872](#12872 - Origin Shield is a part of the CfnDistribution resources but has not yet been added to the relevant CloudFront constructs. These changes add `originShieldRegion` fields to `OriginProps` and `SourceConfiguration` as specified [here](#12872 (comment)) as well as update the ReadMe and all the necessary tests. *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Fixes an issue where unresolved Listener `priority` would resolve in Error: `Priority must have value greater than or equal to 1`. This adds support for cases where the Listener `priority` can be supplied through CloudFormation Template Parameters. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…packages (#15826) Remove all hard coded references to the @aws-cdk/aws-lambda and @aws-cdk/aws-lambda-go packages from the tests which should fix the issue that prevent building the aws-cdk-lib package. Resolves #15585 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
fixes: #15831 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
… (under feature flag) (#15477) This pull request adds the new TLSv1.2_2021 security policy to the respective enum and adds the feature flag `@aws-cdk/aws-cloudfront:defaultSecurityPolicyTLSv1.2_2021`, which, when enabled, causes distributions to use the new security policy by default. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Feature flags -- by definition -- don't introduce breaking changes to existing customers, simply alter behavior for new apps, or allow opting in to new behavior. Additionally, our linter does not allow breaking changes in stable modules, which means as stands it's impossible to satisfy this requirement and introduce a feature flag for stable modules. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Add ability to configure parameter options for when launching a product. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* Co-authored-by: Dillon Ponzo <dponzo18@gmail.com>
The class `TemplateAssertions` is already part of the `@aws-cdk/assertions` module. The word 'assertions' is redundant. Further, this class now has the method `findResources()` which is not an assertion. All assertion methods are named in a way that makes it clear that it is an assertion, viz., `hasResource()`, `resourceCountIs()`, `templateMatches()`. BREAKING CHANGE: `TemplateAssertions` is now renamed to `Template`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Add support for BucketDeployment accessControl property to aws-s3-deployment package. This is needed to run, for example, `aws s3 sync` with `--acl bucket-owner-full-control`. Without this feature there is no easy way (without hacking cdk nodes) to sync assets to bucket located in another account. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…s for tokenized values (#15849) A SlackChannelConfiguration can be imported using `fromSlackChannelConfigurationArn`. In this method, the given ARN will be validated. However, the validation failed for tokenized values. The validation was enhanced. The ARN validation will be only executed if the ARN can be resolved. For unresolved tokens, the validation will be skipped. Closes #15842. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
#15870) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Added a method `Template.toJSON()` to get the object representation of the CloudFormation template. This is most useful for snapshot testing. BREAKING CHANGE: `Template.fromTemplate()` is now renamed to `Template.fromJSON()` to provide clarity. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Switch all current cfn-only packages to depend on `assertions` instead of `assert`. Update `example-construct-library` to showcase using the `assertions` module. Update `cfnspec` so that new packages are created with the `assertions` module. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Happens because `python3.8` doesn't support inline code (i.e `ZipFile`) in some regions. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Co-authored-by: AWS CDK Team <aws-cdk@amazon.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Setting the lower and upper bound breaks the build on Windows. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
nija-at
approved these changes
Aug 5, 2021
Contributor
nija-at
left a comment
There was a problem hiding this comment.
provisional approval. see comments below
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
Collaborator
Author
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be automatically updated and merged without squashing (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See CHANGELOG