feat(kinesisfirehose): add support for backing up source records to S3#15725
Merged
mergify[bot] merged 218 commits intomasterfrom Jul 30, 2021
Merged
feat(kinesisfirehose): add support for backing up source records to S3#15725mergify[bot] merged 218 commits intomasterfrom
mergify[bot] merged 218 commits intomasterfrom
Conversation
…roperty type and use local var instead
skinny85
approved these changes
Jul 29, 2021
| private getS3BackupMode(): string | undefined { | ||
| return this.props.s3Backup?.bucket || this.props.s3Backup?.mode === BackupMode.ALL | ||
| ? 'Enabled' | ||
| : undefined; |
Contributor
There was a problem hiding this comment.
I would probably return undefined here only if this.props. s3Backup was undefined. But that's a super minor nitpick.
…adeline-k/feat/kinesisfirehose-dataprocessors
…deline-k/feat/kinesisfirehose-backup
skinny85
previously approved these changes
Jul 29, 2021
packages/@aws-cdk/aws-kinesisfirehose-destinations/lib/common.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-kinesisfirehose-destinations/lib/common.ts
Outdated
Show resolved
Hide resolved
Base automatically changed from
madeline-k/feat/kinesisfirehose-dataprocessors
to
master
July 29, 2021 17:48
d1a6905
Contributor
BenChaimberg
left a comment
There was a problem hiding this comment.
LGTM, I'll let Adam take a final look
skinny85
approved these changes
Jul 30, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
david-doyle-as24
pushed a commit
to david-doyle-as24/aws-cdk
that referenced
this pull request
Sep 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15724
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license