Skip to content

chore(assert): set only lower bound of the jest dependency#15887

Merged
mergify[bot] merged 3 commits intoaws:masterfrom
otaviomacedo:jest-26-and-above
Aug 4, 2021
Merged

chore(assert): set only lower bound of the jest dependency#15887
mergify[bot] merged 3 commits intoaws:masterfrom
otaviomacedo:jest-26-and-above

Conversation

@otaviomacedo
Copy link
Copy Markdown
Contributor

@otaviomacedo otaviomacedo commented Aug 4, 2021

Setting the lower and upper bound breaks the build on Windows.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@otaviomacedo otaviomacedo requested review from nija-at and njlynch August 4, 2021 09:34
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Aug 4, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 4, 2021
@otaviomacedo otaviomacedo changed the title fix(assert): version range breaks on Windows chore(assert): version range breaks on Windows Aug 4, 2021
@otaviomacedo otaviomacedo changed the title chore(assert): version range breaks on Windows chore(assert): set only lower bound of the jest dependency Aug 4, 2021
Copy link
Copy Markdown
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully once 28 is release it'll work. 🤞

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 4, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: c68538a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 6bd1ff8 into aws:master Aug 4, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 4, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
Setting the lower and upper bound breaks the build on Windows.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this pull request Sep 7, 2021
Setting the lower and upper bound breaks the build on Windows.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants