chore(assertions): migrate more modules to use assertions#15857
Merged
mergify[bot] merged 24 commits intomasterfrom Aug 3, 2021
Merged
chore(assertions): migrate more modules to use assertions#15857mergify[bot] merged 24 commits intomasterfrom
mergify[bot] merged 24 commits intomasterfrom
Conversation
added 15 commits
August 2, 2021 15:11
|
|
BenChaimberg
reviewed
Aug 2, 2021
Comment on lines
+270
to
+272
| expect(Template.fromStack(stack).findResources('AWS::ApiGatewayV2::VpcLink', { | ||
| Name: 'Link-2', | ||
| }); | ||
| }).length).toEqual(0); |
Contributor
There was a problem hiding this comment.
This feels a little clunky...is there a plan to add resource properties to resourceCountIs? Or for supporting a not operator that catches assertion errors/throws if nothing was thrown?
eladb
reviewed
Aug 3, 2021
added 3 commits
August 3, 2021 08:59
added 2 commits
August 3, 2021 11:05
added 3 commits
August 3, 2021 12:15
eladb
approved these changes
Aug 3, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Aug 3, 2021
Added a method `Template.toJSON()` to get the object representation of the CloudFormation template. This is most useful for snapshot testing. BREAKING CHANGE: `Template.fromTemplate()` is now renamed to `Template.fromJSON()` to provide clarity. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
Added a method `Template.toJSON()` to get the object representation of the CloudFormation template. This is most useful for snapshot testing. BREAKING CHANGE: `Template.fromTemplate()` is now renamed to `Template.fromJSON()` to provide clarity. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24
pushed a commit
to david-doyle-as24/aws-cdk
that referenced
this pull request
Sep 7, 2021
Added a method `Template.toJSON()` to get the object representation of the CloudFormation template. This is most useful for snapshot testing. BREAKING CHANGE: `Template.fromTemplate()` is now renamed to `Template.fromJSON()` to provide clarity. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a method
Template.toJSON()to get the objectrepresentation of the CloudFormation template.
This is most useful for snapshot testing.
BREAKING CHANGE:
Template.fromTemplate()is nowrenamed to
Template.fromJSON()to provide clarity.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license