fix(aws-eks): Allow desiredsize minsize and maxsize to accept CfnParameters.#15487
fix(aws-eks): Allow desiredsize minsize and maxsize to accept CfnParameters.#15487mergify[bot] merged 3 commits intoaws:masterfrom
Conversation
|
|
| cluster: cluster, | ||
| minSize: cdk.Lazy.number({ produce: () => 2 }), | ||
| maxSize: cdk.Lazy.number({ produce: () => 6 }), | ||
| desiredSize: cdk.Lazy.number({ produce: () => 4 }), |
There was a problem hiding this comment.
Since the desired size is within the [min, max] bound, we can't really tell from this test that validation is not being performed. For all we know, it might have been performed and passed.
There was a problem hiding this comment.
Ah, got it, updated to show:
minSize: cdk.Lazy.number({ produce: () => 5 }),
maxSize: cdk.Lazy.number({ produce: () => 1 }),
desiredSize: cdk.Lazy.number({ produce: () => 20 }),Updated test eks nodegroup values
otaviomacedo
left a comment
There was a problem hiding this comment.
Looks good. Thanks!
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…meters. (aws#15487) ---- Added logic similar to AutoscalngGroup module to allow EKS NodeGroups to accept CfnParameters for desiredsize minsize and maxsize as CfnParameter.valueAsNumber. Helps with issue aws#15485 *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…meters. (aws#15487) ---- Added logic similar to AutoscalngGroup module to allow EKS NodeGroups to accept CfnParameters for desiredsize minsize and maxsize as CfnParameter.valueAsNumber. Helps with issue aws#15485 *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Added logic similar to AutoscalngGroup module to allow EKS NodeGroups to accept CfnParameters for desiredsize minsize and maxsize as CfnParameter.valueAsNumber.
Helps with issue #15485
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license