Skip to content

feat(aws-cloudfront): add enabled to web distribution#15433

Merged
mergify[bot] merged 4 commits intoaws:masterfrom
iRoachie:ft/web-distribution-enable
Jul 29, 2021
Merged

feat(aws-cloudfront): add enabled to web distribution#15433
mergify[bot] merged 4 commits intoaws:masterfrom
iRoachie:ft/web-distribution-enable

Conversation

@iRoachie
Copy link
Copy Markdown
Contributor

@iRoachie iRoachie commented Jul 6, 2021 •
edited
Loading

Allows cloudfront web distribution to be enabled or disabled. This prop is available in Distribution but not CloudFrontWebDistribution

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jul 6, 2021

@iRoachie iRoachie changed the title feat(aws-cloudfront): add enabled to web distribution fix(aws-cloudfront): add enabled to web distribution Jul 6, 2021
@iRoachie
Copy link
Copy Markdown
Contributor Author

iRoachie commented Jul 6, 2021

cc @njlynch

@peterwoodworth
Copy link
Copy Markdown
Contributor

peterwoodworth commented Jul 6, 2021

Why is this a fix and not a feat?

@iRoachie
Copy link
Copy Markdown
Contributor Author

iRoachie commented Jul 6, 2021

@peterwoodworth Wasn't sure since it's a "missing" field. Happy to change if that's what it should be.

Oh also feat requires a change to readme (pr-linter) but this is an optional field. Thoughts?

@peterwoodworth
Copy link
Copy Markdown
Contributor

peterwoodworth commented Jul 6, 2021

We don't say we currently support this in our CloudFrontWebDistribution construct, so this would be a feat as it is adding new functionality to an L2 construct. There are many L2 constructs you could say have "missing" fields given that you can adjust them in their respective L1 constructs, so this isn't out of the ordinary 😄

I'll make it so an update to the readme isn't mandatory for this PR

Thank you for submitting this PR by the way, is there an issue that this PR will close?

@iRoachie
Copy link
Copy Markdown
Contributor Author

iRoachie commented Jul 6, 2021 •
edited
Loading

Sure np. No issue is open for it currently; came across it today needed to do a massive update at work :D

@peterwoodworth peterwoodworth added @aws-cdk/aws-cloudfront Related to Amazon CloudFront pr-linter/exempt-readme The PR linter will not require README changes labels Jul 6, 2021
@iRoachie
feat(aws-cloudfront): add enabled to web distribution
7e8d954 
Allows cloudfront web distribution to be enabled or disabled.
@iRoachie iRoachie changed the title fix(aws-cloudfront): add enabled to web distribution feat(aws-cloudfront): add enabled to web distribution Jul 6, 2021
@iRoachie
Copy link
Copy Markdown
Contributor Author

iRoachie commented Jul 6, 2021

@peterwoodworth Change made

njlynch
njlynch previously approved these changes Jul 28, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the contribution!

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 28, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed njlynch’s stale review July 28, 2021 14:56

Pull request has been modified.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 29, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jul 29, 2021

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 5a67722
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 7ad9348 into aws:master Jul 29, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 29, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Aug 3, 2021
@iRoachie @TikiTDO
feat(aws-cloudfront): add enabled to web distribution (aws#15433)
1939734 
Allows cloudfront web distribution to be enabled or disabled. This prop is available in `Distribution` but not `CloudFrontWebDistribution`


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@iRoachie @hollanddd
feat(aws-cloudfront): add enabled to web distribution (aws#15433)
9855fff 
Allows cloudfront web distribution to be enabled or disabled. This prop is available in `Distribution` but not `CloudFrontWebDistribution`


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@njlynch njlynch njlynch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@njlynch njlynch

Labels

@aws-cdk/aws-cloudfront Related to Amazon CloudFront pr-linter/exempt-readme The PR linter will not require README changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iRoachie @peterwoodworth @aws-cdk-automation @njlynch