Skip to content

feat(lambda): cloudwatch lambda insights#15439

Merged
mergify[bot] merged 37 commits intoaws:masterfrom
flemjame-at-amazon:lambda-insights-integration
Jul 29, 2021
Merged

feat(lambda): cloudwatch lambda insights#15439
mergify[bot] merged 37 commits intoaws:masterfrom
flemjame-at-amazon:lambda-insights-integration

Conversation

@flemjame-at-amazon
Copy link
Copy Markdown
Contributor

@flemjame-at-amazon flemjame-at-amazon commented Jul 6, 2021 •
edited by nija-at
Loading

Closes #12489

This allows a user to configure Lambda Insights and have the relevant IAM policy be added to the Lambda role.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jul 6, 2021

@peterwoodworth peterwoodworth added the @aws-cdk/aws-lambda Related to AWS Lambda label Jul 6, 2021
nija-at
nija-at previously requested changes Jul 15, 2021
View reviewed changes
@nija-at nija-at added effort/small Small work item – less than a day of effort p2 labels Jul 15, 2021
@nija-at nija-at added effort/medium Medium work item – several days of effort and removed effort/small Small work item – less than a day of effort labels Jul 16, 2021
@mergify mergify bot dismissed nija-at’s stale review July 20, 2021 19:23

Pull request has been modified.

@flemjame-at-amazon
Copy link
Copy Markdown
Contributor Author

flemjame-at-amazon commented Jul 21, 2021

@nija-at I think the latest is more or less in line with your recommendations for user experience. The only area I can think of for improvement is to auto-generate the LambdaInsightsVersion public static readonly members.

https://github.com/aws/aws-cdk/pull/15439/files#diff-203458110222061ed1f54590e8556cf107bfa77c6da383e05f955491045e33faR18-R33

Is there a way to auto-generate these versions from the Fact Tables ?

nija-at
nija-at previously requested changes Jul 29, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delayed review.

This looks great! Thanks for making these changes.
See some of my comments below. Nothing major.

@mergify mergify bot dismissed nija-at’s stale review July 29, 2021 14:09

Pull request has been modified.

nija-at
nija-at previously requested changes Jul 29, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor docs and other updates to polish it up.

Looks great.

@nija-at nija-at changed the title feat(lambda): Lambda insights integration feat(lambda): cloudwatch lambda insights Jul 29, 2021
@mergify mergify bot dismissed nija-at’s stale review July 29, 2021 15:48

Pull request has been modified.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 29, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jul 29, 2021

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: a7f09b9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 9efd800 into aws:master Jul 29, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 29, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@flemjame-at-amazon flemjame-at-amazon deleted the lambda-insights-integration branch July 29, 2021 18:29
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Aug 3, 2021
@flemjame-at-amazon @TikiTDO
feat(lambda): cloudwatch lambda insights (aws#15439)
192d10d 
Closes aws#12489

This allows a user to configure Lambda Insights and have the relevant IAM policy be added to the Lambda role.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@flemjame-at-amazon flemjame-at-amazon mentioned this pull request Aug 13, 2021
Closed
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@flemjame-at-amazon @hollanddd
feat(lambda): cloudwatch lambda insights (aws#15439)
c1bb41f 
Closes aws#12489

This allows a user to configure Lambda Insights and have the relevant IAM policy be added to the Lambda role.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nija-at nija-at nija-at approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nija-at nija-at

Labels

@aws-cdk/aws-lambda Related to AWS Lambda effort/medium Medium work item – several days of effort p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(lambda): Lambda insights functionality

5 participants

@flemjame-at-amazon @aws-cdk-automation @nija-at @peterwoodworth @flemjame-at-amazon2