docs: remove BREAKING CHANGES requirement for feature flags#15839
Merged
mergify[bot] merged 2 commits intomasterfrom Jul 30, 2021
Merged
docs: remove BREAKING CHANGES requirement for feature flags#15839mergify[bot] merged 2 commits intomasterfrom
mergify[bot] merged 2 commits intomasterfrom
Conversation
Feature flags -- by definition -- don't introduce breaking changes to existing customers, simply alter behavior for new apps, or allow opting in to new behavior. Additionally, our linter does not allow breaking changes in stable modules, which means as stands it's impossible to satisfy this requirement and introduce a feature flag for stable modules.
|
|
BenChaimberg
approved these changes
Jul 30, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Aug 3, 2021
Feature flags -- by definition -- don't introduce breaking changes to existing customers, simply alter behavior for new apps, or allow opting in to new behavior. Additionally, our linter does not allow breaking changes in stable modules, which means as stands it's impossible to satisfy this requirement and introduce a feature flag for stable modules. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
Feature flags -- by definition -- don't introduce breaking changes to existing customers, simply alter behavior for new apps, or allow opting in to new behavior. Additionally, our linter does not allow breaking changes in stable modules, which means as stands it's impossible to satisfy this requirement and introduce a feature flag for stable modules. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24
pushed a commit
to david-doyle-as24/aws-cdk
that referenced
this pull request
Sep 7, 2021
Feature flags -- by definition -- don't introduce breaking changes to existing customers, simply alter behavior for new apps, or allow opting in to new behavior. Additionally, our linter does not allow breaking changes in stable modules, which means as stands it's impossible to satisfy this requirement and introduce a feature flag for stable modules. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature flags -- by definition -- don't introduce breaking changes to existing
customers, simply alter behavior for new apps, or allow opting in to new
behavior. Additionally, our linter does not allow breaking changes in stable
modules, which means as stands it's impossible to satisfy this requirement and
introduce a feature flag for stable modules.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license