chore(assertions): rename TemplateAssertions to Template#15823
Merged
mergify[bot] merged 2 commits intomasterfrom Aug 1, 2021
Merged
chore(assertions): rename TemplateAssertions to Template#15823mergify[bot] merged 2 commits intomasterfrom
mergify[bot] merged 2 commits intomasterfrom
Conversation
The class `TemplateAssertions` is already part of the `@aws-cdk/assertions` module. The word 'assertions' is now redundant. Further, this class now has the method `findResources()` which is not an assertion anymore. All assertion methods are named in a way that makes it clear that it is an assertion, viz., `hasResource()`, `resourceCountIs()`, `templateMatches()`.
|
|
eladb
approved these changes
Aug 1, 2021
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Aug 3, 2021
The class `TemplateAssertions` is already part of the `@aws-cdk/assertions` module. The word 'assertions' is redundant. Further, this class now has the method `findResources()` which is not an assertion. All assertion methods are named in a way that makes it clear that it is an assertion, viz., `hasResource()`, `resourceCountIs()`, `templateMatches()`. BREAKING CHANGE: `TemplateAssertions` is now renamed to `Template`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
The class `TemplateAssertions` is already part of the `@aws-cdk/assertions` module. The word 'assertions' is redundant. Further, this class now has the method `findResources()` which is not an assertion. All assertion methods are named in a way that makes it clear that it is an assertion, viz., `hasResource()`, `resourceCountIs()`, `templateMatches()`. BREAKING CHANGE: `TemplateAssertions` is now renamed to `Template`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24
pushed a commit
to david-doyle-as24/aws-cdk
that referenced
this pull request
Sep 7, 2021
The class `TemplateAssertions` is already part of the `@aws-cdk/assertions` module. The word 'assertions' is redundant. Further, this class now has the method `findResources()` which is not an assertion. All assertion methods are named in a way that makes it clear that it is an assertion, viz., `hasResource()`, `resourceCountIs()`, `templateMatches()`. BREAKING CHANGE: `TemplateAssertions` is now renamed to `Template`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The class
TemplateAssertionsis already part of the@aws-cdk/assertionsmodule. The word 'assertions' is redundant.Further, this class now has the method
findResources()which is not anassertion.
All assertion methods are named in a way that makes it clear that it is
an assertion, viz.,
hasResource(),resourceCountIs(),templateMatches().BREAKING CHANGE:
TemplateAssertionsis now renamed toTemplate.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license