feat(kinesisfirehose): supports Kinesis data stream source for delivery stream by BenChaimberg · Pull Request #15836 · aws/aws-cdk

BenChaimberg · 2021-07-30T05:59:00Z

closes #15500
closes #10783

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…DeliveryStream

…eam destinations

…nation

…ream

…eliveryStream

…roperty type and use local var instead

…eam (#15545) Closes #15543 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

…-dest

…adeline-k/feat/kinesisfirehose-dataprocessors

…deline-k/feat/kinesisfirehose-backup

…esisfirehose-backup

…ry stream

gitpod-io · 2021-07-30T05:59:03Z

madeline-k

This looks great! A couple minor comments.

packages/@aws-cdk/aws-kinesisfirehose/lib/delivery-stream.ts

madeline-k · 2021-08-03T19:18:05Z

packages/@aws-cdk/aws-kinesisfirehose/test/integ.delivery-stream.source-stream.ts

+const mockS3Destination: firehose.IDestination = {
+  bind(_scope: constructs.Construct, _options: firehose.DestinationBindOptions): firehose.DestinationConfig {
+    const bucketGrant = bucket.grantReadWrite(role);
+    return {
+      extendedS3DestinationConfiguration: {
+        bucketArn: bucket.bucketArn,
+        roleArn: role.roleArn,
+      },
+      dependables: [bucketGrant],
+    };
+  },
+};


Is this duplicated with the other integration test? Can you make one shared construct for this for the unit and integ tests?

I think for literacy purposes, I'd rather keep this duplicated

…inesis-source

madeline-k

Looks great 👍

mergify · 2021-08-04T19:34:30Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2021-08-04T20:13:33Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2021-08-04T20:13:49Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
Commit ID: 98c77bf
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…ry stream (aws#15836) closes aws#15500 closes aws#10783 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

madeline-k and others added 30 commits July 14, 2021 10:04

feat(aws-kinesisfirehose): DeliveryStream API and basic S3 destination

8401fb4

fix typo in aws-kinesisfirehose-destinations README

dca12f2

remove unnecessary deps

6fceebf

feat(aws-kinesisfirehose): specific metrics functions for DeliveryStream

58b3fe1

feat(aws-kinesisfirehose): Add support for server-side encryption on …

55cb8d6

…DeliveryStream

feat(aws-kinesisfirehose): support for compression on S3 delivery str…

cfc1427

…eam destinations

feat(aws-kinesisfirehose-destinations): support prefixes for S3 desti…

b5b48ed

…nation

Merge branch 'master' into madeline-k/feat/kinesisfirehose-deliveryst…

7892f58

…ream

feat(aws-kinesisfirehose): add support for BufferingHints

be0bf89

feat(aws-kinesisfirehose): support for S3 destination encryption on D…

c764118

…eliveryStream

remove awslint exception for IConnectable.connections

78e6a9c

Change name of S3 destination to S3Bucket

5f7a15c

add Role to DestinationBindOptions, update S3 to S3Bucket in tests

efe2fe0

remove helper function to enforce ExtendedS3DestinationConfigurationP…

4308f44

…roperty type and use local var instead

remove lambda dependency

172ab43

update README

c0d85f5

remove tagsand ITaggable interface

3d34c46

use splitArn instead of parseArn

5ceff5c

update error message for bad input ARN

ce4dde1

add ArnFormat to formatArn() call

0ed658f

update error message in tests for bad input ARN

1925560

pass deliveryStreamName as physicalName through to super constructor

e46c595

move validation to beginning of constructor

d1463a2

simplify createLoggingOptions

1623199

remove awslint exclude

16a54e5

feat(aws-kinesisfirehose): specific metrics functions for DeliveryStr…

b011392

…eam (#15545) Closes #15543 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

change name of s3 destination props to S3BucketProps

56aa16a

remove basic s3 integration test

f70fc31

rename integration tests

73f1777

de-exports DeliveryStreamBase

314c4ca

madeline-k and others added 9 commits July 28, 2021 15:41

don't add unnecessary fields to the template if backup is disabled

07d96c1

don't add encryptionconfiguration to template unless it is needed

e36969d

Merge branch 'master' into madeline-k/feat/kinesisfirehose-encryption…

bf6f4bc

…-dest

Merge branch 'madeline-k/feat/kinesisfirehose-encryption-dest' into m…

6f599a5

…adeline-k/feat/kinesisfirehose-dataprocessors

Merge branch 'madeline-k/feat/kinesisfirehose-dataprocessors' into ma…

0eca26d

…deline-k/feat/kinesisfirehose-backup

fix unit tests after merge

22ef045

Remove outdated buffering docs

d1a6905

Merge remote-tracking branch 'origin/master' into madeline-k/feat/kin…

8efe8d9

…esisfirehose-backup

feat(kinesisfirehose): supports Kinesis data stream source for delive…

72d7478

…ry stream

mergify bot added the contribution/core This is a PR that came from AWS. label Jul 30, 2021

BenChaimberg requested a review from madeline-k July 30, 2021 06:00

add to README

4d02d51

Base automatically changed from madeline-k/feat/kinesisfirehose-backup to master July 30, 2021 18:22

BenChaimberg added 2 commits August 3, 2021 11:44

Merge branch 'master' into chaimber/firehose-kinesis-source

ca0520a

fix merged tests

c53bdf3

madeline-k reviewed Aug 3, 2021

View reviewed changes

BenChaimberg added 2 commits August 3, 2021 12:34

docs and formatting

0657db0

Merge remote-tracking branch 'origin/master' into chaimber/firehose-k…

9355b78

…inesis-source

BenChaimberg requested review from a team and madeline-k August 3, 2021 19:35

madeline-k approved these changes Aug 4, 2021

View reviewed changes

Merge branch 'master' into chaimber/firehose-kinesis-source

98c77bf

mergify bot merged commit afd5bf7 into master Aug 4, 2021

mergify bot deleted the chaimber/firehose-kinesis-source branch August 4, 2021 20:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(kinesisfirehose): supports Kinesis data stream source for delivery stream#15836

feat(kinesisfirehose): supports Kinesis data stream source for delivery stream#15836
mergify[bot] merged 223 commits intomasterfrom
chaimber/firehose-kinesis-source

BenChaimberg commented Jul 30, 2021 •

edited

Loading

Uh oh!

gitpod-io bot commented Jul 30, 2021

Uh oh!

madeline-k left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

madeline-k Aug 3, 2021

Uh oh!

BenChaimberg Aug 3, 2021

Uh oh!

madeline-k left a comment

Uh oh!

mergify bot commented Aug 4, 2021

Uh oh!

mergify bot commented Aug 4, 2021

Uh oh!

aws-cdk-automation commented Aug 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

BenChaimberg commented Jul 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gitpod-io bot commented Jul 30, 2021

Uh oh!

madeline-k left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

madeline-k Aug 3, 2021

Choose a reason for hiding this comment

Uh oh!

BenChaimberg Aug 3, 2021

Choose a reason for hiding this comment

Uh oh!

madeline-k left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Aug 4, 2021

Uh oh!

mergify bot commented Aug 4, 2021

Uh oh!

aws-cdk-automation commented Aug 4, 2021

AWS CodeBuild CI Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

BenChaimberg commented Jul 30, 2021 •

edited

Loading