HOTFIX: Persistent store in ProcessorStateManagerTest#276
Closed
guozhangwang wants to merge 2 commits into
Closed
Conversation
Contributor
Author
There was a problem hiding this comment.
My bad, thanks.
Contributor
|
Thanks for the patch. LGTM |
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Mar 10, 2022
TICKET = LIKAFKA-41601 LI_DESCRIPTION = In the precious commit 26a24fd we add a metric called "MaxRequestAge". Before create a sensor for it, we realized that we didn't attach a tag with broker id to id. This commit is to add brokerId as a tag for the metric. EXIT_CRITERIA = Co-authored-by: Hao Geng <hgeng@hgeng-mn1.linkedin.biz>
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Mar 16, 2022
This also squashes a fix commit - 2ffa2f9 [LI-HOTFIX] Add tag for brokerId on metric maxRequestAge (apache#276) TICKET = LIKAFKA-41601 LI_DESCRIPTION = Current RequestEnqueueTime metric for controller requests does not provide a clear view when request is stuck at remote. That metric only reports value after the response is received. If the response is never received, the metric will not report any value. This PR adds a new metric that purely based on request enqueue time and the current time, which can always report the age of the latest request. EXIT_CRITERIA = Co-authored-by: Hao Geng <hgeng@hgeng-mn1.linkedin.biz>
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Mar 28, 2022
This also squashes a fix commit - 2ffa2f9 [LI-HOTFIX] Add tag for brokerId on metric maxRequestAge (apache#276) TICKET = LIKAFKA-41601 LI_DESCRIPTION = Current RequestEnqueueTime metric for controller requests does not provide a clear view when request is stuck at remote. That metric only reports value after the response is received. If the response is never received, the metric will not report any value. This PR adds a new metric that purely based on request enqueue time and the current time, which can always report the age of the latest request. EXIT_CRITERIA = Co-authored-by: Hao Geng <hgeng@hgeng-mn1.linkedin.biz>
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Jun 16, 2022
This also squashes a fix commit - 2ffa2f9 [LI-HOTFIX] Add tag for brokerId on metric maxRequestAge (apache#276) TICKET = LIKAFKA-41601 LI_DESCRIPTION = Current RequestEnqueueTime metric for controller requests does not provide a clear view when request is stuck at remote. That metric only reports value after the response is received. If the response is never received, the metric will not report any value. This PR adds a new metric that purely based on request enqueue time and the current time, which can always report the age of the latest request. EXIT_CRITERIA = Co-authored-by: Hao Geng <hgeng@hgeng-mn1.linkedin.biz>
davide-armand
pushed a commit
to aiven/kafka
that referenced
this pull request
Dec 1, 2025
jeqo
pushed a commit
to aiven/kafka
that referenced
this pull request
Jan 16, 2026
traceyyoshima
added a commit
to traceyyoshima/kafka
that referenced
this pull request
May 22, 2026
Single bulk apply of the Language Engine's IntelliJ-style format profile across the kafka source tree. Pairs with the IntelliJ-real control branch `intellij-formatting` for side-by-side comparison. Engine state at apply time includes the following format fixes landed against the language-engine repo: Pre-PR #11: - PR apache#275 multi-line // comment indent group - PR apache#276 BLANK_LINES_AROUND_CLASS + sibling no-op repair - PR apache#277 string-concat chain anchor preservation - PR apache#279 forward style through apply routes - PR apache#281 Result-tab line-number alignment - PR apache#282 spaces after return / throw / yield / instanceof - PR apache#283 chain-dot postfix preservation - PR apache#284 BlankLines sibling minimum.* conversion - PR apache#285 chain-dot single-anchor (N=1) preservation - PR apache#286 string-concat chain partial-cascade fix - PR apache#287 method-decl param re-align for misaligned source - PR apache#288 annotation-in-array-init indent Post-original-PR #11 (new in this re-apply): - PR apache#289 partial-cascade post-rewrite-anchor (4 shape fixes: chain-dot postfix follow-on, MI/NewClass close-paren cascade, ternary continuation, lambda body continuation) Stats: 3101 files written, 0 failures, 2678 already-idempotent files skipped (no_change). Corpus byte delta vs trunk: -510 bytes (106275 insertions / 106785 deletions).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ymatsuda @junrao Could you take a quick look? The current unit test is failing on this.