KAFKA-2622: Add Time logical type for Copycat.#285
Closed
ewencp wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
@guozhangwang Quick follow up to the logical types patch. I realized we can't avoid adding a Time type for now since we need it for SQL types in the JDBC connector. Should be a quick review since this is basically the same as the Date type, just zeroing out the date fields instead of the time fields. |
Contributor
Author
|
Actually, hold off on review. I realized there's an issue with validating values when you use Struct.put() that I still need to resolve. |
Contributor
Author
|
Ok, updated to handle logical types in validation, which is really only happening in Struct.put() for now. Should really be ready for review now, @guozhangwang |
Contributor
|
LGTM. |
Contributor
There was a problem hiding this comment.
Is the claim in the exception correct? We should have have non-zero values for some fields.
Contributor
There was a problem hiding this comment.
Right. It should be "any date field"
gardnervickers
pushed a commit
to gardnervickers/kafka-1
that referenced
this pull request
Feb 4, 2021
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Mar 4, 2022
…on (apache#285) TICKET = LIKAFKA-40747 LI_DESCRIPTION = A potential reason for NoOffsetForPartitionException is the transition of FetchState for partitions to any state other than INITIALIZING (e.g. offset_reset). However, there are not enough logs on the client side to see if that was the case. Add logs in the exception message to track the actual fetch state of partitions when a NoOffsetForPartitionException is thrown. (cherry picked from commit aaf8c8d)
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Mar 28, 2022
…on (apache#285) TICKET = LIKAFKA-40747 LI_DESCRIPTION = A potential reason for NoOffsetForPartitionException is the transition of FetchState for partitions to any state other than INITIALIZING (e.g. offset_reset). However, there are not enough logs on the client side to see if that was the case. Add logs in the exception message to track the actual fetch state of partitions when a NoOffsetForPartitionException is thrown. (cherry picked from commit aaf8c8d)
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Jun 16, 2022
…on (apache#285) TICKET = LIKAFKA-40747 LI_DESCRIPTION = A potential reason for NoOffsetForPartitionException is the transition of FetchState for partitions to any state other than INITIALIZING (e.g. offset_reset). However, there are not enough logs on the client side to see if that was the case. Add logs in the exception message to track the actual fetch state of partitions when a NoOffsetForPartitionException is thrown. (cherry picked from commit aaf8c8d)
davide-armand
pushed a commit
to aiven/kafka
that referenced
this pull request
Dec 1, 2025
jeqo
added a commit
to aiven/kafka
that referenced
this pull request
Jan 16, 2026
traceyyoshima
added a commit
to traceyyoshima/kafka
that referenced
this pull request
May 22, 2026
Single bulk apply of the Language Engine's IntelliJ-style format profile across the kafka source tree. Pairs with the IntelliJ-real control branch `intellij-formatting` for side-by-side comparison. Engine state at apply time includes the following format fixes landed against the language-engine repo: Pre-PR #11: - PR apache#275 multi-line // comment indent group - PR apache#276 BLANK_LINES_AROUND_CLASS + sibling no-op repair - PR apache#277 string-concat chain anchor preservation - PR apache#279 forward style through apply routes - PR apache#281 Result-tab line-number alignment - PR apache#282 spaces after return / throw / yield / instanceof - PR apache#283 chain-dot postfix preservation - PR apache#284 BlankLines sibling minimum.* conversion - PR apache#285 chain-dot single-anchor (N=1) preservation - PR apache#286 string-concat chain partial-cascade fix - PR apache#287 method-decl param re-align for misaligned source - PR apache#288 annotation-in-array-init indent Post-original-PR #11 (new in this re-apply): - PR apache#289 partial-cascade post-rewrite-anchor (4 shape fixes: chain-dot postfix follow-on, MI/NewClass close-paren cascade, ternary continuation, lambda body continuation) Stats: 3101 files written, 0 failures, 2678 already-idempotent files skipped (no_change). Corpus byte delta vs trunk: -510 bytes (106275 insertions / 106785 deletions).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.